Merge branch 'gl_crop' into 'master'

Remove var from gl_crop.js

Closes #36280

See merge request gitlab-org/gitlab!20119

app/assets/javascripts/profile/gl_crop.js

-/* eslint-disable no-useless-escape, no-var, no-underscore-dangle, func-names, no-return-assign, one-var, consistent-return, class-methods-use-this */
+/* eslint-disable no-useless-escape, no-underscore-dangle, func-names, no-return-assign, consistent-return, class-methods-use-this */
 
 import $ from 'jquery';
 import 'cropper';
@@ -59,8 +59,7 @@ import _ from 'underscore';
     }
 
     bindEvents() {
-      var _this;
-      _this = this;
+      const _this = this;
       this.fileInput.on('change', function(e) {
         _this.onFileInputChange(e, this);
         this.value = null;
@@ -70,8 +69,7 @@ import _ from 'underscore';
       this.modalCrop.on('hidden.bs.modal', this.onModalHide);
       this.uploadImageBtn.on('click', this.onUploadImageBtnClick);
       this.cropActionsBtn.on('click', function() {
-        var btn;
-        btn = this;
+        const btn = this;
         return _this.onActionBtnClick(btn);
       });
       return (this.croppedImageBlob = null);
@@ -82,8 +80,7 @@ import _ from 'underscore';
     }
 
     onModalShow() {
-      var _this;
-      _this = this;
+      const _this = this;
       return this.modalCropImg.cropper({
         viewMode: 1,
         center: false,
@@ -128,8 +125,7 @@ import _ from 'underscore';
     }
 
     onActionBtnClick(btn) {
-      var data;
-      data = $(btn).data();
+      const data = $(btn).data();
       if (this.modalCropImg.data('cropper') && data.method) {
         return this.modalCropImg.cropper(data.method, data.option);
       }
@@ -140,9 +136,8 @@ import _ from 'underscore';
     }
 
     readFile(input) {
-      var _this, reader;
-      _this = this;
-      reader = new FileReader();
+      const _this = this;
+      const reader = new FileReader();
       reader.onload = () => {
         _this.modalCropImg.attr('src', reader.result);
         return _this.modalCrop.modal('show');
@@ -151,9 +146,10 @@ import _ from 'underscore';
     }
 
     dataURLtoBlob(dataURL) {
-      var array, binary, i, len;
-      binary = atob(dataURL.split(',')[1]);
-      array = [];
+      let i = 0;
+      let len = 0;
+      const binary = atob(dataURL.split(',')[1]);
+      const array = [];
 
       for (i = 0, len = binary.length; i < len; i += 1) {
         array.push(binary.charCodeAt(i));
@@ -164,9 +160,8 @@ import _ from 'underscore';
     }
 
     setPreview() {
-      var filename;
+      const filename = this.fileInput.val().replace(FILENAMEREGEX, '');
       this.previewImage.attr('src', this.dataURL);
-      filename = this.fileInput.val().replace(FILENAMEREGEX, '');
       return this.filename.text(filename);
     }