Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
8fc82cbd
Commit
8fc82cbd
authored
Feb 04, 2020
by
Matija Čupić
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Rename failure reason to be more descriptive
parent
9d810e3d
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
5 additions
and
4 deletions
+5
-4
ee/app/models/ee/commit_status_enums.rb
ee/app/models/ee/commit_status_enums.rb
+1
-1
ee/app/presenters/ee/commit_status_presenter.rb
ee/app/presenters/ee/commit_status_presenter.rb
+1
-1
ee/app/services/ci/create_cross_project_pipeline_service.rb
ee/app/services/ci/create_cross_project_pipeline_service.rb
+1
-1
ee/lib/ee/gitlab/ci/status/build/failed.rb
ee/lib/ee/gitlab/ci/status/build/failed.rb
+1
-1
ee/spec/services/ci/create_cross_project_pipeline_service_spec.rb
...services/ci/create_cross_project_pipeline_service_spec.rb
+1
-0
No files found.
ee/app/models/ee/commit_status_enums.rb
View file @
8fc82cbd
...
...
@@ -16,7 +16,7 @@ module EE
upstream_bridge_project_not_found:
1_004
,
insufficient_upstream_permissions:
1_005
,
bridge_pipeline_is_child_pipeline:
1_006
,
downstream_
bridge_
pipeline_creation_failed:
1_007
)
downstream_pipeline_creation_failed:
1_007
)
end
end
end
...
...
ee/app/presenters/ee/commit_status_presenter.rb
View file @
8fc82cbd
...
...
@@ -12,7 +12,7 @@ module EE
upstream_bridge_project_not_found:
'This job could not be executed because upstream bridge project could not be found.'
,
invalid_bridge_trigger:
'This job could not be executed because downstream pipeline trigger definition is invalid.'
,
bridge_pipeline_is_child_pipeline:
'This job belongs to a child pipeline and cannot create further child pipelines.'
,
downstream_
bridge_pipeline_creation_failed:
'The downstream project
pipeline could not be created.'
downstream_
pipeline_creation_failed:
'The downstream
pipeline could not be created.'
).
freeze
EE
::
CommitStatusPresenter
.
private_constant
:EE_CALLOUT_FAILURE_MESSAGES
...
...
ee/app/services/ci/create_cross_project_pipeline_service.rb
View file @
8fc82cbd
...
...
@@ -30,7 +30,7 @@ module Ci
end
downstream_pipeline
.
tap
do
|
pipeline
|
@bridge
.
drop!
(
:downstream_
bridge_
pipeline_creation_failed
)
if
pipeline
.
has_yaml_errors?
@bridge
.
drop!
(
:downstream_pipeline_creation_failed
)
if
pipeline
.
has_yaml_errors?
end
end
...
...
ee/lib/ee/gitlab/ci/status/build/failed.rb
View file @
8fc82cbd
...
...
@@ -17,7 +17,7 @@ module EE
insufficient_bridge_permissions:
'no permissions to trigger downstream pipeline'
,
insufficient_upstream_permissions:
'no permissions to read upstream project'
,
bridge_pipeline_is_child_pipeline:
'creation of child pipeline not allowed from another child pipeline'
,
downstream_
bridge_pipeline_creation_failed:
'downstream bridge
pipeline can not be created'
downstream_
pipeline_creation_failed:
'downstream
pipeline can not be created'
).
freeze
EE
::
Gitlab
::
Ci
::
Status
::
Build
::
Failed
.
private_constant
:EE_REASONS
end
...
...
ee/spec/services/ci/create_cross_project_pipeline_service_spec.rb
View file @
8fc82cbd
...
...
@@ -265,6 +265,7 @@ describe Ci::CreateCrossProjectPipelineService, '#execute' do
expect
(
pipeline
.
reload
).
to
be_failed
expect
(
bridge
.
reload
).
to
be_failed
expect
(
bridge
.
failure_reason
).
to
eq
(
'downstream_pipeline_creation_failed'
)
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment