Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
9068083f
Commit
9068083f
authored
Aug 10, 2017
by
Oswaldo Ferreira
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add changelog
parent
4f17c6b7
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
5 additions
and
12 deletions
+5
-12
app/models/merge_request.rb
app/models/merge_request.rb
+1
-1
changelogs/unreleased/36114-stuck-mrs-job-follow-up.yml
changelogs/unreleased/36114-stuck-mrs-job-follow-up.yml
+4
-0
spec/workers/merge_worker_spec.rb
spec/workers/merge_worker_spec.rb
+0
-11
No files found.
app/models/merge_request.rb
View file @
9068083f
...
@@ -392,7 +392,7 @@ class MergeRequest < ActiveRecord::Base
...
@@ -392,7 +392,7 @@ class MergeRequest < ActiveRecord::Base
end
end
def
merge_ongoing?
def
merge_ongoing?
merge_jid
&&
!
merged?
!!
merge_jid
&&
!
merged?
end
end
def
closed_without_fork?
def
closed_without_fork?
...
...
changelogs/unreleased/36114-stuck-mrs-job-follow-up.yml
0 → 100644
View file @
9068083f
---
title
:
Present enqueued merge jobs as Merging as well
merge_request
:
author
:
spec/workers/merge_worker_spec.rb
View file @
9068083f
...
@@ -27,15 +27,4 @@ describe MergeWorker do
...
@@ -27,15 +27,4 @@ describe MergeWorker do
expect
(
source_project
.
repository
.
branch_names
).
not_to
include
(
'markdown'
)
expect
(
source_project
.
repository
.
branch_names
).
not_to
include
(
'markdown'
)
end
end
end
end
it
'persists merge_jid'
do
merge_request
=
create
(
:merge_request
,
merge_jid:
nil
)
user
=
create
(
:user
)
worker
=
described_class
.
new
allow
(
worker
).
to
receive
(
:jid
)
{
'999'
}
expect
{
worker
.
perform
(
merge_request
.
id
,
user
.
id
,
{})
}
.
to
change
{
merge_request
.
reload
.
merge_jid
}.
from
(
nil
).
to
(
'999'
)
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment