Commit 90c6fd22 authored by Peter Leitzen's avatar Peter Leitzen Committed by Reuben Pereira

Fix last remaining RuboCop offenses for Naming/FileName

Also, remove exclusion list from `.rubocop_manual_todo.yml`.
parent 6c9e74ac
......@@ -162,13 +162,15 @@ Naming/FileName:
- SSE
- JWT
- HLL
- VSCode
- GPG
- OTP
- GID
- AR
- RSpec
- Javascript
- ECDSA
- ED25519
- GitLab
- JavaScript
# default ones:
- CLI
- DSL
......
......@@ -2597,76 +2597,6 @@ Rails/IncludeUrlHelper:
- 'spec/lib/banzai/filter/reference_redactor_filter_spec.rb'
- 'spec/lib/banzai/reference_redactor_spec.rb'
# WIP: https://gitlab.com/gitlab-org/gitlab/-/issues/343244
Naming/FileName:
Exclude:
- 'app/controllers/concerns/clientside_preview_csp.rb'
- 'app/controllers/concerns/one_trust_csp.rb'
- 'app/controllers/concerns/static_object_external_storage_csp.rb'
- 'app/models/blob_viewer/csv.rb'
- 'app/views/issues/_issues_calendar.ics.ruby'
- 'ee/app/models/dast/branch.rb'
- 'ee/app/models/sca.rb'
- 'ee/lib/ee/gitlab/usage_data_counters/hll_redis_counter.rb'
- 'ee/lib/elastic/v12p1/application_class_proxy.rb'
- 'ee/lib/elastic/v12p1/application_instance_proxy.rb'
- 'ee/lib/elastic/v12p1/config.rb'
- 'ee/lib/elastic/v12p1/issue_class_proxy.rb'
- 'ee/lib/elastic/v12p1/issue_instance_proxy.rb'
- 'ee/lib/elastic/v12p1/merge_request_class_proxy.rb'
- 'ee/lib/elastic/v12p1/merge_request_instance_proxy.rb'
- 'ee/lib/elastic/v12p1/milestone_class_proxy.rb'
- 'ee/lib/elastic/v12p1/milestone_instance_proxy.rb'
- 'ee/lib/elastic/v12p1/note_class_proxy.rb'
- 'ee/lib/elastic/v12p1/note_instance_proxy.rb'
- 'ee/lib/elastic/v12p1/project_class_proxy.rb'
- 'ee/lib/elastic/v12p1/project_instance_proxy.rb'
- 'ee/lib/elastic/v12p1/project_wiki_class_proxy.rb'
- 'ee/lib/elastic/v12p1/project_wiki_instance_proxy.rb'
- 'ee/lib/elastic/v12p1/repository_class_proxy.rb'
- 'ee/lib/elastic/v12p1/repository_instance_proxy.rb'
- 'ee/lib/elastic/v12p1/routing.rb'
- 'ee/lib/elastic/v12p1/snippet_class_proxy.rb'
- 'ee/lib/elastic/v12p1/snippet_instance_proxy.rb'
- 'ee/lib/gitlab/auth/smartcard/san_extension.rb'
- 'ee/lib/gitlab/cidr.rb'
- 'ee/lib/gitlab/elastic/bool_expr.rb'
- 'ee/lib/gitlab/spdx/catalogue.rb'
- 'ee/lib/gitlab/spdx/catalogue_gateway.rb'
- 'ee/lib/gitlab/spdx/license.rb'
- 'ee/lib/gitlab/status_page/storage/object.rb'
- 'haml_lint/inline_javascript.rb'
- 'lib/api/entities/mr_note.rb'
- 'lib/api/helpers/sse_helpers.rb'
- 'lib/gitlab/ci/pipeline/chain/command.rb'
- 'lib/gitlab/database/migrations/observation.rb'
- 'lib/gitlab/health_checks/metric.rb'
- 'lib/gitlab/health_checks/probes/status.rb'
- 'lib/gitlab/health_checks/result.rb'
- 'lib/gitlab/jwt_token.rb'
- 'lib/gitlab/middleware/release_env.rb'
- 'lib/gitlab/redis/hll.rb'
- 'lib/gitlab/slash_commands/result.rb'
- 'lib/gitlab/template_parser/ast.rb'
- 'lib/gitlab/usage/metrics/instrumentations/redis_hll_metric.rb'
- 'lib/gitlab/usage_data_counters/hll_redis_counter.rb'
- 'lib/gitlab/usage_data_counters/vs_code_extension_activity_unique_counter.rb'
- 'qa/qa/fixtures/auto_devops_rack/config.ru'
- 'qa/qa/resource/user_gpg.rb'
- 'qa/qa/runtime/gpg.rb'
- 'qa/qa/runtime/key/ecdsa.rb'
- 'qa/qa/runtime/key/ed25519.rb'
- 'qa/qa/support/otp.rb'
- 'qa/qa/tools/initialize_gitlab_auth.rb'
- 'rubocop/cop/gitlab/change_timzone.rb'
- 'rubocop/cop/gitlab/keys-first-and-values-first.rb'
- 'rubocop/cop/graphql/gid_expected_type.rb'
- 'rubocop/cop/performance/ar_count_each.rb'
- 'rubocop/cop/performance/ar_exists_and_present_blank.rb'
- 'rubocop/rubocop.rb'
- 'tooling/lib/tooling/images.rb'
- 'tooling/lib/tooling/parallel_rspec_runner.rb'
# TODO issue: https://gitlab.com/gitlab-org/gitlab/-/issues/344279
Style/OpenStructUse:
Exclude:
......
# rubocop:disable Naming/FileName
# frozen_string_literal: true
module Gitlab
......@@ -5,3 +6,5 @@ module Gitlab
License = Struct.new(:id, :name, :deprecated, keyword_init: true)
end
end
# rubocop:enable Naming/FileName
# rubocop:todo Naming/FileName
# frozen_string_literal: true
module Gitlab
......@@ -26,3 +27,5 @@ module Gitlab
end
end
end
# rubocop:enable Naming/FileName
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment