Commit 915e35a2 authored by Sean McGivern's avatar Sean McGivern

Merge branch '36670-remove-edit-form' into 'master'

Remove edit action for issues

Closes #36670

See merge request gitlab-org/gitlab-ce!14523
parents 9533786f 17709fa1
...@@ -16,7 +16,7 @@ class Projects::IssuesController < Projects::ApplicationController ...@@ -16,7 +16,7 @@ class Projects::IssuesController < Projects::ApplicationController
before_action :authorize_create_issue!, only: [:new, :create] before_action :authorize_create_issue!, only: [:new, :create]
# Allow modify issue # Allow modify issue
before_action :authorize_update_issue!, only: [:edit, :update, :move] before_action :authorize_update_issue!, only: [:update, :move]
# Allow create a new branch and empty WIP merge request from current issue # Allow create a new branch and empty WIP merge request from current issue
before_action :authorize_create_merge_request!, only: [:create_merge_request] before_action :authorize_create_merge_request!, only: [:create_merge_request]
...@@ -63,10 +63,6 @@ class Projects::IssuesController < Projects::ApplicationController ...@@ -63,10 +63,6 @@ class Projects::IssuesController < Projects::ApplicationController
respond_with(@issue) respond_with(@issue)
end end
def edit
respond_with(@issue)
end
def show def show
@noteable = @issue @noteable = @issue
@note = @project.notes.new(noteable: @issue) @note = @project.notes.new(noteable: @issue)
...@@ -126,10 +122,6 @@ class Projects::IssuesController < Projects::ApplicationController ...@@ -126,10 +122,6 @@ class Projects::IssuesController < Projects::ApplicationController
@issue = Issues::UpdateService.new(project, current_user, update_params).execute(issue) @issue = Issues::UpdateService.new(project, current_user, update_params).execute(issue)
respond_to do |format| respond_to do |format|
format.html do
recaptcha_check_with_fallback { render :edit }
end
format.json do format.json do
render_issue_json render_issue_json
end end
......
- page_title "Edit", "#{@issue.title} (#{@issue.to_reference})", "Issues"
%h3.page-title
Edit Issue ##{@issue.iid}
%hr
= render "form"
---
title: Remove the ability to visit the issue edit form directly
merge_request: 14523
author:
type: removed
...@@ -218,54 +218,15 @@ describe 'New/edit issue', :js do ...@@ -218,54 +218,15 @@ describe 'New/edit issue', :js do
context 'edit issue' do context 'edit issue' do
before do before do
visit edit_project_issue_path(project, issue) visit project_issue_path(project, issue)
end page.within('.content .issuable-actions') do
click_on 'Edit'
it 'allows user to update issue' do
expect(find('input[name="issue[assignee_ids][]"]', visible: false).value).to match(user.id.to_s)
expect(find('input[name="issue[milestone_id]"]', visible: false).value).to match(milestone.id.to_s)
expect(find('a', text: 'Assign to me', visible: false)).not_to be_visible
page.within '.js-user-search' do
expect(page).to have_content user.name
end
page.within '.js-milestone-select' do
expect(page).to have_content milestone.title
end
click_button 'Labels'
page.within '.dropdown-menu-labels' do
click_link label.title
click_link label2.title
end
page.within '.js-label-select' do
expect(page).to have_content label.title
end
expect(page.all('input[name="issue[label_ids][]"]', visible: false)[1].value).to match(label.id.to_s)
expect(page.all('input[name="issue[label_ids][]"]', visible: false)[2].value).to match(label2.id.to_s)
click_button 'Save changes'
page.within '.issuable-sidebar' do
page.within '.assignee' do
expect(page).to have_content user.name
end
page.within '.milestone' do
expect(page).to have_content milestone.title
end
page.within '.labels' do
expect(page).to have_content label.title
expect(page).to have_content label2.title
end
end end
end end
it 'description has autocomplete' do it 'description has autocomplete' do
find('#issue_description').native.send_keys('') find_field('issue-description').native.send_keys('')
fill_in 'issue_description', with: '@' fill_in 'issue-description', with: '@'
expect(page).to have_selector('.atwho-view') expect(page).to have_selector('.atwho-view')
end end
......
require 'spec_helper' require 'spec_helper'
describe 'Issues' do describe 'Issues', :js do
include DropzoneHelper include DropzoneHelper
include IssueHelpers include IssueHelpers
include SortingHelper include SortingHelper
...@@ -24,109 +24,15 @@ describe 'Issues' do ...@@ -24,109 +24,15 @@ describe 'Issues' do
end end
before do before do
visit edit_project_issue_path(project, issue) visit project_issue_path(project, issue)
find('.js-zen-enter').click page.within('.content .issuable-actions') do
end find('.issuable-edit').click
it 'opens new issue popup' do
expect(page).to have_content("Issue ##{issue.iid}")
end
end
describe 'Editing issue assignee' do
let!(:issue) do
create(:issue,
author: user,
assignees: [user],
project: project)
end
it 'allows user to select unassigned', js: true do
visit edit_project_issue_path(project, issue)
expect(page).to have_content "Assignee #{user.name}"
first('.js-user-search').click
click_link 'Unassigned'
click_button 'Save changes'
page.within('.assignee') do
expect(page).to have_content 'No assignee - assign yourself'
end
expect(issue.reload.assignees).to be_empty
end
end
describe 'due date', js: true do
context 'on new form' do
before do
visit new_project_issue_path(project)
end
it 'saves with due date' do
date = Date.today.at_beginning_of_month
fill_in 'issue_title', with: 'bug 345'
fill_in 'issue_description', with: 'bug description'
find('#issuable-due-date').click
page.within '.pika-single' do
click_button date.day
end
expect(find('#issuable-due-date').value).to eq date.to_s
click_button 'Submit issue'
page.within '.issuable-sidebar' do
expect(page).to have_content date.to_s(:medium)
end
end end
find('.issue-details .content-block .js-zen-enter').click
end end
context 'on edit form' do it 'opens new issue popup' do
let(:issue) { create(:issue, author: user, project: project, due_date: Date.today.at_beginning_of_month.to_s) } expect(page).to have_content(issue.description)
before do
visit edit_project_issue_path(project, issue)
end
it 'saves with due date' do
date = Date.today.at_beginning_of_month
expect(find('#issuable-due-date').value).to eq date.to_s
date = date.tomorrow
fill_in 'issue_title', with: 'bug 345'
fill_in 'issue_description', with: 'bug description'
find('#issuable-due-date').click
page.within '.pika-single' do
click_button date.day
end
expect(find('#issuable-due-date').value).to eq date.to_s
click_button 'Save changes'
page.within '.issuable-sidebar' do
expect(page).to have_content date.to_s(:medium)
end
end
it 'warns about version conflict' do
issue.update(title: "New title")
fill_in 'issue_title', with: 'bug 345'
fill_in 'issue_description', with: 'bug description'
click_button 'Save changes'
expect(page).to have_content 'Someone edited the issue the same time you did'
end
end end
end end
......
...@@ -3,6 +3,7 @@ require 'spec_helper' ...@@ -3,6 +3,7 @@ require 'spec_helper'
feature 'issuable templates', js: true do feature 'issuable templates', js: true do
let(:user) { create(:user) } let(:user) { create(:user) }
let(:project) { create(:project, :public, :repository) } let(:project) { create(:project, :public, :repository) }
let(:issue_form_location) { '#content-body .issuable-details .detail-page-description' }
before do before do
project.team << [user, :master] project.team << [user, :master]
...@@ -28,14 +29,17 @@ feature 'issuable templates', js: true do ...@@ -28,14 +29,17 @@ feature 'issuable templates', js: true do
longtemplate_content, longtemplate_content,
message: 'added issue template', message: 'added issue template',
branch_name: 'master') branch_name: 'master')
visit edit_project_issue_path project, issue visit project_issue_path project, issue
fill_in :'issue[title]', with: 'test issue title' page.within('.content .issuable-actions') do
click_on 'Edit'
end
fill_in :'issue-title', with: 'test issue title'
end end
scenario 'user selects "bug" template' do scenario 'user selects "bug" template' do
select_template 'bug' select_template 'bug'
wait_for_requests wait_for_requests
assert_template assert_template(page_part: issue_form_location)
save_changes save_changes
end end
...@@ -43,30 +47,19 @@ feature 'issuable templates', js: true do ...@@ -43,30 +47,19 @@ feature 'issuable templates', js: true do
select_template 'bug' select_template 'bug'
wait_for_requests wait_for_requests
select_option 'No template' select_option 'No template'
assert_template('') assert_template(expected_content: '', page_part: issue_form_location)
save_changes('') save_changes('')
end end
scenario 'user selects "bug" template, edits description and then selects "reset template"' do scenario 'user selects "bug" template, edits description and then selects "reset template"' do
select_template 'bug' select_template 'bug'
wait_for_requests wait_for_requests
find_field('issue_description').send_keys(description_addition) find_field('issue-description').send_keys(description_addition)
assert_template(template_content + description_addition) assert_template(expected_content: template_content + description_addition, page_part: issue_form_location)
select_option 'Reset template' select_option 'Reset template'
assert_template assert_template(page_part: issue_form_location)
save_changes save_changes
end end
it 'updates height of markdown textarea' do
start_height = page.evaluate_script('$(".markdown-area").outerHeight()')
select_template 'test'
wait_for_requests
end_height = page.evaluate_script('$(".markdown-area").outerHeight()')
expect(end_height).not_to eq(start_height)
end
end end
context 'user creates an issue using templates, with a prior description' do context 'user creates an issue using templates, with a prior description' do
...@@ -81,15 +74,18 @@ feature 'issuable templates', js: true do ...@@ -81,15 +74,18 @@ feature 'issuable templates', js: true do
template_content, template_content,
message: 'added issue template', message: 'added issue template',
branch_name: 'master') branch_name: 'master')
visit edit_project_issue_path project, issue visit project_issue_path project, issue
fill_in :'issue[title]', with: 'test issue title' page.within('.content .issuable-actions') do
fill_in :'issue[description]', with: prior_description click_on 'Edit'
end
fill_in :'issue-title', with: 'test issue title'
fill_in :'issue-description', with: prior_description
end end
scenario 'user selects "bug" template' do scenario 'user selects "bug" template' do
select_template 'bug' select_template 'bug'
wait_for_requests wait_for_requests
assert_template("#{template_content}") assert_template(page_part: issue_form_location)
save_changes save_changes
end end
end end
...@@ -154,8 +150,10 @@ feature 'issuable templates', js: true do ...@@ -154,8 +150,10 @@ feature 'issuable templates', js: true do
end end
end end
def assert_template(expected_content = template_content) def assert_template(expected_content: template_content, page_part: '#content-body')
expect(find('textarea')['value']).to eq(expected_content) page.within(page_part) do
expect(find('textarea')['value']).to eq(expected_content)
end
end end
def save_changes(expected_content = template_content) def save_changes(expected_content = template_content)
......
...@@ -181,21 +181,6 @@ describe "Internal Project Access" do ...@@ -181,21 +181,6 @@ describe "Internal Project Access" do
it { is_expected.to be_denied_for(:visitor) } it { is_expected.to be_denied_for(:visitor) }
end end
describe "GET /:project_path/issues/:id/edit" do
let(:issue) { create(:issue, project: project) }
subject { edit_project_issue_path(project, issue) }
it { is_expected.to be_allowed_for(:admin) }
it { is_expected.to be_allowed_for(:owner).of(project) }
it { is_expected.to be_allowed_for(:master).of(project) }
it { is_expected.to be_allowed_for(:developer).of(project) }
it { is_expected.to be_allowed_for(:reporter).of(project) }
it { is_expected.to be_denied_for(:guest).of(project) }
it { is_expected.to be_denied_for(:user) }
it { is_expected.to be_denied_for(:external) }
it { is_expected.to be_denied_for(:visitor) }
end
describe "GET /:project_path/snippets" do describe "GET /:project_path/snippets" do
subject { project_snippets_path(project) } subject { project_snippets_path(project) }
......
...@@ -181,21 +181,6 @@ describe "Private Project Access" do ...@@ -181,21 +181,6 @@ describe "Private Project Access" do
it { is_expected.to be_denied_for(:visitor) } it { is_expected.to be_denied_for(:visitor) }
end end
describe "GET /:project_path/issues/:id/edit" do
let(:issue) { create(:issue, project: project) }
subject { edit_project_issue_path(project, issue) }
it { is_expected.to be_allowed_for(:admin) }
it { is_expected.to be_allowed_for(:owner).of(project) }
it { is_expected.to be_allowed_for(:master).of(project) }
it { is_expected.to be_allowed_for(:developer).of(project) }
it { is_expected.to be_allowed_for(:reporter).of(project) }
it { is_expected.to be_denied_for(:guest).of(project) }
it { is_expected.to be_denied_for(:user) }
it { is_expected.to be_denied_for(:external) }
it { is_expected.to be_denied_for(:visitor) }
end
describe "GET /:project_path/snippets" do describe "GET /:project_path/snippets" do
subject { project_snippets_path(project) } subject { project_snippets_path(project) }
......
...@@ -394,21 +394,6 @@ describe "Public Project Access" do ...@@ -394,21 +394,6 @@ describe "Public Project Access" do
it { is_expected.to be_allowed_for(:visitor) } it { is_expected.to be_allowed_for(:visitor) }
end end
describe "GET /:project_path/issues/:id/edit" do
let(:issue) { create(:issue, project: project) }
subject { edit_project_issue_path(project, issue) }
it { is_expected.to be_allowed_for(:admin) }
it { is_expected.to be_allowed_for(:owner).of(project) }
it { is_expected.to be_allowed_for(:master).of(project) }
it { is_expected.to be_allowed_for(:developer).of(project) }
it { is_expected.to be_allowed_for(:reporter).of(project) }
it { is_expected.to be_denied_for(:guest).of(project) }
it { is_expected.to be_denied_for(:user) }
it { is_expected.to be_denied_for(:external) }
it { is_expected.to be_denied_for(:visitor) }
end
describe "GET /:project_path/snippets" do describe "GET /:project_path/snippets" do
subject { project_snippets_path(project) } subject { project_snippets_path(project) }
......
...@@ -25,11 +25,13 @@ shared_examples 'update invalid issuable' do |klass| ...@@ -25,11 +25,13 @@ shared_examples 'update invalid issuable' do |klass|
.and_raise(ActiveRecord::StaleObjectError.new(issuable, :save)) .and_raise(ActiveRecord::StaleObjectError.new(issuable, :save))
end end
it 'renders edit when format is html' do if klass == MergeRequest
put :update, params it 'renders edit when format is html' do
put :update, params
expect(response).to render_template(:edit) expect(response).to render_template(:edit)
expect(assigns[:conflict]).to be_truthy expect(assigns[:conflict]).to be_truthy
end
end end
it 'renders json error message when format is json' do it 'renders json error message when format is json' do
...@@ -42,16 +44,17 @@ shared_examples 'update invalid issuable' do |klass| ...@@ -42,16 +44,17 @@ shared_examples 'update invalid issuable' do |klass|
end end
end end
context 'when updating an invalid issuable' do if klass == MergeRequest
before do context 'when updating an invalid issuable' do
key = klass == Issue ? :issue : :merge_request before do
params[key][:title] = "" params[:merge_request][:title] = ""
end end
it 'renders edit when merge request is invalid' do it 'renders edit when merge request is invalid' do
put :update, params put :update, params
expect(response).to render_template(:edit) expect(response).to render_template(:edit)
end
end end
end end
end end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment