Merge branch '249439-dast-on-demand-site-profile-edit-page-shows-error-banner' into 'master'

DAST on-demand site profiles: prevent error banner from showing

See merge request gitlab-org/gitlab!42300

ee/app/assets/javascripts/dast_site_profiles_form/components/dast_site_profile_form.vue

@@ -152,7 +152,10 @@ export default {
   async created() {
     if (this.isEdit) {
       this.validateTargetUrl();
-      await this.fetchValidationStatus();
+
+      if (this.glFeatures.securityOnDemandScansSiteValidation) {
+        await this.fetchValidationStatus();
+      }
     }
   },
   methods: {

ee/changelogs/unreleased/249439-dast-on-demand-site-profile-edit-page-shows-error-banner.yml

+---
+title: 'DAST on-demand site profiles: prevent error banner from showing'
+merge_request: 42300
+author:
+type: fixed

ee/spec/frontend/dast_site_profiles_form/components/dast_site_profiles_form_spec.js

@@ -184,12 +184,19 @@ describe('DastSiteProfileForm', () => {
       await findSiteValidationToggle().vm.$emit('change', true);
     };
 
-    describe('with feature flag disabled', () => {
+    describe.each`
+      title                  | siteProfile
+      ${'New site profile'}  | ${null}
+      ${'Edit site profile'} | ${{ id: 1, name: 'foo', targetUrl: 'bar' }}
+    `('$title with feature flag disabled', ({ siteProfile }) => {
       beforeEach(() => {
         createComponent({
           provide: {
             glFeatures: { securityOnDemandScansSiteValidation: false },
           },
+          propsData: {
+            siteProfile,
+          },
         });
       });
 
@@ -197,6 +204,10 @@ describe('DastSiteProfileForm', () => {
         expect(findSiteValidationToggle().exists()).toBe(false);
         expect(findDastSiteValidation().exists()).toBe(false);
       });
+
+      it('does not check the target URLs validation status', () => {
+        expect(requestHandlers.dastSiteValidation).not.toHaveBeenCalled();
+      });
     });
 
     describe('with feature flag enabled', () => {