Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
921bc753
Commit
921bc753
authored
Dec 13, 2018
by
Jasper Maes
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix deprecation: Passing conditions to delete_all is deprecated
parent
07e079e8
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
1 deletion
+6
-1
changelogs/unreleased/deprecated-delete-all-params.yml
changelogs/unreleased/deprecated-delete-all-params.yml
+5
-0
spec/models/merge_request_diff_spec.rb
spec/models/merge_request_diff_spec.rb
+1
-1
No files found.
changelogs/unreleased/deprecated-delete-all-params.yml
0 → 100644
View file @
921bc753
---
title
:
'
Fix
deprecation:
Passing
conditions
to
delete_all
is
deprecated'
merge_request
:
23817
author
:
Jasper Maes
type
:
other
spec/models/merge_request_diff_spec.rb
View file @
921bc753
...
@@ -105,7 +105,7 @@ describe MergeRequestDiff do
...
@@ -105,7 +105,7 @@ describe MergeRequestDiff do
context
'when the raw diffs are empty'
do
context
'when the raw diffs are empty'
do
before
do
before
do
MergeRequestDiffFile
.
delete_all
(
merge_request_diff_id:
diff_with_commits
.
id
)
MergeRequestDiffFile
.
where
(
merge_request_diff_id:
diff_with_commits
.
id
).
delete_all
end
end
it
'returns an empty DiffCollection'
do
it
'returns an empty DiffCollection'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment