Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
934fbdb6
Commit
934fbdb6
authored
Jan 29, 2020
by
Robert May
Committed by
Nick Thomas
Jan 29, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add section on DNS stubbing to documentation
parent
d0d6c3be
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
15 additions
and
0 deletions
+15
-0
doc/development/testing_guide/best_practices.md
doc/development/testing_guide/best_practices.md
+15
-0
No files found.
doc/development/testing_guide/best_practices.md
View file @
934fbdb6
...
...
@@ -385,6 +385,21 @@ NOTE: **Note:**
The usage of
`perform_enqueued_jobs`
is currently useless since our
workers aren't inheriting from
`ApplicationJob`
/
`ActiveJob::Base`
.
#### DNS
DNS requests are stubbed universally in the test suite
(as of
[
!22368
](
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/22368
)
), as DNS can
cause issues depending on the developer's local network. There are RSpec labels
available in
`spec/support/dns.rb`
which you can apply to tests if you need to
bypass the DNS stubbing, e.g.:
```
it "really connects to Prometheus", :permit_dns do
```
And if you need more specific control, the DNS blocking is implemented in
`spec/support/helpers/dns_helpers.rb`
and these methods can be called elsewhere.
#### Filesystem
Filesystem data can be roughly split into "repositories", and "everything else".
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment