Merge branch...

Merge branch '55344-set-npm-package-requests-forwarding-application-setting-to-default-on' into 'master'

Update ApplicationSetting npm_package_requests_forwarding default

Closes #55344

See merge request gitlab-org/gitlab!25684

db/migrate/20200221105436_update_application_setting_npm_package_requests_forwarding_default.rb

+# frozen_string_literal: true
+
+class UpdateApplicationSettingNpmPackageRequestsForwardingDefault < ActiveRecord::Migration[6.0]
+  DOWNTIME = false
+
+  def up
+    change_column_default :application_settings, :npm_package_requests_forwarding, true
+
+    execute('UPDATE application_settings SET npm_package_requests_forwarding = TRUE')
+  end
+
+  def down
+    change_column_default :application_settings, :npm_package_requests_forwarding, false
+
+    execute('UPDATE application_settings SET npm_package_requests_forwarding = FALSE')
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 2020_02_20_180944) do
+ActiveRecord::Schema.define(version: 2020_02_21_105436) do
 
   # These are extensions that must be enabled in order to support this database
   enable_extension "pg_trgm"
@@ -351,7 +351,7 @@ ActiveRecord::Schema.define(version: 2020_02_20_180944) do
     t.boolean "prevent_merge_requests_committers_approval", default: false, null: false
     t.boolean "email_restrictions_enabled", default: false, null: false
     t.text "email_restrictions"
-    t.boolean "npm_package_requests_forwarding", default: false, null: false
+    t.boolean "npm_package_requests_forwarding", default: true, null: false
     t.index ["custom_project_templates_group_id"], name: "index_application_settings_on_custom_project_templates_group_id"
     t.index ["file_template_project_id"], name: "index_application_settings_on_file_template_project_id"
     t.index ["instance_administration_project_id"], name: "index_applicationsettings_on_instance_administration_project_id"

spec/migrations/update_application_setting_npm_package_requests_forwarding_default_spec.rb

+# frozen_string_literal: true
+
+require 'spec_helper'
+require Rails.root.join('db', 'migrate', '20200221105436_update_application_setting_npm_package_requests_forwarding_default.rb')
+
+describe UpdateApplicationSettingNpmPackageRequestsForwardingDefault, :migration do
+  # Create test data - pipeline and CI/CD jobs.
+  let(:application_settings) { table(:application_settings) }
+
+  before do
+    application_settings.create!(npm_package_requests_forwarding: false)
+  end
+
+  # Test just the up migration.
+  it 'correctly migrates the application setting' do
+    expect { migrate! }.to change { current_application_setting }.from(false).to(true)
+  end
+
+  # Test a reversible migration.
+  it 'correctly migrates up and down the application setting' do
+    reversible_migration do |migration|
+      # Expectations will run before the up migration,
+      # and then again after the down migration
+      migration.before -> {
+        expect(current_application_setting).to eq false
+      }
+
+      # Expectations will run after the up migration.
+      migration.after -> {
+        expect(current_application_setting).to eq true
+      }
+    end
+  end
+
+  def current_application_setting
+    ApplicationSetting.current_without_cache.npm_package_requests_forwarding
+  end
+end