Merge branch 'cablett-spec-improvement' into 'master'

Update finder spec to use let_it_be instead of let

See merge request gitlab-org/gitlab!38780

ee/spec/finders/ee/group_members_finder_spec.rb

@@ -5,12 +5,12 @@ require 'spec_helper'
 RSpec.describe GroupMembersFinder do
   subject(:finder) { described_class.new(group) }
 
-  let(:group) { create :group }
+  let_it_be(:group) { create :group }
 
-  let(:non_owner_access_level) { Gitlab::Access.options.values.sample }
-  let!(:group_owner_membership) { group.add_user(create(:user), Gitlab::Access::OWNER) }
-  let!(:group_member_membership) { group.add_user(create(:user), non_owner_access_level) }
-  let!(:dedicated_member_account_membership) do
+  let_it_be(:non_owner_access_level) { Gitlab::Access.options.values.sample }
+  let_it_be(:group_owner_membership) { group.add_user(create(:user), Gitlab::Access::OWNER) }
+  let_it_be(:group_member_membership) { group.add_user(create(:user), non_owner_access_level) }
+  let_it_be(:dedicated_member_account_membership) do
     group.add_user(create(:user, managing_group: group), non_owner_access_level)
   end