Commit 94b2f3bd authored by Gilang Gumilar's avatar Gilang Gumilar Committed by Martin Wortschack

Remove project_list_show_mr_count feature flag

parent e63b2925
...@@ -295,7 +295,7 @@ module ProjectsHelper ...@@ -295,7 +295,7 @@ module ProjectsHelper
end end
def show_merge_request_count?(disabled: false, compact_mode: false) def show_merge_request_count?(disabled: false, compact_mode: false)
!disabled && !compact_mode && Feature.enabled?(:project_list_show_mr_count, default_enabled: true) !disabled && !compact_mode
end end
def show_issue_count?(disabled: false, compact_mode: false) def show_issue_count?(disabled: false, compact_mode: false)
......
---
title: Remove project_list_show_mr_count feature flag.
merge_request: 31789
author: Gilang Gumilar
type: removed
...@@ -719,11 +719,7 @@ describe ProjectsHelper do ...@@ -719,11 +719,7 @@ describe ProjectsHelper do
end end
describe '#show_merge_request_count' do describe '#show_merge_request_count' do
context 'when the feature flag is enabled' do context 'enabled flag' do
before do
stub_feature_flags(project_list_show_mr_count: true)
end
it 'returns true if compact mode is disabled' do it 'returns true if compact mode is disabled' do
expect(helper.show_merge_request_count?).to be_truthy expect(helper.show_merge_request_count?).to be_truthy
end end
...@@ -733,22 +729,7 @@ describe ProjectsHelper do ...@@ -733,22 +729,7 @@ describe ProjectsHelper do
end end
end end
context 'when the feature flag is disabled' do
before do
stub_feature_flags(project_list_show_mr_count: false)
end
it 'always returns false' do
expect(helper.show_merge_request_count?(disabled: false)).to be_falsy
expect(helper.show_merge_request_count?(disabled: true)).to be_falsy
end
end
context 'disabled flag' do context 'disabled flag' do
before do
stub_feature_flags(project_list_show_mr_count: true)
end
it 'returns false if disabled flag is true' do it 'returns false if disabled flag is true' do
expect(helper.show_merge_request_count?(disabled: true)).to be_falsey expect(helper.show_merge_request_count?(disabled: true)).to be_falsey
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment