Merge branch '267004-ml-update-project-page-object-matchers' into 'master'

Update tests to use page object predicate methods

See merge request gitlab-org/gitlab!44959

qa/qa/specs/features/browser_ui/3_create/repository/protocol_v2_push_http_spec.rb

@@ -37,8 +37,10 @@ module QA
         project.wait_for_push_new_branch
 
         # Check that the push worked
-        expect(page).to have_content(file_name)
-        expect(page).to have_content(file_content)
+        Page::Project::Show.perform do |project_page|
+          expect(project_page).to have_file(file_name)
+          expect(project_page).to have_readme_content(file_content)
+        end
 
         # And check that the correct Git protocol was used
         expect(git_protocol_reported).to eq(git_protocol)

qa/qa/specs/features/browser_ui/3_create/repository/push_mirroring_lfs_over_http_spec.rb

@@ -37,8 +37,10 @@ module QA
 
         # Check that the target project has the commit from the source
         target_project.visit!
-        expect(page).to have_content('README.md')
-        expect(page).to have_content('The rendered file could not be displayed because it is stored in LFS')
+        Page::Project::Show.perform do |project_page|
+          expect(project_page).to have_file('README.md')
+          expect(project_page).to have_readme_content('The rendered file could not be displayed because it is stored in LFS')
+        end
       end
     end
   end

qa/qa/specs/features/browser_ui/3_create/repository/push_over_http_spec.rb

@@ -36,8 +36,10 @@ module QA
 
         project.visit!
 
-        expect(page).to have_content('README.md')
-        expect(page).to have_content("This is a test project named #{project.name}")
+        Page::Project::Show.perform do |project_page|
+          expect(project_page).to have_file('README.md')
+          expect(project_page).to have_readme_content("This is a test project named #{project.name}")
+        end
       end
     end
   end

qa/qa/specs/features/ee/browser_ui/3_create/repository/pull_mirroring_over_http_spec.rb

@@ -35,9 +35,12 @@ module QA
 
         # Check that the target project has the commit from the source
         target_project.visit!
-        expect(page).to have_content("README.md")
-        expect(page).to have_content("This is a pull mirroring test project")
-        expect(page).to have_content("Mirrored from #{masked_url(source_project_uri)}")
+
+        Page::Project::Show.perform do |project|
+          expect(project).to have_file('README.md')
+          expect(project).to have_readme_content('This is a pull mirroring test project')
+          expect(project).to have_text("Mirrored from #{masked_url(source_project_uri)}")
+        end
       end
 
       def masked_url(url)

qa/qa/specs/features/ee/browser_ui/3_create/repository/pull_mirroring_over_ssh_with_key_spec.rb

@@ -58,9 +58,11 @@ module QA
 
         # Check that the target project has the commit from the source
         target_project.visit!
-        expect(page).to have_content('README.md')
-        expect(page).to have_content('This is a pull mirroring test project')
-        expect(page).to have_content("Mirrored from #{masked_url(source_project_uri)}")
+        Page::Project::Show.perform do |project|
+          expect(project).to have_file('README.md')
+          expect(project).to have_readme_content('This is a pull mirroring test project')
+          expect(project).to have_text("Mirrored from #{masked_url(source_project_uri)}")
+        end
       end
 
       def masked_url(url)