Add atomic and cleanup-on-fail parameters

To help when dealing with upgrades and failed
states in Helm

changelogs/unreleased/add_helm_params_rollback_related.yml

+---
+title: Add atomic and cleanup-on-fail parameters for Helm
+merge_request: 27721
+author:
+type: changed

lib/gitlab/kubernetes/helm/install_command.rb

@@ -44,6 +44,7 @@ module Gitlab
         def install_command
           command = ['helm', 'upgrade', name, chart] +
             install_flag +
+            rollback_support_flag +
             reset_values_flag +
             tls_flags_if_remote_tiller +
             optional_version_flag +
@@ -83,6 +84,10 @@ module Gitlab
 
           ['--version', version]
         end
+
+        def rollback_support_flag
+          ['--atomic', '--cleanup-on-fail']
+        end
       end
     end
   end

spec/lib/gitlab/kubernetes/helm/install_command_spec.rb

@@ -41,6 +41,8 @@ describe Gitlab::Kubernetes::Helm::InstallCommand do
       <<~EOS.squish
       helm upgrade app-name chart-name
         --install
+        --atomic
+        --cleanup-on-fail
         --reset-values
         --version 1.2.3
         --set rbac.create\\=false,rbac.enabled\\=false
@@ -79,6 +81,8 @@ describe Gitlab::Kubernetes::Helm::InstallCommand do
         <<~EOS.squish
         helm upgrade app-name chart-name
         --install
+        --atomic
+        --cleanup-on-fail
         --reset-values
         #{tls_flags}
         --version 1.2.3
@@ -109,6 +113,8 @@ describe Gitlab::Kubernetes::Helm::InstallCommand do
         <<~EOS.squish
         helm upgrade app-name chart-name
           --install
+          --atomic
+          --cleanup-on-fail
           --reset-values
           --version 1.2.3
           --set rbac.create\\=true,rbac.enabled\\=true
@@ -140,6 +146,8 @@ describe Gitlab::Kubernetes::Helm::InstallCommand do
         <<~EOS.squish
         helm upgrade app-name chart-name
           --install
+          --atomic
+          --cleanup-on-fail
           --reset-values
           --version 1.2.3
           --set rbac.create\\=false,rbac.enabled\\=false
@@ -171,6 +179,8 @@ describe Gitlab::Kubernetes::Helm::InstallCommand do
         <<~EOS.squish
         helm upgrade app-name chart-name
           --install
+          --atomic
+          --cleanup-on-fail
           --reset-values
           --version 1.2.3
           --set rbac.create\\=false,rbac.enabled\\=false
@@ -200,6 +210,8 @@ describe Gitlab::Kubernetes::Helm::InstallCommand do
         <<~EOS.squish
         helm upgrade app-name chart-name
            --install
+           --atomic
+           --cleanup-on-fail
            --reset-values
            --version 1.2.3
            --set rbac.create\\=false,rbac.enabled\\=false
@@ -229,6 +241,8 @@ describe Gitlab::Kubernetes::Helm::InstallCommand do
         <<~EOS.squish
         helm upgrade app-name chart-name
           --install
+          --atomic
+          --cleanup-on-fail
           --reset-values
           --set rbac.create\\=false,rbac.enabled\\=false
           --namespace gitlab-managed-apps