Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
98671f66
Commit
98671f66
authored
Apr 06, 2017
by
http://jneen.net/
Committed by
Felipe Artur
Apr 06, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
update the comment to be a little more accurate
parent
367cfefa
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
14 additions
and
18 deletions
+14
-18
app/models/ee/issue.rb
app/models/ee/issue.rb
+14
-18
No files found.
app/models/ee/issue.rb
View file @
98671f66
...
...
@@ -7,24 +7,20 @@ module EE
# override
def
subscribed_without_subscriptions?
(
user
,
*
)
# TODO: this really shouldn't be necessary, because
# the support bot should be a participant (which is
# what the superclass method checks for). However,
# the support bot is not permitted to :read_project
# the project, so it gets filtered out at the end of
# Participable#raw_participants. Overriding *that*
# behavior is problematic because it doesn't use the
# Policy framework, and instead uses a custom-coded
# Ability.users_that_can_read_project, which is...
# a pain to override in EE. So... here we say, the
# support bot is subscribed by default, until an
# unsubscribed record appears, even though it's not
# *technically* a participant in this issue.
#
# Making the support bot subscribed to every issue
# is not as bad as it seems, though, since it isn't
# permitted to :receive_notifications, and doesn't
# actually show up in the participants list.
# TODO: this really shouldn't be necessary, because the support
# bot should be a participant (which is what the superclass
# method checks for). However, the support bot gets filtered out
# at the end of Participable#raw_participants as not being able
# to read the project. Overriding *that* behavior is problematic
# because it doesn't use the Policy framework, and instead uses a
# custom-coded Ability.users_that_can_read_project, which is...
# a pain to override in EE. So... here we say, the support bot
# is subscribed by default, until an unsubscribed record appears,
# even though it's not *technically* a participant in this issue.
# Making the support bot subscribed to every issue is not as bad as it
# seems, though, since it isn't permitted to :receive_notifications,
# and doesn't actually show up in the participants list.
user
.
support_bot?
||
super
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment