Merge branch 'mattkasa/220522-terraform-artifact-limit' into 'master'

Changes limit for terraform artifacts to 5MB

Closes #220522

See merge request gitlab-org/gitlab!37018

changelogs/unreleased/mattkasa-220522-terraform-artifact-limit.yml

+---
+title: Changes limit for terraform artifacts to 5MB
+merge_request: 37018
+author:
+type: changed

db/migrate/20200701221303_change_default_value_of_ci_max_artifact_size_terraform_of_plan_limits_from_0_to_5.rb

+# frozen_string_literal: true
+
+class ChangeDefaultValueOfCiMaxArtifactSizeTerraformOfPlanLimitsFrom0To5 < ActiveRecord::Migration[6.0]
+  include Gitlab::Database::MigrationHelpers
+
+  DOWNTIME = false
+
+  def up
+    with_lock_retries do
+      change_column_default :plan_limits, :ci_max_artifact_size_terraform, 5
+      execute('UPDATE plan_limits SET ci_max_artifact_size_terraform = 5 WHERE ci_max_artifact_size_terraform = 0')
+    end
+  end
+
+  def down
+    with_lock_retries do
+      change_column_default :plan_limits, :ci_max_artifact_size_terraform, 0
+      execute('UPDATE plan_limits SET ci_max_artifact_size_terraform = 0 WHERE ci_max_artifact_size_terraform = 5')
+    end
+  end
+end

db/structure.sql

@@ -13885,7 +13885,7 @@ CREATE TABLE public.plan_limits (
     ci_max_artifact_size_network_referee integer DEFAULT 0 NOT NULL,
     ci_max_artifact_size_dotenv integer DEFAULT 0 NOT NULL,
     ci_max_artifact_size_cobertura integer DEFAULT 0 NOT NULL,
-    ci_max_artifact_size_terraform integer DEFAULT 0 NOT NULL,
+    ci_max_artifact_size_terraform integer DEFAULT 5 NOT NULL,
     ci_max_artifact_size_accessibility integer DEFAULT 0 NOT NULL,
     ci_max_artifact_size_cluster_applications integer DEFAULT 0 NOT NULL,
     ci_max_artifact_size_secret_detection integer DEFAULT 0 NOT NULL,
@@ -23839,6 +23839,7 @@ COPY "schema_migrations" (version) FROM STDIN;
 20200701093859
 20200701190523
 20200701205710
+20200701221303
 20200702123805
 20200702201039
 20200703064117

spec/models/plan_limits_spec.rb

@@ -197,7 +197,6 @@ RSpec.describe PlanLimits do
         ci_max_artifact_size_network_referee
         ci_max_artifact_size_dotenv
         ci_max_artifact_size_cobertura
-        ci_max_artifact_size_terraform
         ci_max_artifact_size_accessibility
         ci_max_artifact_size_cluster_applications
         ci_max_artifact_size_secret_detection