Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
99425549
Commit
99425549
authored
May 14, 2020
by
Rajendra Kadam
Committed by
Peter Leitzen
May 14, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix leaky constant
parent
43084ec7
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
8 additions
and
4 deletions
+8
-4
.rubocop.yml
.rubocop.yml
+0
-1
changelogs/unreleased/leaky-constant-fix-20.yml
changelogs/unreleased/leaky-constant-fix-20.yml
+5
-0
spec/migrations/cleanup_optimistic_locking_nulls_pt2_fixed_spec.rb
...ations/cleanup_optimistic_locking_nulls_pt2_fixed_spec.rb
+3
-3
No files found.
.rubocop.yml
View file @
99425549
...
...
@@ -384,7 +384,6 @@ RSpec/LeakyConstantDeclaration:
-
'
spec/mailers/notify_spec.rb'
-
'
spec/migrations/20191125114345_add_admin_mode_protected_path_spec.rb'
-
'
spec/migrations/encrypt_plaintext_attributes_on_application_settings_spec.rb'
-
'
spec/migrations/cleanup_optimistic_locking_nulls_pt2_fixed_spec.rb'
-
'
spec/models/clusters/cluster_spec.rb'
-
'
spec/models/concerns/batch_destroy_dependent_associations_spec.rb'
-
'
spec/models/concerns/blocks_json_serialization_spec.rb'
...
...
changelogs/unreleased/leaky-constant-fix-20.yml
0 → 100644
View file @
99425549
---
title
:
Fix leaky constant issue in
null
s pt2 spec
merge_request
:
32058
author
:
Rajendra Kadam
type
:
fixed
spec/migrations/cleanup_optimistic_locking_nulls_pt2_fixed_spec.rb
View file @
99425549
...
...
@@ -4,11 +4,11 @@ require 'spec_helper'
require
Rails
.
root
.
join
(
'db'
,
'post_migrate'
,
'20200427064130_cleanup_optimistic_locking_nulls_pt2_fixed.rb'
)
describe
CleanupOptimisticLockingNullsPt2Fixed
,
:migration
do
TABLES
=
%w(ci_stages ci_builds ci_pipelines)
.
freeze
TABLES
.
each
do
|
table
|
test_tables
=
%w(ci_stages ci_builds ci_pipelines)
.
freeze
test_tables
.
each
do
|
table
|
let
(
table
.
to_sym
)
{
table
(
table
.
to_sym
)
}
end
let
(
:tables
)
{
TABLES
.
map
{
|
t
|
method
(
t
.
to_sym
).
call
}
}
let
(
:tables
)
{
test_tables
.
map
{
|
t
|
method
(
t
.
to_sym
).
call
}
}
before
do
# Create necessary rows
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment