Merge branch 'issue#220040-fix-rails-savebang-gitaly-client-module' into 'master'

Fix Rails/SaveBang Rubocop offenses for gitaly client models

See merge request gitlab-org/gitlab!58089

.rubocop_manual_todo.yml

@@ -180,8 +180,6 @@ Rails/SaveBang:
     - 'spec/lib/gitlab/email/handler/unsubscribe_handler_spec.rb'
     - 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb'
     - 'spec/lib/gitlab/git_access_spec.rb'
-    - 'spec/lib/gitlab/gitaly_client/object_pool_service_spec.rb'
-    - 'spec/lib/gitlab/gitaly_client/repository_service_spec.rb'
     - 'spec/lib/gitlab/import_export/avatar_saver_spec.rb'
     - 'spec/lib/gitlab/import_export/base/relation_factory_spec.rb'
     - 'spec/lib/gitlab/import_export/design_repo_restorer_spec.rb'

changelogs/unreleased/issue-220040-fix-rails-savebang-gitaly-client-module.yml

+---
+title: Fix Rails/SaveBang Rubocop offenses for gitaly client models
+merge_request: 58089
+author: Huzaifa Iftikhar @huzaifaiftikhar
+type: fixed

spec/lib/gitlab/gitaly_client/object_pool_service_spec.rb

@@ -11,7 +11,7 @@ RSpec.describe Gitlab::GitalyClient::ObjectPoolService do
   subject { described_class.new(object_pool) }
 
   before do
-    subject.create(raw_repository)
+    subject.create(raw_repository) # rubocop:disable Rails/SaveBang
   end
 
   describe '#create' do
@@ -22,7 +22,7 @@ RSpec.describe Gitlab::GitalyClient::ObjectPoolService do
     context 'when the pool already exists' do
       it 'returns an error' do
         expect do
-          subject.create(raw_repository)
+          subject.create(raw_repository) # rubocop:disable Rails/SaveBang
         end.to raise_error(GRPC::FailedPrecondition)
       end
     end

spec/lib/gitlab/gitaly_client/repository_service_spec.rb

@@ -270,7 +270,7 @@ RSpec.describe Gitlab::GitalyClient::RepositoryService do
     let(:object_pool_service) { Gitlab::GitalyClient::ObjectPoolService.new(object_pool) }
 
     before do
-      object_pool_service.create(repository)
+      object_pool_service.create(repository) # rubocop:disable Rails/SaveBang
       object_pool_service.link_repository(repository)
     end