Commit 9aafb2a6 authored by Filipa Lacerda's avatar Filipa Lacerda

Merge branch 'improve-handleLocationHash-tests' into 'master'

Improve gl.utils.handleLocationHash tests

See merge request !9040
parents 3848856a 76b078ce
---
title: Improve gl.utils.handleLocationHash tests
merge_request:
author:
...@@ -43,14 +43,35 @@ require('~/lib/utils/common_utils'); ...@@ -43,14 +43,35 @@ require('~/lib/utils/common_utils');
describe('gl.utils.handleLocationHash', () => { describe('gl.utils.handleLocationHash', () => {
beforeEach(() => { beforeEach(() => {
window.history.pushState({}, null, '#definição'); spyOn(window.document, 'getElementById').and.callThrough();
}); });
function expectGetElementIdToHaveBeenCalledWith(elementId) {
expect(window.document.getElementById).toHaveBeenCalledWith(elementId);
}
it('decodes hash parameter', () => { it('decodes hash parameter', () => {
spyOn(window.document, 'getElementById').and.callThrough(); window.history.pushState({}, null, '#random-hash');
gl.utils.handleLocationHash();
expectGetElementIdToHaveBeenCalledWith('random-hash');
expectGetElementIdToHaveBeenCalledWith('user-content-random-hash');
});
it('decodes cyrillic hash parameter', () => {
window.history.pushState({}, null, '#definição');
gl.utils.handleLocationHash(); gl.utils.handleLocationHash();
expect(window.document.getElementById).toHaveBeenCalledWith('definição');
expect(window.document.getElementById).toHaveBeenCalledWith('user-content-definição'); expectGetElementIdToHaveBeenCalledWith('definição');
expectGetElementIdToHaveBeenCalledWith('user-content-definição');
});
it('decodes encoded cyrillic hash parameter', () => {
window.history.pushState({}, null, '#defini%C3%A7%C3%A3o');
gl.utils.handleLocationHash();
expectGetElementIdToHaveBeenCalledWith('definição');
expectGetElementIdToHaveBeenCalledWith('user-content-definição');
}); });
}); });
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment