Commit 9b807a10 authored by Shinya Maeda's avatar Shinya Maeda

Improve test quality

parent 66d43c84
......@@ -25,7 +25,7 @@ describe 'Environment' do
end
context 'without deployments' do
it 'does show no deployments' do
it 'does not show deployments' do
expect(page).to have_content('You don\'t have any deployments right now.')
end
end
......@@ -64,7 +64,7 @@ describe 'Environment' do
create(:deployment, :running, environment: environment, deployable: build)
end
it 'does show no deployments' do
it 'does not show deployments' do
expect(page).to have_content('You don\'t have any deployments right now.')
end
end
......@@ -77,7 +77,7 @@ describe 'Environment' do
create(:deployment, :failed, environment: environment, deployable: build)
end
it 'does show no deployments' do
it 'does not show deployments' do
expect(page).to have_content('You don\'t have any deployments right now.')
end
end
......
......@@ -99,7 +99,7 @@ describe EnvironmentStatus do
let(:user) { project.owner }
before do
build.deployment&.update(sha: sha)
build.deployment&.update!(sha: sha)
end
context 'when environment is created on a forked project' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment