Merge branch '299105-fix-migrations' into 'master'

Fix Style/FrozenStringLiteralComment violations in db, ee/db

See merge request gitlab-org/gitlab!53253

.rubocop_manual_todo.yml

@@ -2648,55 +2648,6 @@ Style/FrozenStringLiteralComment:
     - 'bin/secpick'
     - 'danger/changes_size/Dangerfile'
     - 'danger/metadata/Dangerfile'
-    - 'db/migrate/20190325080727_truncate_user_fullname.rb'
-    - 'db/migrate/20190828110802_add_not_null_constraints_to_prometheus_metrics_y_label_and_unit.rb'
-    - 'db/migrate/20190828172831_create_package_tag.rb'
-    - 'db/migrate/20191003195218_add_pendo_enabled_to_application_settings.rb'
-    - 'db/migrate/20191003195620_add_pendo_url_to_application_settings.rb'
-    - 'db/migrate/20191120200015_add_index_to_grafana_integrations.rb'
-    - 'db/migrate/20200229171700_create_custom_emojis.rb'
-    - 'db/migrate/20201004163918_remove_project_id_and_id_index_from_vulnerabilities_table.rb'
-    - 'db/migrate/20201214000000_change_mr_allow_maintainer_to_push_default.rb'
-    - 'db/optional_migrations/composite_primary_keys.rb'
-    - 'db/post_migrate/20190214112022_schedule_sync_issuables_state_id.rb'
-    - 'db/post_migrate/20201030121314_schedule_update_existing_users_that_require_two_factor_auth.rb'
-    - 'ee/db/fixtures/development/20_burndown.rb'
-    - 'ee/db/fixtures/development/20_vulnerabilities.rb'
-    - 'ee/db/fixtures/development/22_epics.rb'
-    - 'ee/db/geo/migrate/20170206203234_create_project_registry.rb'
-    - 'ee/db/geo/migrate/20170223033541_create_file_registry.rb'
-    - 'ee/db/geo/migrate/20170302005747_add_index_to_project_id_on_project_registry.rb'
-    - 'ee/db/geo/migrate/20170526214010_convert_file_bytes_to_int64.rb'
-    - 'ee/db/geo/migrate/20170605154253_create_event_log_state.rb'
-    - 'ee/db/geo/migrate/20170606155045_add_needs_resync_to_project_registry.rb'
-    - 'ee/db/geo/migrate/20170614201943_add_last_wiki_synced_at_to_project_registry.rb'
-    - 'ee/db/geo/migrate/20170627195211_add_index_to_project_registry.rb'
-    - 'ee/db/geo/migrate/20170906174622_remove_duplicates_from_project_registry.rb'
-    - 'ee/db/geo/migrate/20170906182752_add_unique_index_to_project_id_on_project_registry.rb'
-    - 'ee/db/geo/migrate/20171005045404_remove_file_uploads_from_registry.rb'
-    - 'ee/db/geo/migrate/20171009162208_add_file_registry_success.rb'
-    - 'ee/db/geo/migrate/20171009162209_add_file_registry_success_index.rb'
-    - 'ee/db/geo/migrate/20171101105200_add_retry_count_fields_to_registries.rb'
-    - 'ee/db/geo/migrate/20171115143841_add_last_sync_failure_to_project_registry.rb'
-    - 'ee/db/geo/migrate/20180201154345_add_repository_verification_to_project_registry.rb'
-    - 'ee/db/geo/migrate/20180314175612_add_partial_index_to_project_registy_verification_failure_columns.rb'
-    - 'ee/db/geo/migrate/20180315222132_add_partial_index_to_project_registy_checksum_columns.rb'
-    - 'ee/db/geo/migrate/20180321144947_change_repository_verification_checksum_to_sha.rb'
-    - 'ee/db/geo/migrate/20180322062741_migrate_ci_job_artifacts_to_separate_registry.rb'
-    - 'ee/db/geo/migrate/20180323182105_add_missing_on_primary_to_file_registry.rb'
-    - 'ee/db/geo/migrate/20180327071612_add_partial_index_to_project_registy_checksum_sha_columns.rb'
-    - 'ee/db/geo/migrate/20180402170913_add_missing_on_primary_to_job_artifact_registry..rb'
-    - 'ee/db/geo/migrate/20180405074130_add_partial_index_project_repository_verification.rb'
-    - 'ee/db/geo/migrate/20180412213305_add_index_to_artifact_id_on_job_artifact_registry.rb'
-    - 'ee/db/geo/migrate/20180419174834_add_checksum_mismatch_fields_to_project_registry.rb'
-    - 'ee/db/geo/migrate/20180419192603_add_indexes_to_checksum_mismatch_fields_on_project_registry.rb'
-    - 'ee/db/geo/migrate/20180427114641_add_repository_check_to_geo_project_registry.rb'
-    - 'ee/db/geo/migrate/20180510223634_set_resync_flag_for_retried_projects.rb'
-    - 'ee/db/geo/migrate/20180613184349_add_resync_was_scheduled_at_to_project_registry.rb'
-    - 'ee/db/geo/post_migrate/20180320011914_remove_last_verification_failed_columns_from_geo_project_registry.rb'
-    - 'ee/db/geo/post_migrate/20180320013929_remove_last_verification_at_columns_from_geo_project_registry.rb'
-    - 'ee/db/geo/post_migrate/20180326171626_remove_old_repository_verification_checksum_from_geo_project_registry.rb'
-    - 'ee/db/geo/post_migrate/20180331055706_delete_job_artifacts_from_file_registry.rb'
     - 'ee/lib/tasks/geo.rake'
     - 'ee/lib/tasks/geo/git.rake'
     - 'ee/lib/tasks/geo/replication.rake'

db/migrate/20190325080727_truncate_user_fullname.rb

+# frozen_string_literal: true
+
 # rubocop:disable Migration/UpdateLargeTable
 class TruncateUserFullname < ActiveRecord::Migration[5.0]
   include Gitlab::Database::MigrationHelpers

db/migrate/20190828110802_add_not_null_constraints_to_prometheus_metrics_y_label_and_unit.rb

+# frozen_string_literal: true
+
 class AddNotNullConstraintsToPrometheusMetricsYLabelAndUnit < ActiveRecord::Migration[5.2]
   DOWNTIME = false
 

db/migrate/20190828172831_create_package_tag.rb

+# frozen_string_literal: true
+
 # frozen_string_literal: true .
 
 class CreatePackageTag < ActiveRecord::Migration[5.2]

db/migrate/20191003195218_add_pendo_enabled_to_application_settings.rb

+# frozen_string_literal: true
+
 class AddPendoEnabledToApplicationSettings < ActiveRecord::Migration[5.2]
   include Gitlab::Database::MigrationHelpers
 

db/migrate/20191003195620_add_pendo_url_to_application_settings.rb

+# frozen_string_literal: true
+
 class AddPendoUrlToApplicationSettings < ActiveRecord::Migration[5.2]
   include Gitlab::Database::MigrationHelpers
 

db/migrate/20191120200015_add_index_to_grafana_integrations.rb

+# frozen_string_literal: true
+
 class AddIndexToGrafanaIntegrations < ActiveRecord::Migration[5.2]
   include Gitlab::Database::MigrationHelpers
 

db/migrate/20200229171700_create_custom_emojis.rb

+# frozen_string_literal: true
+
 class CreateCustomEmojis < ActiveRecord::Migration[5.2]
   include Gitlab::Database::MigrationHelpers
   DOWNTIME = false

db/migrate/20201004163918_remove_project_id_and_id_index_from_vulnerabilities_table.rb

+# frozen_string_literal: true
+
 class RemoveProjectIdAndIdIndexFromVulnerabilitiesTable < ActiveRecord::Migration[6.0]
   include Gitlab::Database::MigrationHelpers
 

db/migrate/20201214000000_change_mr_allow_maintainer_to_push_default.rb

+# frozen_string_literal: true
+
 class ChangeMrAllowMaintainerToPushDefault < ActiveRecord::Migration[6.0]
   include Gitlab::Database::MigrationHelpers
 

db/optional_migrations/composite_primary_keys.rb

+# frozen_string_literal: true
+
 # This migration adds a primary key constraint to tables
 # that only have a composite unique key.
 #

db/post_migrate/20190214112022_schedule_sync_issuables_state_id.rb

+# frozen_string_literal: true
+
 class ScheduleSyncIssuablesStateId < ActiveRecord::Migration[5.0]
   # This migration schedules the sync of state_id for issues and merge requests
   # which are converting the state column from string to integer.

db/post_migrate/20201030121314_schedule_update_existing_users_that_require_two_factor_auth.rb

+# frozen_string_literal: true
+
 # # frozen_string_literal: true
 
 class ScheduleUpdateExistingUsersThatRequireTwoFactorAuth < ActiveRecord::Migration[6.0]

ee/db/fixtures/development/20_burndown.rb

+# frozen_string_literal: true
+
 require './spec/support/sidekiq_middleware'
 require './spec/support/helpers/test_env'
 

ee/db/fixtures/development/20_vulnerabilities.rb

+# frozen_string_literal: true
+
 require './spec/support/sidekiq_middleware'
 
 class Gitlab::Seeder::Vulnerabilities

ee/db/fixtures/development/22_epics.rb

+# frozen_string_literal: true
+
 Gitlab::Seeder.quiet do
   Group.all.each do |group|
     5.times do

ee/db/geo/migrate/20170206203234_create_project_registry.rb

+# frozen_string_literal: true
+
 class CreateProjectRegistry < ActiveRecord::Migration[4.2]
   def change
     create_table :project_registry do |t|

ee/db/geo/migrate/20170223033541_create_file_registry.rb

+# frozen_string_literal: true
+
 class CreateFileRegistry < ActiveRecord::Migration[4.2]
   # rubocop:disable Migration/PreventStrings
   def change

ee/db/geo/migrate/20170302005747_add_index_to_project_id_on_project_registry.rb

+# frozen_string_literal: true
+
 class AddIndexToProjectIdOnProjectRegistry < ActiveRecord::Migration[4.2]
   include Gitlab::Database::MigrationHelpers
 

ee/db/geo/migrate/20170526214010_convert_file_bytes_to_int64.rb

+# frozen_string_literal: true
+
 class ConvertFileBytesToInt64 < ActiveRecord::Migration[4.2]
   def change
     change_column :file_registry, :bytes, :integer, limit: 8

ee/db/geo/migrate/20170605154253_create_event_log_state.rb

+# frozen_string_literal: true
+
 class CreateEventLogState < ActiveRecord::Migration[4.2]
   def change
     create_table :event_log_states, id: false do |t|

ee/db/geo/migrate/20170606155045_add_needs_resync_to_project_registry.rb

+# frozen_string_literal: true
+
 class AddNeedsResyncToProjectRegistry < ActiveRecord::Migration[4.2]
   include Gitlab::Database::MigrationHelpers
 

ee/db/geo/migrate/20170614201943_add_last_wiki_synced_at_to_project_registry.rb

+# frozen_string_literal: true
+
 class AddLastWikiSyncedAtToProjectRegistry < ActiveRecord::Migration[4.2]
   DOWNTIME = false
 

ee/db/geo/migrate/20170627195211_add_index_to_project_registry.rb

+# frozen_string_literal: true
+
 class AddIndexToProjectRegistry < ActiveRecord::Migration[4.2]
   include Gitlab::Database::MigrationHelpers
 

ee/db/geo/migrate/20170906174622_remove_duplicates_from_project_registry.rb

+# frozen_string_literal: true
+
 class RemoveDuplicatesFromProjectRegistry < ActiveRecord::Migration[4.2]
   include Gitlab::Database::MigrationHelpers
 

ee/db/geo/migrate/20170906182752_add_unique_index_to_project_id_on_project_registry.rb

+# frozen_string_literal: true
+
 class AddUniqueIndexToProjectIdOnProjectRegistry < ActiveRecord::Migration[4.2]
   include Gitlab::Database::MigrationHelpers
 

ee/db/geo/migrate/20171005045404_remove_file_uploads_from_registry.rb

+# frozen_string_literal: true
+
 class RemoveFileUploadsFromRegistry < ActiveRecord::Migration[4.2]
   # Previous to GitLab 10.1, GitLab would save attachments/avatars to the
   # wrong directory (/var/opt/gitlab/gitlab-rails/working). Destroy these

ee/db/geo/migrate/20171009162208_add_file_registry_success.rb

+# frozen_string_literal: true
+
 class AddFileRegistrySuccess < ActiveRecord::Migration[4.2]
   include Gitlab::Database::MigrationHelpers
 

ee/db/geo/migrate/20171009162209_add_file_registry_success_index.rb

+# frozen_string_literal: true
+
 class AddFileRegistrySuccessIndex < ActiveRecord::Migration[4.2]
   include Gitlab::Database::MigrationHelpers
 

ee/db/geo/migrate/20171101105200_add_retry_count_fields_to_registries.rb

+# frozen_string_literal: true
+
 class AddRetryCountFieldsToRegistries < ActiveRecord::Migration[4.2]
   include Gitlab::Database::MigrationHelpers
 

ee/db/geo/migrate/20171115143841_add_last_sync_failure_to_project_registry.rb

+# frozen_string_literal: true
+
 class AddLastSyncFailureToProjectRegistry < ActiveRecord::Migration[4.2]
   DOWNTIME = false
 

ee/db/geo/migrate/20180201154345_add_repository_verification_to_project_registry.rb

+# frozen_string_literal: true
+
 class AddRepositoryVerificationToProjectRegistry < ActiveRecord::Migration[4.2]
   include Gitlab::Database::MigrationHelpers
 

ee/db/geo/migrate/20180314175612_add_partial_index_to_project_registy_verification_failure_columns.rb

+# frozen_string_literal: true
+
 class AddPartialIndexToProjectRegistyVerificationFailureColumns < ActiveRecord::Migration[4.2]
   include Gitlab::Database::MigrationHelpers
 

ee/db/geo/migrate/20180315222132_add_partial_index_to_project_registy_checksum_columns.rb

+# frozen_string_literal: true
+
 class AddPartialIndexToProjectRegistyChecksumColumns < ActiveRecord::Migration[4.2]
   include Gitlab::Database::MigrationHelpers
 

ee/db/geo/migrate/20180321144947_change_repository_verification_checksum_to_sha.rb

+# frozen_string_literal: true
+
 class ChangeRepositoryVerificationChecksumToSha < ActiveRecord::Migration[4.2]
   include Gitlab::Database::MigrationHelpers
 

ee/db/geo/migrate/20180322062741_migrate_ci_job_artifacts_to_separate_registry.rb

+# frozen_string_literal: true
+
 class MigrateCiJobArtifactsToSeparateRegistry < ActiveRecord::Migration[4.2]
   def up
     tracking_db.create_table :job_artifact_registry, force: :cascade do |t|

ee/db/geo/migrate/20180323182105_add_missing_on_primary_to_file_registry.rb

+# frozen_string_literal: true
+
 class AddMissingOnPrimaryToFileRegistry < ActiveRecord::Migration[4.2]
   include Gitlab::Database::MigrationHelpers
 

ee/db/geo/migrate/20180327071612_add_partial_index_to_project_registy_checksum_sha_columns.rb

+# frozen_string_literal: true
+
 class AddPartialIndexToProjectRegistyChecksumShaColumns < ActiveRecord::Migration[4.2]
   include Gitlab::Database::MigrationHelpers
 

ee/db/geo/migrate/20180402170913_add_missing_on_primary_to_job_artifact_registry..rb

+# frozen_string_literal: true
+
 class AddMissingOnPrimaryToJobArtifactRegistry < ActiveRecord::Migration[4.2]
   include Gitlab::Database::MigrationHelpers
 

ee/db/geo/migrate/20180405074130_add_partial_index_project_repository_verification.rb

+# frozen_string_literal: true
+
 class AddPartialIndexProjectRepositoryVerification < ActiveRecord::Migration[4.2]
   include Gitlab::Database::MigrationHelpers
 

ee/db/geo/migrate/20180412213305_add_index_to_artifact_id_on_job_artifact_registry.rb

+# frozen_string_literal: true
+
 class AddIndexToArtifactIdOnJobArtifactRegistry < ActiveRecord::Migration[4.2]
   include Gitlab::Database::MigrationHelpers
 

ee/db/geo/migrate/20180419174834_add_checksum_mismatch_fields_to_project_registry.rb

+# frozen_string_literal: true
+
 class AddChecksumMismatchFieldsToProjectRegistry < ActiveRecord::Migration[4.2]
   include Gitlab::Database::MigrationHelpers
 

ee/db/geo/migrate/20180419192603_add_indexes_to_checksum_mismatch_fields_on_project_registry.rb

+# frozen_string_literal: true
+
 class AddIndexesToChecksumMismatchFieldsOnProjectRegistry < ActiveRecord::Migration[4.2]
   include Gitlab::Database::MigrationHelpers
 

ee/db/geo/migrate/20180427114641_add_repository_check_to_geo_project_registry.rb

+# frozen_string_literal: true
+
 # See http://doc.gitlab.com/ce/development/migration_style_guide.html
 # for more information on how to write migrations for GitLab.
 

ee/db/geo/migrate/20180510223634_set_resync_flag_for_retried_projects.rb

+# frozen_string_literal: true
+
 class SetResyncFlagForRetriedProjects < ActiveRecord::Migration[4.2]
   def up
     execute <<-SQL

ee/db/geo/migrate/20180613184349_add_resync_was_scheduled_at_to_project_registry.rb

+# frozen_string_literal: true
+
 class AddResyncWasScheduledAtToProjectRegistry < ActiveRecord::Migration[4.2]
   include Gitlab::Database::MigrationHelpers
 

ee/db/geo/post_migrate/20180320011914_remove_last_verification_failed_columns_from_geo_project_registry.rb

+# frozen_string_literal: true
+
 class RemoveLastVerificationFailedColumnsFromGeoProjectRegistry < ActiveRecord::Migration[4.2]
   DOWNTIME = false
 

ee/db/geo/post_migrate/20180320013929_remove_last_verification_at_columns_from_geo_project_registry.rb

+# frozen_string_literal: true
+
 class RemoveLastVerificationAtColumnsFromGeoProjectRegistry < ActiveRecord::Migration[4.2]
   DOWNTIME = false
 

ee/db/geo/post_migrate/20180326171626_remove_old_repository_verification_checksum_from_geo_project_registry.rb

+# frozen_string_literal: true
+
 class RemoveOldRepositoryVerificationChecksumFromGeoProjectRegistry < ActiveRecord::Migration[4.2]
   DOWNTIME = false
 

ee/db/geo/post_migrate/20180331055706_delete_job_artifacts_from_file_registry.rb

+# frozen_string_literal: true
+
 class DeleteJobArtifactsFromFileRegistry < ActiveRecord::Migration[4.2]
   def up
     execute("DELETE FROM file_registry WHERE file_type = 'job_artifact'")