Merge branch '220018-rspec-zero-monkey-patching-mode-5' into 'master'

[RUN AS-IF-FOSS] Enforce RSpec zero monkey patching mode

Closes #220018

See merge request gitlab-org/gitlab!35059

ee/spec/controllers/projects/feature_flag_issues_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Projects::FeatureFlagIssuesController do
+RSpec.describe Projects::FeatureFlagIssuesController do
   let_it_be(:project) { create(:project) }
   let_it_be(:developer) { create(:user) }
   let_it_be(:reporter) { create(:user) }

ee/spec/features/groups/iterations/iterations_list_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Iterations list', :js do
+RSpec.describe 'Iterations list', :js do
   let(:now) { Time.now }
   let_it_be(:group) { create(:group) }
   let_it_be(:user) { create(:user) }

ee/spec/features/merge_requests/user_resets_approvers_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Merge Requests > User resets approvers', :js do
+RSpec.describe 'Merge Requests > User resets approvers', :js do
   include FeatureApprovalHelper
 
   let(:project) { create(:project, :repository) }

ee/spec/features/projects/feature_flags/feature_flag_issues_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Feature flag issue links', :js do
+RSpec.describe 'Feature flag issue links', :js do
   include FeatureFlagHelpers
 
   let_it_be(:developer) { create(:user) }

ee/spec/graphql/mutations/pipelines/run_dast_scan_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Mutations::Pipelines::RunDastScan do
+RSpec.describe Mutations::Pipelines::RunDastScan do
   let(:group) { create(:group) }
   let(:project) { create(:project, group: group) }
   let(:user) { create(:user) }

ee/spec/graphql/resolvers/security_report_summary_resolver_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Resolvers::SecurityReportSummaryResolver do
+RSpec.describe Resolvers::SecurityReportSummaryResolver do
   include GraphqlHelpers
 
   let_it_be(:pipeline) { double('project') }

ee/spec/graphql/resolvers/vulnerabilities/issue_links_resolver_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Resolvers::Vulnerabilities::IssueLinksResolver do
+RSpec.describe Resolvers::Vulnerabilities::IssueLinksResolver do
   include GraphqlHelpers
 
   describe '#resolve' do

ee/spec/graphql/types/ci/pipeline_type_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe GitlabSchema.types['Pipeline'] do
+RSpec.describe GitlabSchema.types['Pipeline'] do
   it { expect(described_class.graphql_name).to eq('Pipeline') }
 
   it 'includes the ee specific fields' do

ee/spec/graphql/types/security_report_summary_section_type_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe GitlabSchema.types['SecurityReportSummarySection'] do
+RSpec.describe GitlabSchema.types['SecurityReportSummarySection'] do
   specify { expect(described_class.graphql_name).to eq('SecurityReportSummarySection') }
 
   it 'has specific fields' do

ee/spec/graphql/types/security_report_summary_type_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe GitlabSchema.types['SecurityReportSummary'] do
+RSpec.describe GitlabSchema.types['SecurityReportSummary'] do
   specify { expect(described_class.graphql_name).to eq('SecurityReportSummary') }
 
   it 'has specific fields' do

ee/spec/graphql/types/vulnerability/issue_link_type_enum_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe GitlabSchema.types['VulnerabilityIssueLinkType'] do
+RSpec.describe GitlabSchema.types['VulnerabilityIssueLinkType'] do
   let(:expected_values) { %w[RELATED CREATED] }
 
   subject { described_class.values.keys }

ee/spec/graphql/types/vulnerability/issue_link_type_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe GitlabSchema.types['VulnerabilityIssueLink'] do
+RSpec.describe GitlabSchema.types['VulnerabilityIssueLink'] do
   let(:expected_fields) { %i[id link_type issue] }
 
   subject { described_class }

ee/spec/graphql/types/vulnerability_location/secret_detection_type_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe GitlabSchema.types['VulnerabilityLocationSecretDetection'] do
+RSpec.describe GitlabSchema.types['VulnerabilityLocationSecretDetection'] do
   it do
     expect(described_class).to have_graphql_fields(
       :end_line,

ee/spec/helpers/admin/merge_request_approval_settings_helper_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Admin::MergeRequestApprovalSettingsHelper do
+RSpec.describe Admin::MergeRequestApprovalSettingsHelper do
   describe '#show_compliance_merge_request_approval_settings?' do
     using RSpec::Parameterized::TableSyntax
 

ee/spec/helpers/ee/application_settings_helper_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe EE::ApplicationSettingsHelper do
+RSpec.describe EE::ApplicationSettingsHelper do
   describe '.visible_attributes' do
     context 'personal access token parameters' do
       it { expect(visible_attributes).to include(*%i(max_personal_access_token_lifetime enforce_pat_expiration)) }

ee/spec/helpers/ee/subscribable_banner_helper_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe EE::SubscribableBannerHelper do
+RSpec.describe EE::SubscribableBannerHelper do
   describe '#gitlab_subscription_or_license' do
     subject { helper.gitlab_subscription_or_license }
 

ee/spec/lib/ee/gitlab/alerting/notification_payload_parser_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Gitlab::Alerting::NotificationPayloadParser do
+RSpec.describe Gitlab::Alerting::NotificationPayloadParser do
   let(:project) { build_stubbed(:project) }
 
   describe '.call' do

ee/spec/lib/ee/gitlab/background_migration/fix_ruby_object_in_audit_events_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Gitlab::BackgroundMigration::FixRubyObjectInAuditEvents, :migration, schema: 20200518114540 do
+RSpec.describe Gitlab::BackgroundMigration::FixRubyObjectInAuditEvents, :migration, schema: 20200518114540 do
   let(:audit_events) { table(:audit_events) }
 
   it 'cleans up ruby/object in details field', :aggregate_failures do

ee/spec/lib/ee/gitlab/background_migration/update_vulnerabilities_from_dismissal_feedback_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Gitlab::BackgroundMigration::UpdateVulnerabilitiesFromDismissalFeedback, :migration, schema: 20200519201128 do
+RSpec.describe Gitlab::BackgroundMigration::UpdateVulnerabilitiesFromDismissalFeedback, :migration, schema: 20200519201128 do
   let(:users) { table(:users) }
   let(:projects) { table(:projects) }
   let(:vulnerabilities) { table(:vulnerabilities) }

ee/spec/lib/ee/gitlab/issuable_metadata_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Gitlab::IssuableMetadata do
+RSpec.describe Gitlab::IssuableMetadata do
   let_it_be(:user) { create(:user) }
   let_it_be(:project1) { create(:project, :public, :repository, creator: user, namespace: user.namespace) }
   let_it_be(:project2) { create(:project, :public, :repository, creator: user, namespace: user.namespace) }

ee/spec/lib/gitlab/ci/config/entry/secret_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Gitlab::Ci::Config::Entry::Secret do
+RSpec.describe Gitlab::Ci::Config::Entry::Secret do
   let(:entry) { described_class.new(config) }
 
   describe 'validation' do

ee/spec/lib/gitlab/ci/config/entry/secrets_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Gitlab::Ci::Config::Entry::Secrets do
+RSpec.describe Gitlab::Ci::Config::Entry::Secrets do
   let(:entry) { described_class.new(config) }
 
   describe 'validation' do

ee/spec/lib/gitlab/ci/config/entry/vault/engine_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Gitlab::Ci::Config::Entry::Vault::Engine do
+RSpec.describe Gitlab::Ci::Config::Entry::Vault::Engine do
   let(:entry) { described_class.new(config) }
 
   describe 'validation' do

ee/spec/lib/gitlab/ci/config/entry/vault/secret_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Gitlab::Ci::Config::Entry::Vault::Secret do
+RSpec.describe Gitlab::Ci::Config::Entry::Vault::Secret do
   let(:entry) { described_class.new(config) }
 
   describe 'validation' do

ee/spec/lib/gitlab/geo/registry_batcher_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Gitlab::Geo::RegistryBatcher, :geo, :use_clean_rails_memory_store_caching do
+RSpec.describe Gitlab::Geo::RegistryBatcher, :geo, :use_clean_rails_memory_store_caching do
   describe '#next_range!' do
     let(:model_class) { LfsObject }
     let(:model_foreign_key) { registry_class::MODEL_FOREIGN_KEY }

ee/spec/lib/gitlab/usage_data_counters/ingress_modsecurity_counter_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Gitlab::UsageDataCounters::IngressModsecurityCounter, :clean_gitlab_redis_shared_state do
+RSpec.describe Gitlab::UsageDataCounters::IngressModsecurityCounter, :clean_gitlab_redis_shared_state do
   describe '.add' do
     it 'increases packets_processed and packets_anomalous counters and sets statistics_unavailable counter' do
       described_class.add(3, 10_200, 2_500)

ee/spec/lib/status_page/usage_data_counters/incident_counter_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe StatusPage::UsageDataCounters::IncidentCounter do
+RSpec.describe StatusPage::UsageDataCounters::IncidentCounter do
   it_behaves_like 'a redis usage counter', 'StatusPage::IncidentCounter', :publishes
   it_behaves_like 'a redis usage counter', 'StatusPage::IncidentCounter', :unpublishes
 

ee/spec/migrations/migrate_vulnerability_dismissal_feedback_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 require Rails.root.join('db', 'post_migrate', '20200519201128_migrate_vulnerability_dismissal_feedback.rb')
 
-describe MigrateVulnerabilityDismissalFeedback, :migration, :sidekiq do
+RSpec.describe MigrateVulnerabilityDismissalFeedback, :migration, :sidekiq do
   let(:users) { table(:users) }
   let(:namespaces) { table(:namespaces) }
   let(:projects) { table(:projects) }

ee/spec/migrations/schedule_fix_ruby_object_in_audit_events_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 require Rails.root.join('db', 'post_migrate', '20200518114540_schedule_fix_ruby_object_in_audit_events.rb')
 
-describe ScheduleFixRubyObjectInAuditEvents do
+RSpec.describe ScheduleFixRubyObjectInAuditEvents do
   let(:audit_events) { table(:audit_events) }
 
   it 'schedules background migrations' do

ee/spec/models/board_user_preference_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe BoardUserPreference do
+RSpec.describe BoardUserPreference do
   before do
     create(:board_user_preference)
   end

ee/spec/models/project_security_setting_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe ProjectSecuritySetting do
+RSpec.describe ProjectSecuritySetting do
   describe 'associations' do
     subject { create(:project_security_setting) }
 

ee/spec/presenters/packages/composer/packages_presenter_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe ::Packages::Composer::PackagesPresenter do
+RSpec.describe ::Packages::Composer::PackagesPresenter do
   using RSpec::Parameterized::TableSyntax
 
   let_it_be(:package_name) { 'sample-project' }

ee/spec/requests/api/commits_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-describe API::Commits do
+RSpec.describe API::Commits do
   let_it_be(:user) { create(:user) }
   let_it_be(:project) { create(:project, :repository, creator: user, path: "my.project") }
   let(:project_id) { project.id }

ee/spec/requests/api/graphql/mutations/pipelines/run_dast_scan_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Running a DAST Scan' do
+RSpec.describe 'Running a DAST Scan' do
   include GraphqlHelpers
 
   let(:project) { create(:project) }

ee/spec/requests/api/graphql/project/compliance_frameworks_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'getting a compliance frameworks list for a project' do
+RSpec.describe 'getting a compliance frameworks list for a project' do
   include GraphqlHelpers
 
   let_it_be(:project_member) { create(:project_member, :maintainer) }

ee/spec/requests/api/resource_weight_events_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe ::API::ResourceWeightEvents do
+RSpec.describe ::API::ResourceWeightEvents do
   let_it_be(:user) { create(:user) }
   let_it_be(:project, reload: true) { create(:project, :public, namespace: user.namespace) }
   let_it_be(:issue) { create(:issue, project: project, author: user) }

ee/spec/requests/api/wikis_spec.rb

@@ -12,7 +12,7 @@ require 'spec_helper'
 # - maintainer
 # because they are 3 edge cases of using wiki pages.
 
-describe API::Wikis do
+RSpec.describe API::Wikis do
   include WorkhorseHelpers
 
   let_it_be(:user) { create(:user) }

ee/spec/requests/projects/analytics/code_reviews_controller_spec.rb

@@ -51,7 +51,7 @@ RSpec.describe Projects::Analytics::CodeReviewsController, type: :request do
   end
 end
 
-describe Projects::Analytics::CodeReviewsController, type: :controller do
+RSpec.describe Projects::Analytics::CodeReviewsController, type: :controller do
   let(:user) { create :user }
   let(:project) { create(:project) }
 

ee/spec/serializers/ee/evidences/release_entity_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Evidences::ReleaseEntity do
+RSpec.describe Evidences::ReleaseEntity do
   let(:project) { create(:project, :repository) }
   let(:release) { build(:release, project: project) }
 

ee/spec/serializers/evidences/build_artifact_entity_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Evidences::BuildArtifactEntity do
+RSpec.describe Evidences::BuildArtifactEntity do
   include Gitlab::Routing
 
   let(:build) { create(:ci_build, :artifacts) }

ee/spec/serializers/evidences/evidence_entity_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Evidences::EvidenceEntity do
+RSpec.describe Evidences::EvidenceEntity do
   let(:project) { create(:project, :repository) }
   let(:release) { create(:release, project: project) }
   let(:evidence) { build(:evidence, release: release) }

ee/spec/services/ci/compare_license_scanning_reports_service_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Ci::CompareLicenseScanningReportsService do
+RSpec.describe Ci::CompareLicenseScanningReportsService do
   let_it_be(:project) { create(:project, :repository) }
   let(:service) { described_class.new(project, nil) }
 

ee/spec/services/ci/compare_security_reports_service_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Ci::CompareSecurityReportsService do
+RSpec.describe Ci::CompareSecurityReportsService do
   let_it_be(:project) { create(:project, :repository) }
   let(:current_user) { build(:user, :admin) }
 

ee/spec/services/ci/pipeline_bridge_status_service_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Ci::PipelineBridgeStatusService do
+RSpec.describe Ci::PipelineBridgeStatusService do
   let_it_be(:project) { create(:project) }
   let(:user) { build(:user) }
   let(:pipeline) { build(:ci_pipeline, project: project) }

ee/spec/services/ci/run_dast_scan_service_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Ci::RunDastScanService do
+RSpec.describe Ci::RunDastScanService do
   let(:project) { create(:project) }
   let(:branch) { SecureRandom.hex }
   let(:target_url) { FFaker::Internet.uri(:http) }

ee/spec/services/ee/allowed_email_domains/update_service_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe EE::AllowedEmailDomains::UpdateService do
+RSpec.describe EE::AllowedEmailDomains::UpdateService do
   let(:group) { create(:group) }
   let(:user) { create(:user) }
 

ee/spec/services/ee/integrations/test/project_service_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe ::Integrations::Test::ProjectService do
+RSpec.describe ::Integrations::Test::ProjectService do
   let(:user) { double('user') }
 
   describe '#execute' do

ee/spec/services/ee/releases/create_evidence_service_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Releases::CreateEvidenceService do
+RSpec.describe Releases::CreateEvidenceService do
   include Gitlab::Routing
 
   let(:project) { create(:project) }

ee/spec/services/ee/security/ingress_modsecurity_usage_service_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe EE::Security::IngressModsecurityUsageService do
+RSpec.describe EE::Security::IngressModsecurityUsageService do
   describe '#execute' do
     let(:environment) { create(:environment) }
     let(:ingress_mode) { :modsecurity_blocking }

ee/spec/services/elastic/process_initial_bookkeeping_service_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Elastic::ProcessInitialBookkeepingService do
+RSpec.describe Elastic::ProcessInitialBookkeepingService do
   let(:project) { create(:project) }
   let(:issue) { create(:issue) }
 

ee/spec/services/geo/replication_toggle_request_service_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Geo::ReplicationToggleRequestService, :geo do
+RSpec.describe Geo::ReplicationToggleRequestService, :geo do
   include ::EE::GeoHelpers
   include ApiHelpers
 

ee/spec/services/packages/composer/composer_json_service_spec.rb

 # frozen_string_literal: true
 require 'spec_helper'
 
-describe Packages::Composer::ComposerJsonService do
+RSpec.describe Packages::Composer::ComposerJsonService do
   describe '#execute' do
     let(:branch) { project.repository.find_branch('master') }
     let(:target) { branch.target }

ee/spec/services/packages/composer/create_package_service_spec.rb

 # frozen_string_literal: true
 require 'spec_helper'
 
-describe Packages::Composer::CreatePackageService do
+RSpec.describe Packages::Composer::CreatePackageService do
   include EE::PackagesManagerApiSpecHelpers
 
   let_it_be(:package_name) { 'composer-package-name' }

ee/spec/services/packages/composer/version_parser_service_spec.rb

 # frozen_string_literal: true
 require 'spec_helper'
 
-describe Packages::Composer::VersionParserService do
+RSpec.describe Packages::Composer::VersionParserService do
   let_it_be(:params) { {} }
 
   describe '#execute' do

ee/spec/services/projects/alerting/notify_service_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Projects::Alerting::NotifyService do
+RSpec.describe Projects::Alerting::NotifyService do
   let_it_be(:project, refind: true) { create(:project) }
 
   describe '#execute' do

ee/spec/services/requirements_management/process_test_reports_service_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe RequirementsManagement::ProcessTestReportsService do
+RSpec.describe RequirementsManagement::ProcessTestReportsService do
   let_it_be(:project) { create(:project) }
   let_it_be(:user) { create(:user) }
   let_it_be(:build) { create(:ee_ci_build, :requirements_report, project: project, user: user) }

ee/spec/services/security/configuration/save_auto_fix_service_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Security::Configuration::SaveAutoFixService do
+RSpec.describe Security::Configuration::SaveAutoFixService do
   describe '#execute' do
     let_it_be(:project) { create(:project) }
 

ee/spec/services/security/report_summary_service_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Security::ReportSummaryService, '#execute' do
+RSpec.describe Security::ReportSummaryService, '#execute' do
   let_it_be(:project) { create(:project, :repository) }
   let_it_be(:pipeline) { create(:ci_pipeline, :success, project: project) }
 

ee/spec/services/security/scanned_resources_counting_service_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Security::ScannedResourcesCountingService, '#execute' do
+RSpec.describe Security::ScannedResourcesCountingService, '#execute' do
   before do
     stub_licensed_features(sast: true, dependency_scanning: true, container_scanning: true, dast: true)
   end

ee/spec/services/security/vulnerability_counting_service_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Security::VulnerabilityCountingService, '#execute' do
+RSpec.describe Security::VulnerabilityCountingService, '#execute' do
   before do
     stub_licensed_features(sast: true, dependency_scanning: true, container_scanning: true, dast: true)
   end

ee/spec/support/shared_examples/models/geo_framework_registry_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'a Geo framework registry' do
+RSpec.shared_examples 'a Geo framework registry' do
   let(:registry_class_factory) { described_class.underscore.tr('/', '_').to_sym }
 
   context 'finders' do

ee/spec/views/layouts/header/_new_dropdown.haml_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'layouts/header/_new_dropdown' do
+RSpec.describe 'layouts/header/_new_dropdown' do
   let(:user) { create(:user) }
 
   context 'group-specific links' do

ee/spec/workers/geo/registry_sync_worker_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Geo::RegistrySyncWorker, :geo, :use_sql_query_cache_for_tracking_db do
+RSpec.describe Geo::RegistrySyncWorker, :geo, :use_sql_query_cache_for_tracking_db do
   include ::EE::GeoHelpers
   include ExclusiveLeaseHelpers
 

ee/spec/workers/ingress_modsecurity_counter_metrics_worker_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe IngressModsecurityCounterMetricsWorker, :clean_gitlab_redis_shared_state do
+RSpec.describe IngressModsecurityCounterMetricsWorker, :clean_gitlab_redis_shared_state do
   include ExclusiveLeaseHelpers
 
   subject(:worker) { described_class.new }

ee/spec/workers/requirements_management/process_requirements_reports_worker_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe RequirementsManagement::ProcessRequirementsReportsWorker do
+RSpec.describe RequirementsManagement::ProcessRequirementsReportsWorker do
   describe '#perform' do
     context 'build exists' do
       let(:build) { create(:ci_build) }

spec/controllers/groups/imports_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Groups::ImportsController do
+RSpec.describe Groups::ImportsController do
   describe 'GET #show' do
     let_it_be(:user) { create(:user) }
     let_it_be(:group) { create(:group, :private) }

spec/controllers/projects/pipelines/tests_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Projects::Pipelines::TestsController do
+RSpec.describe Projects::Pipelines::TestsController do
   let(:user) { create(:user) }
   let(:project) { create(:project, :public, :repository) }
   let(:pipeline) { create(:ci_pipeline, project: project) }

spec/controllers/registrations/experience_levels_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Registrations::ExperienceLevelsController do
+RSpec.describe Registrations::ExperienceLevelsController do
   let_it_be(:namespace) { create(:group, path: 'group-path' ) }
   let_it_be(:user) { create(:user) }
 

spec/features/groups/import_export/import_file_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Import/Export - Group Import', :js do
+RSpec.describe 'Import/Export - Group Import', :js do
   let_it_be(:user) { create(:user) }
   let_it_be(:import_path) { "#{Dir.tmpdir}/group_import_spec" }
 

spec/features/projects/activity/user_sees_design_activity_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Projects > Activity > User sees design Activity', :js do
+RSpec.describe 'Projects > Activity > User sees design Activity', :js do
   include DesignManagementTestHelpers
 
   let_it_be(:uploader) { create(:user) }

spec/graphql/mutations/alert_management/alerts/set_assignees_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Mutations::AlertManagement::Alerts::SetAssignees do
+RSpec.describe Mutations::AlertManagement::Alerts::SetAssignees do
   let_it_be(:starting_assignee) { create(:user) }
   let_it_be(:unassigned_user) { create(:user) }
   let_it_be(:alert) { create(:alert_management_alert, assignees: [starting_assignee]) }

spec/graphql/mutations/container_expiration_policies/update_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Mutations::ContainerExpirationPolicies::Update do
+RSpec.describe Mutations::ContainerExpirationPolicies::Update do
   using RSpec::Parameterized::TableSyntax
 
   let_it_be(:project, reload: true) { create(:project) }

spec/graphql/resolvers/concerns/looks_ahead_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe LooksAhead do
+RSpec.describe LooksAhead do
   include GraphqlHelpers
 
   let_it_be(:the_user) { create(:user) }

spec/graphql/resolvers/project_members_resolver_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Resolvers::ProjectMembersResolver do
+RSpec.describe Resolvers::ProjectMembersResolver do
   include GraphqlHelpers
 
   context "with a group" do

spec/graphql/resolvers/project_pipeline_resolver_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Resolvers::ProjectPipelineResolver do
+RSpec.describe Resolvers::ProjectPipelineResolver do
   include GraphqlHelpers
 
   let_it_be(:project) { create(:project) }

spec/graphql/resolvers/users_resolver_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Resolvers::UsersResolver do
+RSpec.describe Resolvers::UsersResolver do
   include GraphqlHelpers
 
   let_it_be(:user1) { create(:user) }

spec/graphql/types/access_level_enum_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe GitlabSchema.types['AccessLevelEnum'] do
+RSpec.describe GitlabSchema.types['AccessLevelEnum'] do
   specify { expect(described_class.graphql_name).to eq('AccessLevelEnum') }
 
   it 'exposes all the existing access levels' do

spec/graphql/types/access_level_type_spec.rb

 # frozen_string_literal: true
 require 'spec_helper'
 
-describe GitlabSchema.types['AccessLevel'] do
+RSpec.describe GitlabSchema.types['AccessLevel'] do
   specify { expect(described_class.graphql_name).to eq('AccessLevel') }
   specify { expect(described_class).to require_graphql_authorizations(nil) }
 

spec/graphql/types/evidence_type_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe GitlabSchema.types['ReleaseEvidence'] do
+RSpec.describe GitlabSchema.types['ReleaseEvidence'] do
   it { expect(described_class).to require_graphql_authorizations(:download_code) }
 
   it 'has the expected fields' do

spec/graphql/types/group_member_type_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Types::GroupMemberType do
+RSpec.describe Types::GroupMemberType do
   specify { expect(described_class).to expose_permissions_using(Types::PermissionTypes::Group) }
 
   specify { expect(described_class.graphql_name).to eq('GroupMember') }

spec/graphql/types/milestone_stats_type_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe GitlabSchema.types['MilestoneStats'] do
+RSpec.describe GitlabSchema.types['MilestoneStats'] do
   it { expect(described_class).to require_graphql_authorizations(:read_milestone) }
 
   it 'has the expected fields' do

spec/graphql/types/project_member_type_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Types::ProjectMemberType do
+RSpec.describe Types::ProjectMemberType do
   specify { expect(described_class).to expose_permissions_using(Types::PermissionTypes::Project) }
 
   specify { expect(described_class.graphql_name).to eq('ProjectMember') }

spec/graphql/types/release_asset_link_type_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe GitlabSchema.types['ReleaseAssetLink'] do
+RSpec.describe GitlabSchema.types['ReleaseAssetLink'] do
   it { expect(described_class).to require_graphql_authorizations(:read_release) }
 
   it 'has the expected fields' do

spec/graphql/types/snippets/file_input_action_enum_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Types::Snippets::FileInputActionEnum do
+RSpec.describe Types::Snippets::FileInputActionEnum do
   specify { expect(described_class.graphql_name).to eq('SnippetFileInputActionEnum') }
 
   it 'exposes all file input action types' do

spec/graphql/types/snippets/file_input_type_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Types::Snippets::FileInputType do
+RSpec.describe Types::Snippets::FileInputType do
   specify { expect(described_class.graphql_name).to eq('SnippetFileInputType') }
 
   it 'has the correct arguments' do

spec/graphql/types/untrusted_regexp_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe GitlabSchema.types['UntrustedRegexp'] do
+RSpec.describe GitlabSchema.types['UntrustedRegexp'] do
   using RSpec::Parameterized::TableSyntax
 
   specify { expect(described_class.graphql_name).to eq('UntrustedRegexp') }

spec/helpers/analytics/unique_visits_helper_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-describe Analytics::UniqueVisitsHelper do
+RSpec.describe Analytics::UniqueVisitsHelper do
   include Devise::Test::ControllerHelpers
 
   describe '#track_visit' do

spec/helpers/subscribable_banner_helper_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe SubscribableBannerHelper do
+RSpec.describe SubscribableBannerHelper do
   describe '#display_subscription_banner!' do
     it 'is over-written in EE' do
       expect { helper.display_subscription_banner! }.not_to raise_error

spec/lib/api/entities/deploy_key_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe API::Entities::DeployKey do
+RSpec.describe API::Entities::DeployKey do
   describe '#as_json' do
     subject { entity.as_json }
 

spec/lib/api/entities/deploy_keys_project_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe API::Entities::DeployKeysProject do
+RSpec.describe API::Entities::DeployKeysProject do
   describe '#as_json' do
     subject { entity.as_json }
 

spec/lib/api/entities/ssh_key_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe API::Entities::SSHKey do
+RSpec.describe API::Entities::SSHKey do
   describe '#as_json' do
     subject { entity.as_json }
 

spec/lib/api/validations/validators/untrusted_regexp_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe API::Validations::Validators::UntrustedRegexp do
+RSpec.describe API::Validations::Validators::UntrustedRegexp do
   include ApiValidatorsHelpers
 
   subject do

spec/lib/banzai/filter/jira_import/adf_to_commonmark_filter_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Banzai::Filter::JiraImport::AdfToCommonmarkFilter do
+RSpec.describe Banzai::Filter::JiraImport::AdfToCommonmarkFilter do
   include FilterSpecHelper
 
   let_it_be(:fixtures_path) { 'lib/kramdown/atlassian_document_format' }

spec/lib/banzai/pipeline/jira_import/adf_commonmark_pipeline_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Banzai::Pipeline::JiraImport::AdfCommonmarkPipeline do
+RSpec.describe Banzai::Pipeline::JiraImport::AdfCommonmarkPipeline do
   let_it_be(:fixtures_path) { 'lib/kramdown/atlassian_document_format' }
 
   it 'converts text in Atlassian Document Format ' do

spec/lib/extracts_ref_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe ExtractsRef do
+RSpec.describe ExtractsRef do
   include described_class
   include RepoHelpers
 

spec/lib/gitlab/analytics/unique_visits_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Gitlab::Analytics::UniqueVisits, :clean_gitlab_redis_shared_state do
+RSpec.describe Gitlab::Analytics::UniqueVisits, :clean_gitlab_redis_shared_state do
   let(:unique_visits) { Gitlab::Analytics::UniqueVisits.new }
   let(:target1_id) { 'g_analytics_contribution' }
   let(:target2_id) { 'g_analytics_insights' }

spec/lib/gitlab/ci/build/releaser_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Gitlab::Ci::Build::Releaser do
+RSpec.describe Gitlab::Ci::Build::Releaser do
   subject { described_class.new(config: config[:release]).script }
 
   describe '#script' do

spec/lib/gitlab/ci/reports/test_report_summary_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Gitlab::Ci::Reports::TestReportSummary do
+RSpec.describe Gitlab::Ci::Reports::TestReportSummary do
   let(:build_report_result_1) { build(:ci_build_report_result) }
   let(:build_report_result_2) { build(:ci_build_report_result, :with_junit_success) }
   let(:test_report_summary) { described_class.new([build_report_result_1, build_report_result_2]) }

spec/lib/gitlab/ci/reports/test_suite_summary_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Gitlab::Ci::Reports::TestSuiteSummary do
+RSpec.describe Gitlab::Ci::Reports::TestSuiteSummary do
   let(:build_report_result_1) { build(:ci_build_report_result) }
   let(:build_report_result_2) { build(:ci_build_report_result, :with_junit_success) }
   let(:test_suite_summary) { described_class.new([build_report_result_1, build_report_result_2]) }

spec/lib/gitlab/data_builder/alert_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Gitlab::DataBuilder::Alert do
+RSpec.describe Gitlab::DataBuilder::Alert do
   let_it_be(:project) { create(:project) }
   let_it_be(:alert) { create(:alert_management_alert, project: project) }