UI consistency fixes for font weight and color

app/assets/javascripts/boards/components/board_form.vue

@@ -56,12 +56,6 @@
         </p>
         <div v-if="!collapseScope || expanded">
           <div class="list-item">
-            <div
-              v-if="board.milestone"
-              slot="currentValue"
-            >
-              {{ board.milestone.title }}
-            </div>
             <board-milestone-select
               :board="board"
               :milestone-path="milestonePath"

app/assets/javascripts/boards/components/labels_select.vue

@@ -65,7 +65,7 @@ export default {
     <div class="value issuable-show-labels">
       <span
         v-if="board.labels.length === 0"
-        class="no-value"
+        class="text-secondary"
       >
         Any label
       </span>

app/assets/javascripts/boards/components/user_select.vue

@@ -115,7 +115,10 @@ export default {
           </div>
         </div>
       </div>
-      <div v-else>
+      <div
+        v-else
+        class="text-secondary"
+      >
         {{ anyUserText }}
       </div>
     </div>

app/assets/javascripts/boards/components/weight_select.vue

@@ -44,7 +44,7 @@ export default {
   computed: {
     valueClass() {
       if (this.value === 'Any Weight') {
-        return 'placeholder';
+        return 'text-secondary';
       }
       return 'bold';
     },

app/assets/javascripts/vue_shared/components/popup_dialog.vue

@@ -52,12 +52,10 @@ export default {
     class="modal popup-dialog"
     role="dialog"
     tabindex="-1"
-    @click="close"
   >
     <div
       class="modal-dialog modal-md"
       role="document"
-      @click.stop
     >
       <div class="modal-content">
         <div class="modal-header">
@@ -103,6 +101,9 @@ export default {
       </div>
     </div>
   </div>
-  <div class="modal-backdrop fade in" />
+  <div
+    class="modal-backdrop fade in"
+    @click="close"
+  />
 </div>
 </template>

app/assets/stylesheets/framework/common.scss

@@ -4,6 +4,9 @@
 .cred { color: $common-red; }
 .cgreen { color: $common-green; }
 .cdark { color: $common-gray-dark; }
+.text-secondary {
+  color: $gl-text-color-secondary;
+}
 
 /** COMMON CLASSES **/
 .prepend-top-0 { margin-top: 0; }

app/assets/stylesheets/framework/modal.scss

@@ -46,13 +46,6 @@ body.modal-open {
   padding: $gl-padding;
 }
 
-.modal-header,
-.modal-footer {
-  padding: $gl-padding;
-  background-color: $gray-light;
-  border-top: 1px solid $border-color;
-}
-
 .modal.popup-dialog {
   display: block;