Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
9cdde576
Commit
9cdde576
authored
Feb 03, 2018
by
Stan Hu
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Backport /api/v4/groups N+1 query check from EE
parent
5aea8dc1
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
15 additions
and
0 deletions
+15
-0
spec/requests/api/groups_spec.rb
spec/requests/api/groups_spec.rb
+15
-0
No files found.
spec/requests/api/groups_spec.rb
View file @
9cdde576
...
@@ -30,6 +30,21 @@ describe API::Groups do
...
@@ -30,6 +30,21 @@ describe API::Groups do
expect
(
json_response
)
expect
(
json_response
)
.
to
satisfy_one
{
|
group
|
group
[
'name'
]
==
group1
.
name
}
.
to
satisfy_one
{
|
group
|
group
[
'name'
]
==
group1
.
name
}
end
end
it
'avoids N+1 queries'
do
# Establish baseline
get
api
(
"/groups"
,
admin
)
control
=
ActiveRecord
::
QueryRecorder
.
new
do
get
api
(
"/groups"
,
admin
)
end
create
(
:group
)
expect
do
get
api
(
"/groups"
,
admin
)
end
.
not_to
exceed_query_limit
(
control
)
end
end
end
context
"when authenticated as user"
do
context
"when authenticated as user"
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment