Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
9ce69872
Commit
9ce69872
authored
Dec 22, 2017
by
Grzegorz Bizon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Move QA elements DSL as it belongs to different class
parent
73b9cbf6
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
20 additions
and
22 deletions
+20
-22
qa/qa/page/base.rb
qa/qa/page/base.rb
+2
-2
qa/qa/page/element.rb
qa/qa/page/element.rb
+0
-20
qa/qa/page/view.rb
qa/qa/page/view.rb
+18
-0
No files found.
qa/qa/page/base.rb
View file @
9ce69872
...
@@ -56,8 +56,8 @@ module QA
...
@@ -56,8 +56,8 @@ module QA
end
end
def
view
(
path
,
&
block
)
def
view
(
path
,
&
block
)
Page
::
Element
.
evaluate
(
&
block
).
tap
do
|
elements
|
Page
::
View
.
evaluate
(
&
block
).
tap
do
|
view
|
@views
.
push
(
Page
::
View
.
new
(
path
,
elements
))
@views
.
push
(
Page
::
View
.
new
(
path
,
view
.
elements
))
end
end
end
end
end
end
...
...
qa/qa/page/element.rb
View file @
9ce69872
...
@@ -7,26 +7,6 @@ module QA
...
@@ -7,26 +7,6 @@ module QA
@name
=
name
@name
=
name
@pattern
=
pattern
@pattern
=
pattern
end
end
def
self
.
evaluate
(
&
block
)
Page
::
Element
::
DSL
.
new
.
tap
do
|
evaluator
|
evaluator
.
instance_exec
(
&
block
)
return
evaluator
.
elements
end
end
class
DSL
attr_reader
:elements
def
initialize
@elements
=
[]
end
def
element
(
name
,
pattern
)
@elements
.
push
(
Page
::
Element
.
new
(
name
,
pattern
))
end
end
end
end
end
end
end
end
qa/qa/page/view.rb
View file @
9ce69872
...
@@ -7,6 +7,24 @@ module QA
...
@@ -7,6 +7,24 @@ module QA
@path
=
path
@path
=
path
@elements
=
elements
@elements
=
elements
end
end
def
self
.
evaluate
(
&
block
)
Page
::
View
::
DSL
.
new
.
tap
do
|
evaluator
|
evaluator
.
instance_exec
(
&
block
)
end
end
class
DSL
attr_reader
:elements
def
initialize
@elements
=
[]
end
def
element
(
name
,
pattern
)
@elements
.
push
(
Page
::
Element
.
new
(
name
,
pattern
))
end
end
end
end
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment