Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
9d784a42
Commit
9d784a42
authored
Sep 30, 2019
by
Ryan Cobb
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Reduce cardinality of http_request_duration initialization
parent
ca4a2642
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
15 additions
and
6 deletions
+15
-6
lib/gitlab/metrics/requests_rack_middleware.rb
lib/gitlab/metrics/requests_rack_middleware.rb
+13
-4
spec/lib/gitlab/metrics/requests_rack_middleware_spec.rb
spec/lib/gitlab/metrics/requests_rack_middleware_spec.rb
+2
-2
No files found.
lib/gitlab/metrics/requests_rack_middleware.rb
View file @
9d784a42
...
...
@@ -3,8 +3,17 @@
module
Gitlab
module
Metrics
class
RequestsRackMiddleware
HTTP_METHODS
=
%w(delete get head options patch post put trace)
.
freeze
STATUSES
=
%w(200 301 304 400 401 403 404 500)
.
freeze
HTTP_METHODS
=
{
"delete"
=>
%w(200 202 204 303 400 401 403 404 410 422 500 503)
,
"get"
=>
%w(200 204 301 302 303 304 307 400 401 403 404 410 412 422 429 500 503)
,
"head"
=>
%w(200 204 301 302 303 304 400 401 403 404 410 429 500 503)
,
"options"
=>
%w(200 404)
,
"patch"
=>
%w(200 202 204 400 403 404 409 416 422 500)
,
"post"
=>
%w(200 201 202 204 301 302 303 304 400 401 403 404 406 409 410 412 413 415 422 429 500 503)
,
"propfind"
=>
%w(404)
,
"put"
=>
%w(200 202 204 400 401 403 404 405 406 409 410 415 422 500)
,
"report"
=>
%w(404)
}.
freeze
def
initialize
(
app
)
@app
=
app
...
...
@@ -24,8 +33,8 @@ module Gitlab
end
def
self
.
initialize_http_request_duration_seconds
HTTP_METHODS
.
each
do
|
method
|
STATUSES
.
each
do
|
status
|
HTTP_METHODS
.
each
do
|
method
,
statuses
|
statuses
.
each
do
|
status
|
http_request_duration_seconds
.
get
({
method:
method
,
status:
status
})
end
end
...
...
spec/lib/gitlab/metrics/requests_rack_middleware_spec.rb
View file @
9d784a42
...
...
@@ -67,8 +67,8 @@ describe Gitlab::Metrics::RequestsRackMiddleware do
describe
'.initialize_http_request_duration_seconds'
do
it
"sets labels"
do
expected_labels
=
[]
described_class
::
HTTP_METHODS
.
each
do
|
method
|
described_class
::
STATUSES
.
each
do
|
status
|
described_class
::
HTTP_METHODS
.
each
do
|
method
,
statuses
|
statuses
.
each
do
|
status
|
expected_labels
<<
{
method:
method
,
status:
status
}
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment