Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
9e754ee5
Commit
9e754ee5
authored
Feb 21, 2022
by
Pedro Pombeiro
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Increase text limit of maintainer_note field
Changelog: changed
parent
d2f1a542
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
18 additions
and
3 deletions
+18
-3
app/models/ci/runner.rb
app/models/ci/runner.rb
+1
-1
db/migrate/20220221102333_change_maintenance_note_limit_in_ci_runner.rb db/migrate/20220221102333_change_maintainer_note_limit_in_ci_runner.rb
...220221102333_change_maintainer_note_limit_in_ci_runner.rb
+14
-0
db/schema_migrations/20220221102333
db/schema_migrations/20220221102333
+1
-0
db/structure.sql
db/structure.sql
+1
-1
doc/api/runners.md
doc/api/runners.md
+1
-1
No files found.
app/models/ci/runner.rb
View file @
9e754ee5
...
...
@@ -200,7 +200,7 @@ module Ci
validates
:config
,
json_schema:
{
filename:
'ci_runner_config'
}
validates
:maintenance_note
,
length:
{
maximum:
255
}
validates
:maintenance_note
,
length:
{
maximum:
1024
}
alias_attribute
:maintenance_note
,
:maintainer_note
...
...
db/migrate/20220221102333_change_maintenance_note_limit_in_ci_runner.rb db/migrate/20220221102333_change_maintainer_note_limit_in_ci_runner.rb
0 → 100644
View file @
9e754ee5
# frozen_string_literal: true
class
ChangeMaintainerNoteLimitInCiRunner
<
Gitlab
::
Database
::
Migration
[
1.0
]
disable_ddl_transaction!
def
up
add_text_limit
:ci_runners
,
:maintainer_note
,
1024
,
constraint_name:
check_constraint_name
(
:ci_runners
,
:maintainer_note
,
'max_length_1MB'
)
remove_text_limit
:ci_runners
,
:maintainer_note
,
constraint_name:
check_constraint_name
(
:ci_runners
,
:maintainer_note
,
'max_length'
)
end
def
down
# no-op: Danger of failing if there are records with length(maintainer_note) > 255
end
end
db/schema_migrations/20220221102333
0 → 100644
View file @
9e754ee5
7aa2cf28363e914ad83c61d45321f701a68111122c75abeb54430c4035d56677
\ No newline at end of file
db/structure.sql
View file @
9e754ee5
...
...
@@ -12376,7 +12376,7 @@ CREATE TABLE ci_runners (
executor_type smallint,
maintainer_note text,
token_expires_at timestamp with time zone,
CONSTRAINT check_
56f5ea8804 CHECK ((char_length(maintainer_note) <= 255
))
CONSTRAINT check_
ce275cee06 CHECK ((char_length(maintainer_note) <= 1024
))
);
CREATE SEQUENCE ci_runners_id_seq
doc/api/runners.md
View file @
9e754ee5
...
...
@@ -660,7 +660,7 @@ POST /runners
|
`access_level`
| string | no | The access_level of the runner;
`not_protected`
or
`ref_protected`
|
|
`maximum_timeout`
| integer | no | Maximum timeout set when this runner handles the job |
|
`maintainer_note`
| string | no |
[
Deprecated
](
https://gitlab.com/gitlab-org/gitlab/-/issues/350730
)
, see
`maintenance_note`
|
|
`maintenance_note`
| string | no | Free-form maintenance notes for the runner (
255 characters)
|
|
`maintenance_note`
| string | no | Free-form maintenance notes for the runner (
1024 characters)
|
```
shell
curl
--request
POST
"https://gitlab.example.com/api/v4/runners"
\
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment