Merge branch '51712-no-promise-without-done-fail-ee' into 'master'

2. enable jasmine/no-promise-without-done-fail

See merge request gitlab-org/gitlab-ee!7872

ee/spec/javascripts/.eslintrc.yml

@@ -38,5 +38,4 @@ rules:
       - ee/spec/**/*.js
   # Temporarily disabled to facilitate an upgrade to eslint-plugin-jasmine
   jasmine/new-line-before-expect: off
-  jasmine/no-promise-without-done-fail: off
   jasmine/prefer-toHaveBeenCalledWith: off

ee/spec/javascripts/license_management/license_management_spec.js

@@ -44,7 +44,7 @@ describe('LicenseManagement', () => {
         const buttonEl = vm.$el.querySelector('.js-open-form');
         expect(buttonEl).toBeNull();
         done();
-      });
+      }).catch(done.fail);
     });
 
     it('should render the button if the form is closed', done => {
@@ -56,7 +56,7 @@ describe('LicenseManagement', () => {
         const buttonEl = vm.$el.querySelector('.js-open-form');
         expect(buttonEl).not.toBeNull();
         done();
-      });
+      }).catch(done.fail);
     });
 
     it('clicking the Add a license button opens the form', () => {
@@ -75,7 +75,7 @@ describe('LicenseManagement', () => {
     return Vue.nextTick().then(() => {
       expect(vm.$el.querySelector('.loading-container')).not.toBeNull();
       done();
-    });
+    }).catch(done.fail);
   });
 
   it('should render callout if no licenses are managed', done => {
@@ -86,7 +86,7 @@ describe('LicenseManagement', () => {
       expect(callout).not.toBeNull();
       expect(trimText(callout.innerText)).toBe(vm.$options.emptyMessage);
       done();
-    });
+    }).catch(done.fail);
   });
 
   it('should render delete confirmation modal', done => {
@@ -95,7 +95,7 @@ describe('LicenseManagement', () => {
     return Vue.nextTick().then(() => {
       expect(vm.$el.querySelector('#modal-license-delete-confirmation')).not.toBeNull();
       done();
-    });
+    }).catch(done.fail);
   });
 
   it('should render list of managed licenses', done => {
@@ -106,7 +106,7 @@ describe('LicenseManagement', () => {
       expect(vm.$el.querySelector('.list-group .list-group-item')).not.toBeNull();
       expect(vm.$el.querySelectorAll('.list-group .list-group-item').length).toBe(2);
       done();
-    });
+    }).catch(done.fail);
   });
 
   it('should set api settings after mount and init API calls', () =>

spec/javascripts/.eslintrc.yml

@@ -37,5 +37,4 @@ rules:
       - 'fixtures/blob'
   # Temporarily disabled to facilitate an upgrade to eslint-plugin-jasmine
   jasmine/new-line-before-expect: off
-  jasmine/no-promise-without-done-fail: off
   jasmine/prefer-toHaveBeenCalledWith: off

spec/javascripts/boards/components/board_spec.js

@@ -112,6 +112,6 @@ describe('Board component', () => {
         ).toBe(true);
 
         done();
-      });
+      }).catch(done.fail);
   });
 });

spec/javascripts/lib/utils/common_utils_spec.js

-/* eslint-disable promise/catch-or-return */
 import axios from '~/lib/utils/axios_utils';
 import * as commonUtils from '~/lib/utils/common_utils';
 import MockAdapter from 'axios-mock-adapter';
@@ -360,10 +359,10 @@ describe('common_utils', () => {
         }).then((resp) => {
           stop(resp);
         })
-      )).then((respBackoff) => {
+      ).catch(done.fail)).then((respBackoff) => {
         expect(respBackoff).toBe(expectedResponseValue);
         done();
-      });
+      }).catch(done.fail);
     });
 
     it('catches the rejected promise from the callback ', (done) => {
@@ -394,12 +393,12 @@ describe('common_utils', () => {
               stop(resp);
             }
           })
-      )).then((respBackoff) => {
+      ).catch(done.fail)).then((respBackoff) => {
         const timeouts = window.setTimeout.calls.allArgs().map(([, timeout]) => timeout);
         expect(timeouts).toEqual([2000, 4000]);
         expect(respBackoff).toBe(expectedResponseValue);
         done();
-      });
+      }).catch(done.fail);
     });
 
     it('rejects the backOff promise after timing out', (done) => {
@@ -460,7 +459,7 @@ describe('common_utils', () => {
       commonUtils.createOverlayIcon(faviconDataUrl, overlayDataUrl).then((url) => {
         expect(url).toEqual(faviconWithOverlayDataUrl);
         done();
-      });
+      }).catch(done.fail);
     });
   });
 
@@ -480,7 +479,7 @@ describe('common_utils', () => {
       commonUtils.setFaviconOverlay(overlayDataUrl).then(() => {
         expect(document.getElementById('favicon').getAttribute('href')).toEqual(faviconWithOverlayDataUrl);
         done();
-      });
+      }).catch(done.fail);
     });
   });
 

spec/javascripts/pipelines/pipelines_spec.js

@@ -719,7 +719,7 @@ describe('Pipelines', () => {
                 expect(vm.poll.restart).toHaveBeenCalled();
                 done();
               }, 0);
-            });
+            }).catch(done.fail);
         }, 0);
       });
     });

spec/javascripts/projects/gke_cluster_dropdowns/components/gke_machine_type_dropdown_spec.js

@@ -96,8 +96,8 @@ describe('GkeMachineTypeDropdown', () => {
         return vm.$nextTick().then(() => {
           expect(vm.$el.querySelector('input').value).toBe(selectedMachineTypeMock);
           done();
-        });
-      });
+        }).catch(done.fail);
+      }).catch(done.fail);
     });
   });
 });

spec/javascripts/projects/gke_cluster_dropdowns/components/gke_project_id_dropdown_spec.js

@@ -57,13 +57,13 @@ describe('GkeProjectIdDropdown', () => {
 
         expect(vm.toggleText).toBe(LABELS.DEFAULT);
         done();
-      }));
+      }).catch(done.fail));
 
     it('returns project name if project selected', done =>
       vm.$nextTick().then(() => {
         expect(vm.toggleText).toBe(selectedProjectMock.name);
         done();
-      }));
+      }).catch(done.fail));
 
     it('returns empty toggle text', done =>
       vm.$nextTick().then(() => {
@@ -72,7 +72,7 @@ describe('GkeProjectIdDropdown', () => {
 
         expect(vm.toggleText).toBe(LABELS.EMPTY);
         done();
-      }));
+      }).catch(done.fail));
   });
 
   describe('selectItem', () => {
@@ -85,8 +85,8 @@ describe('GkeProjectIdDropdown', () => {
         return vm.$nextTick().then(() => {
           expect(vm.$el.querySelector('input').value).toBe(selectedProjectMock.projectId);
           done();
-        });
-      });
+        }).catch(done.fail);
+      }).catch(done.fail);
     });
   });
 });

spec/javascripts/projects/gke_cluster_dropdowns/components/gke_zone_dropdown_spec.js

@@ -81,8 +81,8 @@ describe('GkeZoneDropdown', () => {
         return vm.$nextTick().then(() => {
           expect(vm.$el.querySelector('input').value).toBe(selectedZoneMock);
           done();
-        });
-      });
+        }).catch(done.fail);
+      }).catch(done.fail);
     });
   });
 });