Merge branch 'issue#325836-fix-empty-line-after-let-it-be-api-entities' into 'master'

Fix EmptyLineAfterFinalLetItBe Rubocop offenses for api entities

See merge request gitlab-org/gitlab!58193

.rubocop_manual_todo.yml

@@ -753,9 +753,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - spec/helpers/projects/terraform_helper_spec.rb
     - spec/helpers/projects_helper_spec.rb
     - spec/helpers/search_helper_spec.rb
-    - spec/lib/api/entities/design_management/design_spec.rb
-    - spec/lib/api/entities/merge_request_changes_spec.rb
-    - spec/lib/api/entities/release_spec.rb
     - spec/lib/bulk_imports/groups/loaders/group_loader_spec.rb
     - spec/lib/extracts_path_spec.rb
     - spec/lib/extracts_ref_spec.rb

changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-api-entities.yml

+---
+title: Fix EmptyLineAfterFinalLetItBe Rubocop offenses for api entities
+merge_request: 58193
+author: Huzaifa Iftikhar @huzaifaiftikhar
+type: fixed

spec/lib/api/entities/design_management/design_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe API::Entities::DesignManagement::Design do
   let_it_be(:design) { create(:design) }
+
   let(:entity) { described_class.new(design, request: double) }
 
   subject { entity.as_json }

spec/lib/api/entities/merge_request_changes_spec.rb

@@ -5,6 +5,7 @@ require 'spec_helper'
 RSpec.describe ::API::Entities::MergeRequestChanges do
   let_it_be(:user) { create(:user) }
   let_it_be(:merge_request) { create(:merge_request) }
+
   let(:entity) { described_class.new(merge_request, current_user: user) }
 
   subject(:basic_entity) { entity.as_json }

spec/lib/api/entities/release_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe API::Entities::Release do
   let_it_be(:project) { create(:project) }
+
   let(:release) { create(:release, project: project) }
   let(:evidence) { release.evidences.first }
   let(:user) { create(:user) }