Merge branch '1243-fix-cloning-from-geo-secondary' into 'master'

Geo: fix a problem that prevented git cloning from secondary node

This MR prevents activity_service writing in secondary Geo (#76) node's database. This will fix the failure users were experiencing when trying to `git clone` from the secondary node.

cc @marin @dewetblomerus @patricio 

Closes #1243 

See merge request !873

app/services/users/activity_service.rb

@@ -14,7 +14,7 @@ module Users
     private
 
     def record_activity
-      user_activity.touch
+      user_activity.touch unless Gitlab::Geo.secondary?
 
       Rails.logger.debug("Recorded activity: #{@activity} for User ID: #{@author.id} (username: #{@author.username}")
     end

changelogs/unreleased-ee/1243-fix-cloning-from-geo-secondary.yml

+---
+title: 'Geo: fix a problem that prevented git cloning from secondary node'
+merge_request: 873
+author: 

spec/services/users/activity_service_spec.rb

@@ -22,5 +22,13 @@ describe Users::ActivityService, services: true do
         end
       end
     end
+
+    context 'when in Geo secondary node' do
+      before { allow(Gitlab::Geo).to receive(:secondary?).and_return(true) }
+
+      it 'does not update last_activity_at' do
+        expect { service.execute }.not_to change { user.reload.last_activity_at }
+      end
+    end
   end
 end