Merge branch 'dz-et-fix-schema-for-python-sdk' into 'master'

Fix error tracking validation for python sdk

See merge request gitlab-org/gitlab!71943

app/validators/json_schemas/error_tracking_event_payload.json

@@ -28,12 +28,6 @@
               "value": {
                 "type": "string"
               },
-              "module": {
-                "type": "string"
-              },
-              "thread_id": {
-                "type": "number"
-              },
               "stacktrace": {
                 "type": "object",
                 "required": [],
@@ -44,9 +38,6 @@
                       "type": "object",
                       "required": [],
                       "properties": {
-                        "project_root": {
-                          "type": "string"
-                        },
                         "abs_path": {
                           "type": "string"
                         },

spec/fixtures/error_tracking/python_event.json

+{"level":"error","exception":{"values":[{"module":null,"type":"ZeroDivisionError","value":"division by zero","mechanism":{"type":"django","handled":false},"stacktrace":{"frames":[{"filename":"django/core/handlers/exception.py","abs_path":"/Users/dzaporozhets/.asdf/installs/python/3.8.12/lib/python3.8/site-packages/django/core/handlers/exception.py","function":"inner","module":"django.core.handlers.exception","lineno":47,"pre_context":["        return inner","    else:","        @wraps(get_response)","        def inner(request):","            try:"],"context_line":"                response = get_response(request)","post_context":["            except Exception as exc:","                response = response_for_exception(request, exc)","            return response","        return inner",""],"vars":{"request":"\u003cWSGIRequest: GET '/polls/'\u003e","exc":"ZeroDivisionError('division by zero')","get_response":"\u003cbound method BaseHandler._get_response of \u003cdjango.core.handlers.wsgi.WSGIHandler object at 0x10f012550\u003e\u003e"},"in_app":true},{"filename":"django/core/handlers/base.py","abs_path":"/Users/dzaporozhets/.asdf/installs/python/3.8.12/lib/python3.8/site-packages/django/core/handlers/base.py","function":"_get_response","module":"django.core.handlers.base","lineno":181,"pre_context":["            wrapped_callback = self.make_view_atomic(callback)","            # If it is an asynchronous view, run it in a subthread.","            if asyncio.iscoroutinefunction(wrapped_callback):","                wrapped_callback = async_to_sync(wrapped_callback)","            try:"],"context_line":"                response = wrapped_callback(request, *callback_args, **callback_kwargs)","post_context":["            except Exception as e:","                response = self.process_exception_by_middleware(e, request)","                if response is None:","                    raise",""],"vars":{"self":"\u003cdjango.core.handlers.wsgi.WSGIHandler object at 0x10f012550\u003e","request":"\u003cWSGIRequest: GET '/polls/'\u003e","response":"None","callback":"\u003cfunction index at 0x10f7b6820\u003e","callback_args":[],"callback_kwargs":{},"middleware_method":"\u003cfunction CsrfViewMiddleware.process_view at 0x113853a60\u003e","wrapped_callback":"\u003cfunction index at 0x113d41040\u003e"},"in_app":true},{"filename":"polls/views.py","abs_path":"/Users/dzaporozhets/Projects/pysite/polls/views.py","function":"index","module":"polls.views","lineno":15,"pre_context":["    # We recommend adjusting this value in production.","    traces_sample_rate=1.0,",")","","def index(request):"],"context_line":"    division_by_zero = 1 / 0","post_context":["    return HttpResponse(\"Hello, world. You're at the polls index.\")"],"vars":{"request":"\u003cWSGIRequest: GET '/polls/'\u003e"},"in_app":true}]}}]},"event_id":"dbae4fc6415f408786174a929363d26f","timestamp":"2021-10-07T14:52:18.257544Z","breadcrumbs":{"values":[]},"transaction":"/polls/","contexts":{"trace":{"trace_id":"20b50c065f4f4b5d99862e5ea08b45aa","span_id":"a4ecb3118f7f9f5a","parent_span_id":"af50a83a73a41c28","op":"django.middleware","description":"django.middleware.clickjacking.XFrameOptionsMiddleware.__call__"},"runtime":{"name":"CPython","version":"3.8.12","build":"3.8.12 (default, Oct  6 2021, 13:48:19) \n[Clang 12.0.5 (clang-1205.0.22.9)]"}},"modules":{"urllib3":"1.26.7","sqlparse":"0.4.2","setuptools":"56.0.0","sentry-sdk":"1.4.3","pytz":"2021.3","pip":"21.1.1","django":"3.2.8","certifi":"2021.5.30","asgiref":"3.4.1"},"extra":{"sys.argv":["manage.py","runserver"]},"request":{"url":"http://localhost:8000/polls/","query_string":"","method":"GET","env":{"SERVER_NAME":"1.0.0.127.in-addr.arpa","SERVER_PORT":"8000"},"headers":{"Content-Length":"","Content-Type":"text/plain","Host":"localhost:8000","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:92.0) Gecko/20100101 Firefox/92.0","Accept":"text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8","Accept-Language":"en-US,en;q=0.5","Accept-Encoding":"gzip, deflate","Connection":"keep-alive","Cookie":"","Upgrade-Insecure-Requests":"1","Sec-Fetch-Dest":"document","Sec-Fetch-Mode":"navigate","Sec-Fetch-Site":"none","Sec-Fetch-User":"?1","Cache-Control":"max-age=0"}},"environment":"production","server_name":"DZ-GitLab-MBP-15.local","sdk":{"name":"sentry.python","version":"1.4.3","packages":[{"name":"pypi:sentry-sdk","version":"1.4.3"}],"integrations":["argv","atexit","dedupe","django","excepthook","logging","modules","stdlib","threading"]},"platform":"python","_meta":{"request":{"headers":{"Cookie":{"":{"rem":[["!config","x",0,2968]]}}}}}}
\ No newline at end of file

spec/services/error_tracking/collect_error_service_spec.rb

@@ -41,6 +41,14 @@ RSpec.describe ErrorTracking::CollectErrorService do
       expect(event.payload).to eq parsed_event
     end
 
+    context 'python sdk event' do
+      let(:parsed_event) { Gitlab::Json.parse(fixture_file('error_tracking/python_event.json')) }
+
+      it 'creates a valid event' do
+        expect { subject.execute }.to change { ErrorTracking::ErrorEvent.count }.by(1)
+      end
+    end
+
     context 'unusual payload' do
       let(:modified_event) { parsed_event }