Merge branch '208453-add-title-to-analytics-sidebar-menus' into 'master'

Add title to Analytics sidebar menus

Closes #208453

See merge request gitlab-org/gitlab!26265

app/views/layouts/nav/sidebar/_analytics_links.html.haml

@@ -10,6 +10,11 @@
         = _('Analytics')
 
     %ul.sidebar-sub-level-items{ data: { qa_selector: 'analytics_sidebar_submenu' } }
+      = nav_link(path: navbar_links.first.path, html_options: { class: "fly-out-top-item" } ) do
+        = link_to navbar_links.first.link do
+          %strong.fly-out-top-item-name
+            = _('Analytics')
+      %li.divider.fly-out-top-item
       - navbar_links.each do |menu_item|
         = nav_link(path: menu_item.path) do
           = link_to(menu_item.link, menu_item.link_to_options) do

changelogs/unreleased/208453-add-title-to-analytics-sidebar-menus.yml

+---
+title: Add title to Analytics sidebar menus
+merge_request: 26265
+author:
+type: added

spec/features/projects/active_tabs_spec.rb

@@ -139,11 +139,6 @@ describe 'Project active tab' do
         it_behaves_like 'page has active sub tab', _('Repository Analytics')
       end
 
-      context 'on project Analytics/Repository Analytics' do
-        it_behaves_like 'page has active tab', _('Analytics')
-        it_behaves_like 'page has active sub tab', _('Repository Analytics')
-      end
-
       context 'on project Analytics/Cycle Analytics' do
         before do
           click_tab(_('CI / CD Analytics'))