Commit a26b163e authored by Vitaly Slobodin's avatar Vitaly Slobodin

Merge branch 'msj-settings-merge-requests' into 'master'

General/Merge requests - Review and revise settings-related UI text

See merge request gitlab-org/gitlab!50383
parents 8af7ad94 e928f65e
...@@ -2,26 +2,23 @@ ...@@ -2,26 +2,23 @@
.form-group .form-group
%b= s_('ProjectSettings|Merge checks') %b= s_('ProjectSettings|Merge checks')
%p.text-secondary= s_('ProjectSettings|These checks must pass before merge requests can be merged') %p.text-secondary= s_('ProjectSettings|These checks must pass before merge requests can be merged.')
.form-check.mb-2.builds-feature .form-check.mb-2.builds-feature
= form.check_box :only_allow_merge_if_pipeline_succeeds, class: 'form-check-input' = form.check_box :only_allow_merge_if_pipeline_succeeds, class: 'form-check-input'
= form.label :only_allow_merge_if_pipeline_succeeds, class: 'form-check-label' do = form.label :only_allow_merge_if_pipeline_succeeds, class: 'form-check-label' do
= s_('ProjectSettings|Pipelines must succeed') = s_('ProjectSettings|Pipelines must succeed')
.text-secondary .text-secondary
= s_('ProjectSettings|Pipelines need to be configured to enable this feature.') - configuring_pipelines_for_merge_requests_help_link_url = help_page_path('ci/merge_request_pipelines/index.md', anchor: 'configuring-pipelines-for-merge-requests')
= link_to sprite_icon('question-o'), - configuring_pipelines_for_merge_requests_help_link_start = '<a href="%{url}" target="_blank" rel="noopener noreferrer">'.html_safe % { url: configuring_pipelines_for_merge_requests_help_link_url }
help_page_path('ci/merge_request_pipelines/index.md', = s_('ProjectSettings|To enable this feature, configure pipelines. %{link_start}How to configure pipelines for merge requests?%{link_end}').html_safe % { link_start: configuring_pipelines_for_merge_requests_help_link_start, link_end: '</a>'.html_safe }
anchor: 'pipelines-for-merge-requests'),
target: '_blank'
.form-check.mb-2 .form-check.mb-2
.gl-pl-6 .gl-pl-6
= form.check_box :allow_merge_on_skipped_pipeline, class: 'form-check-input' = form.check_box :allow_merge_on_skipped_pipeline, class: 'form-check-input'
= form.label :allow_merge_on_skipped_pipeline, class: 'form-check-label' do = form.label :allow_merge_on_skipped_pipeline, class: 'form-check-label' do
= s_('ProjectSettings|Skipped pipelines are considered successful') = s_('ProjectSettings|Skipped pipelines are considered successful')
.text-secondary .text-secondary
= s_('ProjectSettings|This introduces the risk of merging changes that will not pass the pipeline.') = s_('ProjectSettings|Introduces the risk of merging changes that do not pass the pipeline.')
.form-check.mb-2 .form-check.mb-2
= form.check_box :only_allow_merge_if_all_discussions_are_resolved, class: 'form-check-input', data: { qa_selector: 'allow_merge_if_all_discussions_are_resolved_checkbox' } = form.check_box :only_allow_merge_if_all_discussions_are_resolved, class: 'form-check-input', data: { qa_selector: 'allow_merge_if_all_discussions_are_resolved_checkbox' }
= form.label :only_allow_merge_if_all_discussions_are_resolved, class: 'form-check-label' do = form.label :only_allow_merge_if_all_discussions_are_resolved, class: 'form-check-label' do
= s_('ProjectSettings|All discussions must be resolved') = s_('ProjectSettings|All discussions must be resolved')
= render_if_exists 'projects/merge_request_merge_checks_jira_enforcement', form: form, project: @project
...@@ -2,32 +2,32 @@ ...@@ -2,32 +2,32 @@
.form-group .form-group
%b= s_('ProjectSettings|Merge method') %b= s_('ProjectSettings|Merge method')
%p.text-secondary= s_('ProjectSettings|This will dictate the commit history when you merge a merge request') %p.text-secondary= s_('ProjectSettings|Determine what happens to the commit history when you merge a merge request.')
.form-check.mb-2 .form-check.mb-2
= form.radio_button :merge_method, :merge, class: "js-merge-method-radio form-check-input" = form.radio_button :merge_method, :merge, class: "js-merge-method-radio form-check-input"
= label_tag :project_merge_method_merge, class: 'form-check-label' do = label_tag :project_merge_method_merge, class: 'form-check-label' do
= s_('ProjectSettings|Merge commit') = s_('ProjectSettings|Merge commit')
.text-secondary .text-secondary
= s_('ProjectSettings|Every merge creates a merge commit') = s_('ProjectSettings|Every merge creates a merge commit.')
.form-check.mb-2 .form-check.mb-2
= form.radio_button :merge_method, :rebase_merge, class: "js-merge-method-radio form-check-input" = form.radio_button :merge_method, :rebase_merge, class: "js-merge-method-radio form-check-input"
= label_tag :project_merge_method_rebase_merge, class: 'form-check-label' do = label_tag :project_merge_method_rebase_merge, class: 'form-check-label' do
= s_('ProjectSettings|Merge commit with semi-linear history') = s_('ProjectSettings|Merge commit with semi-linear history')
.text-secondary .text-secondary
= s_('ProjectSettings|Every merge creates a merge commit') = s_('ProjectSettings|Every merge creates a merge commit.')
%br %br
= s_('ProjectSettings|Fast-forward merges only') = s_('ProjectSettings|Fast-forward merges only.')
%br %br
= s_('ProjectSettings|When conflicts arise the user is given the option to rebase') = s_('ProjectSettings|When there is a merge conflict, the user is given the option to rebase.')
.form-check.mb-2 .form-check.mb-2
= form.radio_button :merge_method, :ff, class: "js-merge-method-radio form-check-input", data: { qa_selector: 'merge_ff_radio_button' } = form.radio_button :merge_method, :ff, class: "js-merge-method-radio form-check-input", data: { qa_selector: 'merge_ff_radio_button' }
= label_tag :project_merge_method_ff, class: 'form-check-label' do = label_tag :project_merge_method_ff, class: 'form-check-label' do
= s_('ProjectSettings|Fast-forward merge') = s_('ProjectSettings|Fast-forward merge')
.text-secondary .text-secondary
= s_('ProjectSettings|No merge commits are created') = s_('ProjectSettings|No merge commits are created.')
%br %br
= s_('ProjectSettings|Fast-forward merges only') = s_('ProjectSettings|Fast-forward merges only.')
%br %br
= s_('ProjectSettings|When conflicts arise the user is given the option to rebase') = s_('ProjectSettings|When there is a merge conflict, the user is given the option to rebase.')
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
.form-group#project-merge-options{ data: { project_full_path: @project.full_path } } .form-group#project-merge-options{ data: { project_full_path: @project.full_path } }
%b= s_('ProjectSettings|Merge options') %b= s_('ProjectSettings|Merge options')
%p.text-secondary= s_('ProjectSettings|Additional merge request capabilities that influence how and when merges will be performed') %p.text-secondary= s_('ProjectSettings|Additional settings that influence how and when merges are done.')
= render_if_exists 'projects/merge_pipelines_settings', form: form = render_if_exists 'projects/merge_pipelines_settings', form: form
= render_if_exists 'projects/merge_trains_settings', form: form = render_if_exists 'projects/merge_trains_settings', form: form
.form-check.mb-2 .form-check.mb-2
...@@ -12,10 +12,10 @@ ...@@ -12,10 +12,10 @@
.form-check.mb-2 .form-check.mb-2
= form.check_box :printing_merge_request_link_enabled, class: 'form-check-input' = form.check_box :printing_merge_request_link_enabled, class: 'form-check-input'
= form.label :printing_merge_request_link_enabled, class: 'form-check-label' do = form.label :printing_merge_request_link_enabled, class: 'form-check-label' do
= s_('ProjectSettings|Show link to create/view merge request when pushing from the command line') = s_('ProjectSettings|Show link to create or view a merge request when pushing from the command line')
.form-check.mb-2 .form-check.mb-2
= form.check_box :remove_source_branch_after_merge, class: 'form-check-input' = form.check_box :remove_source_branch_after_merge, class: 'form-check-input'
= form.label :remove_source_branch_after_merge, class: 'form-check-label' do = form.label :remove_source_branch_after_merge, class: 'form-check-label' do
= s_("ProjectSettings|Enable 'Delete source branch' option by default") = s_('ProjectSettings|Enable "Delete source branch" option by default')
.descr.text-secondary .descr.text-secondary
= s_('ProjectSettings|Existing merge requests and protected branches are not affected') = s_('ProjectSettings|Existing merge requests and protected branches are not affected.')
...@@ -3,15 +3,13 @@ ...@@ -3,15 +3,13 @@
.form-group .form-group
%b= s_('ProjectSettings|Merge suggestions') %b= s_('ProjectSettings|Merge suggestions')
%p.text-secondary %p.text-secondary
= s_('ProjectSettings|The commit message used to apply merge request suggestions') - configure_the_commit_message_for_applied_suggestions_help_link_url = help_page_path('user/discussions/index.md', anchor: 'configure-the-commit-message-for-applied-suggestions')
= link_to sprite_icon('question-o'), - configure_the_commit_message_for_applied_suggestions_help_link_start = '<a href="%{url}" target="_blank" rel="noopener noreferrer">'.html_safe % { url: configure_the_commit_message_for_applied_suggestions_help_link_url }
help_page_path('user/discussions/index.md', = s_('ProjectSettings|The commit message used when applying merge request suggestions. %{link_start}Learn more about suggestions.%{link_end}').html_safe % { link_start: configure_the_commit_message_for_applied_suggestions_help_link_start, link_end: '</a>'.html_safe }
anchor: 'configure-the-commit-message-for-applied-suggestions'),
target: '_blank'
.mb-2 .mb-2
= form.text_field :suggestion_commit_message, class: 'form-control gl-form-input mb-2', placeholder: Gitlab::Suggestions::CommitMessage::DEFAULT_SUGGESTION_COMMIT_MESSAGE = form.text_field :suggestion_commit_message, class: 'form-control mb-2', placeholder: Gitlab::Suggestions::CommitMessage::DEFAULT_SUGGESTION_COMMIT_MESSAGE
%p.form-text.text-muted %p.form-text.text-muted
= s_('ProjectSettings|The variables GitLab supports:') = s_('ProjectSettings|Supported variables:')
- Gitlab::Suggestions::CommitMessage::PLACEHOLDERS.keys.each do |placeholder| - Gitlab::Suggestions::CommitMessage::PLACEHOLDERS.keys.each do |placeholder|
%code %code
= "%{#{placeholder}}".html_safe = "%{#{placeholder}}".html_safe
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
.form-group .form-group
%b= s_('ProjectSettings|Squash commits when merging') %b= s_('ProjectSettings|Squash commits when merging')
%p.text-secondary %p.text-secondary
= s_('ProjectSettings|Set the default behavior and availability of this option in merge requests. Changes made are also applied to existing merge requests.') = s_('ProjectSettings|Set the default behavior of this option in merge requests. Changes to this are also applied to existing merge requests.')
= link_to "What is squashing?", = link_to "What is squashing?",
help_page_path('user/project/merge_requests/squash_and_merge.md'), help_page_path('user/project/merge_requests/squash_and_merge.md'),
target: '_blank' target: '_blank'
......
---
title: Updated UI text to match style guidelines
merge_request: 50383
author:
type: fixed
...@@ -20,7 +20,7 @@ Every GitLab project can define its own set of description templates as they ...@@ -20,7 +20,7 @@ Every GitLab project can define its own set of description templates as they
are added to the root directory of a GitLab project's repository. are added to the root directory of a GitLab project's repository.
Description templates must be written in [Markdown](../markdown.md) and stored Description templates must be written in [Markdown](../markdown.md) and stored
in your project's repository under a directory named `.gitlab`. Only the in your project's repository in the `.gitlab` directory. Only the
templates of the default branch are taken into account. templates of the default branch are taken into account.
To learn how to create templates for various file types in groups, visit To learn how to create templates for various file types in groups, visit
...@@ -28,10 +28,14 @@ To learn how to create templates for various file types in groups, visit ...@@ -28,10 +28,14 @@ To learn how to create templates for various file types in groups, visit
## Use cases ## Use cases
These are some situations when you might find description templates useful:
- You can create issues and merge request templates for different
stages of your workflow, for example, feature proposal, feature improvement, or a bug report.
- Add a template to be used in every issue for a specific project, - Add a template to be used in every issue for a specific project,
giving instructions and guidelines, requiring for information specific to that subject. giving instructions and guidelines, requiring for information specific to that subject.
For example, if you have a project for tracking new blog posts, you can require the For example, if you have a project for tracking new blog posts, you can require the
title, outlines, author name, author social media information, and so on. title, outlines, author name, and author social media information.
- Following the previous example, you can make a template for every MR submitted - Following the previous example, you can make a template for every MR submitted
with a new blog post, requiring information about the post date, front matter data, with a new blog post, requiring information about the post date, front matter data,
images guidelines, link to the related issue, reviewer name, and so on. images guidelines, link to the related issue, reviewer name, and so on.
...@@ -130,21 +134,23 @@ with access" or "Only Project Members" in your project's **Settings / Visibility ...@@ -130,21 +134,23 @@ with access" or "Only Project Members" in your project's **Settings / Visibility
template text areas don't show. This is the default behavior, so in most cases template text areas don't show. This is the default behavior, so in most cases
you should be fine. you should be fine.
To set a default description template for merge requests:
1. Go to your project's **Settings**. 1. Go to your project's **Settings**.
1. Click **Expand** under the **Merge requests** header. 1. Select **Expand** under the **Merge requests** header.
1. Fill in the **Default description template for merge requests** text area. 1. Fill in the **Default description template for merge requests** text area.
1. Click **Expand** under **Default issue template**. 1. Select **Save changes**.
1. Fill in the **Default description template for issues** text area.
Since GitLab merge request and issues support [Markdown](../markdown.md), you can use it to format To set a default description template for issues:
headings, lists, and so on.
![Default merge request description templates](img/description_templates_merge_request_settings.png) 1. Select **Expand** under **Default issue template**.
1. Fill in the **Default description template for issues** text area.
![Default issue description templates](img/description_templates_issue_settings.png) Because GitLab merge request and issues support [Markdown](../markdown.md), you can use it to format
headings, lists, and so on.
After you add the description, hit **Save changes** for the settings to take Now, every time a new merge request or issue is created, it's pre-filled with the text you entered
effect. Now, every time a new merge request or issue is created, it is in the templates.
pre-filled with the text you entered in the template(s).
[GitLab versions 13.10 and later](https://gitlab.com/gitlab-org/gitlab/-/issues/885) [GitLab versions 13.10 and later](https://gitlab.com/gitlab-org/gitlab/-/issues/885)
provide `issues_template` and `merge_requests_template` attributes in the provide `issues_template` and `merge_requests_template` attributes in the
...@@ -152,15 +158,16 @@ provide `issues_template` and `merge_requests_template` attributes in the ...@@ -152,15 +158,16 @@ provide `issues_template` and `merge_requests_template` attributes in the
## Description template example ## Description template example
We make use of description templates for issues and merge requests in the GitLab project. We use description templates for issues and merge requests in the
For some examples, refer to the [`.gitlab` folder](https://gitlab.com/gitlab-org/gitlab/tree/master/.gitlab). [`.gitlab` folder](https://gitlab.com/gitlab-org/gitlab/tree/master/.gitlab) of the
GitLab project, which you can refer to for some examples.
NOTE: NOTE:
It's possible to use [quick actions](quick_actions.md) in description templates to quickly add It's possible to use [quick actions](quick_actions.md) in description templates to quickly add
labels, assignees, and milestones. The quick actions are only executed if the user submitting labels, assignees, and milestones. The quick actions are only executed if the user submitting
the issue or merge request has the permissions to perform the relevant actions. the issue or merge request has the permissions to perform the relevant actions.
Here is an example of a Bug report template: Here is an example of a bug report template:
```markdown ```markdown
## Summary ## Summary
......
...@@ -3,11 +3,8 @@ ...@@ -3,11 +3,8 @@
.form-check.builds-feature .form-check.builds-feature
= form.check_box :merge_pipelines_enabled, class: 'form-check-input js-merge-options-merge-pipelines', data: { qa_selector: 'merged_results_pipeline_checkbox' } = form.check_box :merge_pipelines_enabled, class: 'form-check-input js-merge-options-merge-pipelines', data: { qa_selector: 'merged_results_pipeline_checkbox' }
= form.label :merge_pipelines_enabled, class: 'form-check-label' do = form.label :merge_pipelines_enabled, class: 'form-check-label' do
= s_('ProjectSettings|Enable merged results pipelines.') = s_('ProjectSettings|Enable merged results pipelines')
.text-secondary.mb-2 .text-secondary.mb-2
= s_('ProjectSettings|If pipelines for merge requests are enabled in the CI/CD configuration file, pipelines validate the combined results of the source and target branches.') - configuring_pipelines_for_merge_requests_help_link_url = help_page_path('ci/merge_request_pipelines/index', anchor: 'configuring-pipelines-for-merge-requests')
= link_to sprite_icon('question-o'), - configuring_pipelines_for_merge_requests_help_link_start = '<a href="%{url}" target="_blank" rel="noopener noreferrer">'.html_safe % { url: configuring_pipelines_for_merge_requests_help_link_url }
help_page_path('ci/merge_request_pipelines/index.md', = s_('ProjectSettings|When pipelines for merge requests are enabled in the CI/CD configuration file, pipelines validate the combined results of the source and target branches. %{link_start}How to configure pipelines for merge requests?%{link_end}').html_safe % { link_start: configuring_pipelines_for_merge_requests_help_link_start, link_end: '</a>'.html_safe }
anchor: 'configuring-pipelines-for-merge-requests'),
target: '_blank',
rel: 'noopener noreferer'
...@@ -12,10 +12,15 @@ ...@@ -12,10 +12,15 @@
- if @project.feature_available?(:issuable_default_templates) - if @project.feature_available?(:issuable_default_templates)
.form-group .form-group
= form.label :merge_requests_template, class: 'label-bold' do %b= _('Default description template for merge requests')
= _('Default description template for merge requests') %p.text-secondary
= link_to sprite_icon('question-o'), help_page_path('user/project/description_templates'), target: '_blank' = s_('ProjectSettings|Used for every new merge request.')
- create_a_merge_request_template_help_link_url = help_page_path('user/project/description_templates', anchor: 'create-a-merge-request-template')
- create_a_merge_request_templates_elp_link_start = '<a href="%{url}" target="_blank" rel="noopener noreferrer">'.html_safe % { url: create_a_merge_request_template_help_link_url }
= s_('ProjectSettings|%{link_start}What are description templates?%{link_end}').html_safe % { link_start: create_a_merge_request_templates_elp_link_start, link_end: '</a>'.html_safe }
= form.text_area :merge_requests_template, class: "form-control", rows: 3, data: { qa_selector: 'default_merge_request_template_field' } = form.text_area :merge_requests_template, class: "form-control", rows: 3, data: { qa_selector: 'default_merge_request_template_field' }
.text-secondary .text-secondary
- link_start = '<a href="%{url}" target="_blank" rel="noopener noreferrer">'.html_safe % { url: help_page_path('user/markdown') } - link_start = '<a href="%{url}" target="_blank" rel="noopener noreferrer">'.html_safe % { url: help_page_path('user/markdown') }
= _('Description parsed with %{link_start}GitLab Flavored Markdown%{link_end}').html_safe % { link_start: link_start, link_end: '</a>'.html_safe } = _('Description parsed with %{link_start}GitLab Flavored Markdown%{link_end}').html_safe % { link_start: link_start, link_end: '</a>'.html_safe }
...@@ -6,9 +6,6 @@ ...@@ -6,9 +6,6 @@
= form.label :merge_trains_enabled, class: 'form-check-label' do = form.label :merge_trains_enabled, class: 'form-check-label' do
= s_('ProjectSettings|Enable merge trains.') = s_('ProjectSettings|Enable merge trains.')
.text-secondary.mb-2 .text-secondary.mb-2
= s_('ProjectSettings|When approved for merge, merge requests are queued and pipelines validate the combined results of the source and target branches before merge.') - merge_trains_help_link_url = help_page_path('ci/merge_request_pipelines/pipelines_for_merged_results/merge_trains/index.md')
= link_to sprite_icon('question-o'), - merge_trains_help_link_start = '<a href="%{url}" target="_blank" rel="noopener noreferrer">'.html_safe % { url: merge_trains_help_link_url }
help_page_path('ci/merge_request_pipelines/pipelines_for_merged_results/merge_trains/index.md', = s_('ProjectSettings|Merge requests approved for merge are queued, and pipelines validate the combined results of the source and target branches before merge. %{link_start}What are merge trains?%{link_end}').html_safe % { link_start: merge_trains_help_link_start, link_end: '</a>'.html_safe }
anchor: 'merge-trains'),
target: '_blank',
rel: 'noopener noreferer'
- if show_promotions? && show_callout?('promote_mr_features_dismissed') && !@project.feature_available?(:merge_request_approvers) - if show_promotions? && show_callout?('promote_mr_features_dismissed') && !@project.feature_available?(:merge_request_approvers)
.user-callout.promotion-callout.append-bottom-20.js-mr-approval-callout#promote_mr_features{ data: { uid: 'promote_mr_features_dismissed' } } .user-callout.promotion-callout.append-bottom-20.js-mr-approval-callout#promote_mr_features{ data: { uid: 'promote_mr_features_dismissed' } }
.bordered-box.content-block .bordered-box.content-block
%button.btn.btn-default.close.js-close-callout{ type: 'button', 'aria-label' => _('Dismiss Merge Request promotion') } %button.btn.btn-default.close.js-close-callout{ type: 'button', 'aria-label' => _('Dismiss merge request promotion') }
= sprite_icon('close', size: 16, css_class: 'dismiss-icon') = sprite_icon('close', size: 16, css_class: 'dismiss-icon')
.user-callout-copy .user-callout-copy
%h4 %h4
- if Gitlab::CurrentSettings.should_check_namespace_plan? - if Gitlab::CurrentSettings.should_check_namespace_plan?
= _('Upgrade your plan to improve Merge Requests.') = _('Upgrade your plan to improve merge requests.')
- else - else
= _('Improve Merge Requests and customer support with GitLab Enterprise Edition.') = _('Improve merge requests and customer support with GitLab Enterprise Edition.')
%ul %ul
- unless @project.feature_available?(:merge_request_approvers) - unless @project.feature_available?(:merge_request_approvers)
%li %li
= link_to _('Merge Request Approvals'), help_page_path('user/project/merge_requests/merge_request_approvals.md'), target: '_blank' = link_to _('Merge request approvals'), help_page_path('user/project/merge_requests/merge_request_approvals.md'), target: '_blank'
%p %p
= _('Merge request approvals allow you to set the number of necessary approvals and predefine a list of approvers that will need to approve every merge request in a project.') = _('Set the number of necessary approvals and define a list of approvers needed for every merge request in a project.')
= render 'shared/promotions/promotion_link_project' = render 'shared/promotions/promotion_link_project'
...@@ -62,7 +62,7 @@ RSpec.describe 'Disable Merge Trains Setting', :js do ...@@ -62,7 +62,7 @@ RSpec.describe 'Disable Merge Trains Setting', :js do
end end
it 'unchecking merge pipelines checkbox disables merge trains checkbox' do it 'unchecking merge pipelines checkbox disables merge trains checkbox' do
uncheck('Enable merged results pipelines.') uncheck('Enable merged results pipelines')
expect(find('#project_merge_pipelines_enabled')).not_to be_checked expect(find('#project_merge_pipelines_enabled')).not_to be_checked
expect(find('#project_merge_trains_enabled')).to be_disabled expect(find('#project_merge_trains_enabled')).to be_disabled
...@@ -70,7 +70,7 @@ RSpec.describe 'Disable Merge Trains Setting', :js do ...@@ -70,7 +70,7 @@ RSpec.describe 'Disable Merge Trains Setting', :js do
it 'unchecking merge pipelines checkbox unchecks merge trains checkbox if it was previously checked' do it 'unchecking merge pipelines checkbox unchecks merge trains checkbox if it was previously checked' do
check('Enable merge trains.') check('Enable merge trains.')
uncheck('Enable merged results pipelines.') uncheck('Enable merged results pipelines')
expect(find('#project_merge_pipelines_enabled')).not_to be_checked expect(find('#project_merge_pipelines_enabled')).not_to be_checked
expect(find('#project_merge_trains_enabled')).to be_disabled expect(find('#project_merge_trains_enabled')).to be_disabled
...@@ -88,14 +88,14 @@ RSpec.describe 'Disable Merge Trains Setting', :js do ...@@ -88,14 +88,14 @@ RSpec.describe 'Disable Merge Trains Setting', :js do
include_examples 'loads correct checkbox state' include_examples 'loads correct checkbox state'
it 'checking merge pipelines checkbox enables merge trains checkbox' do it 'checking merge pipelines checkbox enables merge trains checkbox' do
check('Enable merged results pipelines.') check('Enable merged results pipelines')
expect(find('#project_merge_pipelines_enabled')).to be_checked expect(find('#project_merge_pipelines_enabled')).to be_checked
expect(find('#project_merge_trains_enabled')).not_to be_disabled expect(find('#project_merge_trains_enabled')).not_to be_disabled
end end
it 'checking merge pipelines checkbox should leave merge trains checkbox unchecked' do it 'checking merge pipelines checkbox should leave merge trains checkbox unchecked' do
check('Enable merged results pipelines.') check('Enable merged results pipelines')
expect(find('#project_merge_pipelines_enabled')).to be_checked expect(find('#project_merge_pipelines_enabled')).to be_checked
expect(find('#project_merge_trains_enabled')).not_to be_checked expect(find('#project_merge_trains_enabled')).not_to be_checked
...@@ -112,7 +112,7 @@ RSpec.describe 'Disable Merge Trains Setting', :js do ...@@ -112,7 +112,7 @@ RSpec.describe 'Disable Merge Trains Setting', :js do
include_examples 'loads correct checkbox state' include_examples 'loads correct checkbox state'
it 'unchecking merge pipelines checkbox disables and unchecks merge trains checkbox' do it 'unchecking merge pipelines checkbox disables and unchecks merge trains checkbox' do
uncheck('Enable merged results pipelines.') uncheck('Enable merged results pipelines')
expect(find('#project_merge_pipelines_enabled')).not_to be_checked expect(find('#project_merge_pipelines_enabled')).not_to be_checked
expect(find('#project_merge_trains_enabled')).to be_disabled expect(find('#project_merge_trains_enabled')).to be_disabled
......
...@@ -23,7 +23,7 @@ RSpec.describe 'User manages merge pipelines option', :js do ...@@ -23,7 +23,7 @@ RSpec.describe 'User manages merge pipelines option', :js do
before do before do
visit edit_project_path(project) visit edit_project_path(project)
check('Enable merged results pipelines.') check('Enable merged results pipelines')
end end
it 'sees enabled merge pipeline checkbox' do it 'sees enabled merge pipeline checkbox' do
......
...@@ -26,7 +26,7 @@ RSpec.describe 'User manages merge trains option', :js do ...@@ -26,7 +26,7 @@ RSpec.describe 'User manages merge trains option', :js do
visit edit_project_path(project) visit edit_project_path(project)
wait_for_requests wait_for_requests
check('Enable merge trains.') check('Enable merge trains')
end end
it 'sees enabled merge trains checkbox' do it 'sees enabled merge trains checkbox' do
......
...@@ -24,7 +24,7 @@ RSpec.describe 'Promotions', :js do ...@@ -24,7 +24,7 @@ RSpec.describe 'Promotions', :js do
it 'appears in project edit page' do it 'appears in project edit page' do
visit edit_project_path(project) visit edit_project_path(project)
expect(find('#promote_mr_features')).to have_content 'Improve Merge Requests' expect(find('#promote_mr_features')).to have_content 'Improve merge requests'
end end
it 'does not show when cookie is set' do it 'does not show when cookie is set' do
......
...@@ -10870,6 +10870,9 @@ msgstr "" ...@@ -10870,6 +10870,9 @@ msgstr ""
msgid "Dismiss Value Stream Analytics introduction box" msgid "Dismiss Value Stream Analytics introduction box"
msgstr "" msgstr ""
msgid "Dismiss merge request promotion"
msgstr ""
msgid "Dismiss selected" msgid "Dismiss selected"
msgstr "" msgstr ""
...@@ -15670,10 +15673,10 @@ msgid_plural "Importing %d repositories" ...@@ -15670,10 +15673,10 @@ msgid_plural "Importing %d repositories"
msgstr[0] "" msgstr[0] ""
msgstr[1] "" msgstr[1] ""
msgid "Improve Merge Requests and customer support with GitLab Enterprise Edition." msgid "Improve customer support with Service Desk"
msgstr "" msgstr ""
msgid "Improve customer support with Service Desk" msgid "Improve merge requests and customer support with GitLab Enterprise Edition."
msgstr "" msgstr ""
msgid "Improve search with Advanced Search and GitLab Enterprise Edition." msgid "Improve search with Advanced Search and GitLab Enterprise Edition."
...@@ -18958,9 +18961,6 @@ msgstr "" ...@@ -18958,9 +18961,6 @@ msgstr ""
msgid "Merge Request Analytics" msgid "Merge Request Analytics"
msgstr "" msgstr ""
msgid "Merge Request Approvals"
msgstr ""
msgid "Merge Request Commits" msgid "Merge Request Commits"
msgstr "" msgstr ""
...@@ -19018,9 +19018,6 @@ msgstr "" ...@@ -19018,9 +19018,6 @@ msgstr ""
msgid "Merge request approvals" msgid "Merge request approvals"
msgstr "" msgstr ""
msgid "Merge request approvals allow you to set the number of necessary approvals and predefine a list of approvers that will need to approve every merge request in a project."
msgstr ""
msgid "Merge request dependencies" msgid "Merge request dependencies"
msgstr "" msgstr ""
...@@ -23734,7 +23731,10 @@ msgstr "" ...@@ -23734,7 +23731,10 @@ msgstr ""
msgid "ProjectService|To set up this service:" msgid "ProjectService|To set up this service:"
msgstr "" msgstr ""
msgid "ProjectSettings|Additional merge request capabilities that influence how and when merges will be performed" msgid "ProjectSettings|%{link_start}What are description templates?%{link_end}"
msgstr ""
msgid "ProjectSettings|Additional settings that influence how and when merges are done."
msgstr "" msgstr ""
msgid "ProjectSettings|All discussions must be resolved" msgid "ProjectSettings|All discussions must be resolved"
...@@ -23788,25 +23788,28 @@ msgstr "" ...@@ -23788,25 +23788,28 @@ msgstr ""
msgid "ProjectSettings|Customize this project's badges." msgid "ProjectSettings|Customize this project's badges."
msgstr "" msgstr ""
msgid "ProjectSettings|Determine what happens to the commit history when you merge a merge request."
msgstr ""
msgid "ProjectSettings|Disable email notifications" msgid "ProjectSettings|Disable email notifications"
msgstr "" msgstr ""
msgid "ProjectSettings|Do not allow" msgid "ProjectSettings|Do not allow"
msgstr "" msgstr ""
msgid "ProjectSettings|Enable 'Delete source branch' option by default" msgid "ProjectSettings|Enable \"Delete source branch\" option by default"
msgstr "" msgstr ""
msgid "ProjectSettings|Enable merge trains." msgid "ProjectSettings|Enable merge trains."
msgstr "" msgstr ""
msgid "ProjectSettings|Enable merged results pipelines." msgid "ProjectSettings|Enable merged results pipelines"
msgstr "" msgstr ""
msgid "ProjectSettings|Encourage" msgid "ProjectSettings|Encourage"
msgstr "" msgstr ""
msgid "ProjectSettings|Every merge creates a merge commit" msgid "ProjectSettings|Every merge creates a merge commit."
msgstr "" msgstr ""
msgid "ProjectSettings|Every project can have its own space to store its Docker images" msgid "ProjectSettings|Every project can have its own space to store its Docker images"
...@@ -23818,7 +23821,7 @@ msgstr "" ...@@ -23818,7 +23821,7 @@ msgstr ""
msgid "ProjectSettings|Everyone" msgid "ProjectSettings|Everyone"
msgstr "" msgstr ""
msgid "ProjectSettings|Existing merge requests and protected branches are not affected" msgid "ProjectSettings|Existing merge requests and protected branches are not affected."
msgstr "" msgstr ""
msgid "ProjectSettings|Failed to protect the tag" msgid "ProjectSettings|Failed to protect the tag"
...@@ -23830,7 +23833,7 @@ msgstr "" ...@@ -23830,7 +23833,7 @@ msgstr ""
msgid "ProjectSettings|Fast-forward merge" msgid "ProjectSettings|Fast-forward merge"
msgstr "" msgstr ""
msgid "ProjectSettings|Fast-forward merges only" msgid "ProjectSettings|Fast-forward merges only."
msgstr "" msgstr ""
msgid "ProjectSettings|Forks" msgid "ProjectSettings|Forks"
...@@ -23842,10 +23845,10 @@ msgstr "" ...@@ -23842,10 +23845,10 @@ msgstr ""
msgid "ProjectSettings|Global" msgid "ProjectSettings|Global"
msgstr "" msgstr ""
msgid "ProjectSettings|If pipelines for merge requests are enabled in the CI/CD configuration file, pipelines validate the combined results of the source and target branches." msgid "ProjectSettings|Internal"
msgstr "" msgstr ""
msgid "ProjectSettings|Internal" msgid "ProjectSettings|Introduces the risk of merging changes that do not pass the pipeline."
msgstr "" msgstr ""
msgid "ProjectSettings|Issues" msgid "ProjectSettings|Issues"
...@@ -23878,10 +23881,13 @@ msgstr "" ...@@ -23878,10 +23881,13 @@ msgstr ""
msgid "ProjectSettings|Merge requests" msgid "ProjectSettings|Merge requests"
msgstr "" msgstr ""
msgid "ProjectSettings|Merge requests approved for merge are queued, and pipelines validate the combined results of the source and target branches before merge. %{link_start}What are merge trains?%{link_end}"
msgstr ""
msgid "ProjectSettings|Merge suggestions" msgid "ProjectSettings|Merge suggestions"
msgstr "" msgstr ""
msgid "ProjectSettings|No merge commits are created" msgid "ProjectSettings|No merge commits are created."
msgstr "" msgstr ""
msgid "ProjectSettings|Note: the container registry is always visible when a project is public" msgid "ProjectSettings|Note: the container registry is always visible when a project is public"
...@@ -23911,9 +23917,6 @@ msgstr "" ...@@ -23911,9 +23917,6 @@ msgstr ""
msgid "ProjectSettings|Pipelines must succeed" msgid "ProjectSettings|Pipelines must succeed"
msgstr "" msgstr ""
msgid "ProjectSettings|Pipelines need to be configured to enable this feature."
msgstr ""
msgid "ProjectSettings|Private" msgid "ProjectSettings|Private"
msgstr "" msgstr ""
...@@ -23944,7 +23947,7 @@ msgstr "" ...@@ -23944,7 +23947,7 @@ msgstr ""
msgid "ProjectSettings|Security & Compliance for this project" msgid "ProjectSettings|Security & Compliance for this project"
msgstr "" msgstr ""
msgid "ProjectSettings|Set the default behavior and availability of this option in merge requests. Changes made are also applied to existing merge requests." msgid "ProjectSettings|Set the default behavior of this option in merge requests. Changes to this are also applied to existing merge requests."
msgstr "" msgstr ""
msgid "ProjectSettings|Share code with others outside the project." msgid "ProjectSettings|Share code with others outside the project."
...@@ -23953,7 +23956,7 @@ msgstr "" ...@@ -23953,7 +23956,7 @@ msgstr ""
msgid "ProjectSettings|Show default award emojis" msgid "ProjectSettings|Show default award emojis"
msgstr "" msgstr ""
msgid "ProjectSettings|Show link to create/view merge request when pushing from the command line" msgid "ProjectSettings|Show link to create or view a merge request when pushing from the command line"
msgstr "" msgstr ""
msgid "ProjectSettings|Skipped pipelines are considered successful" msgid "ProjectSettings|Skipped pipelines are considered successful"
...@@ -23974,16 +23977,13 @@ msgstr "" ...@@ -23974,16 +23977,13 @@ msgstr ""
msgid "ProjectSettings|Submit changes to be merged upstream." msgid "ProjectSettings|Submit changes to be merged upstream."
msgstr "" msgstr ""
msgid "ProjectSettings|The commit message used to apply merge request suggestions" msgid "ProjectSettings|Supported variables:"
msgstr "" msgstr ""
msgid "ProjectSettings|The variables GitLab supports:" msgid "ProjectSettings|The commit message used when applying merge request suggestions. %{link_start}Learn more about suggestions.%{link_end}"
msgstr "" msgstr ""
msgid "ProjectSettings|These checks must pass before merge requests can be merged" msgid "ProjectSettings|These checks must pass before merge requests can be merged."
msgstr ""
msgid "ProjectSettings|This introduces the risk of merging changes that will not pass the pipeline."
msgstr "" msgstr ""
msgid "ProjectSettings|This setting is applied on the server level and can be overridden by an admin." msgid "ProjectSettings|This setting is applied on the server level and can be overridden by an admin."
...@@ -23995,12 +23995,15 @@ msgstr "" ...@@ -23995,12 +23995,15 @@ msgstr ""
msgid "ProjectSettings|This setting will be applied to all projects unless overridden by an admin." msgid "ProjectSettings|This setting will be applied to all projects unless overridden by an admin."
msgstr "" msgstr ""
msgid "ProjectSettings|This will dictate the commit history when you merge a merge request" msgid "ProjectSettings|To enable this feature, configure pipelines. %{link_start}How to configure pipelines for merge requests?%{link_end}"
msgstr "" msgstr ""
msgid "ProjectSettings|Transfer project" msgid "ProjectSettings|Transfer project"
msgstr "" msgstr ""
msgid "ProjectSettings|Used for every new merge request."
msgstr ""
msgid "ProjectSettings|Users can copy the repository to a new project." msgid "ProjectSettings|Users can copy the repository to a new project."
msgstr "" msgstr ""
...@@ -24028,10 +24031,10 @@ msgstr "" ...@@ -24028,10 +24031,10 @@ msgstr ""
msgid "ProjectSettings|What are badges?" msgid "ProjectSettings|What are badges?"
msgstr "" msgstr ""
msgid "ProjectSettings|When approved for merge, merge requests are queued and pipelines validate the combined results of the source and target branches before merge." msgid "ProjectSettings|When pipelines for merge requests are enabled in the CI/CD configuration file, pipelines validate the combined results of the source and target branches. %{link_start}How to configure pipelines for merge requests?%{link_end}"
msgstr "" msgstr ""
msgid "ProjectSettings|When conflicts arise the user is given the option to rebase" msgid "ProjectSettings|When there is a merge conflict, the user is given the option to rebase."
msgstr "" msgstr ""
msgid "ProjectSettings|Wiki" msgid "ProjectSettings|Wiki"
...@@ -27523,6 +27526,9 @@ msgstr "" ...@@ -27523,6 +27526,9 @@ msgstr ""
msgid "Set the milestone to %{milestone_reference}." msgid "Set the milestone to %{milestone_reference}."
msgstr "" msgstr ""
msgid "Set the number of necessary approvals and define a list of approvers needed for every merge request in a project."
msgstr ""
msgid "Set the timeout in seconds to send a secondary node status to the primary and IPs allowed for the secondary nodes." msgid "Set the timeout in seconds to send a secondary node status to the primary and IPs allowed for the secondary nodes."
msgstr "" msgstr ""
...@@ -32379,7 +32385,7 @@ msgstr "" ...@@ -32379,7 +32385,7 @@ msgstr ""
msgid "Upgrade your plan to enable this feature of the Jira Integration." msgid "Upgrade your plan to enable this feature of the Jira Integration."
msgstr "" msgstr ""
msgid "Upgrade your plan to improve Merge Requests." msgid "Upgrade your plan to improve merge requests."
msgstr "" msgstr ""
msgid "Upload" msgid "Upload"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment