Remove FF ci_root_config_content

This FF was introduced when implementing saving config content
for pipelines. Now, it can be removed safely.

lib/gitlab/ci/pipeline/chain/config/content.rb

@@ -16,15 +16,9 @@ module Gitlab
               Gitlab::Ci::Pipeline::Chain::Config::Content::AutoDevops
             ].freeze
 
-            LEGACY_SOURCES = [
-              Gitlab::Ci::Pipeline::Chain::Config::Content::Bridge,
-              Gitlab::Ci::Pipeline::Chain::Config::Content::LegacyRepository,
-              Gitlab::Ci::Pipeline::Chain::Config::Content::LegacyAutoDevops
-            ].freeze
-
             def perform!
               if config = find_config
-                @pipeline.build_pipeline_config(content: config.content) if ci_root_config_content_enabled?
+                @pipeline.build_pipeline_config(content: config.content)
                 @command.config_content = config.content
                 @pipeline.config_source = config.source
               else
@@ -39,21 +33,13 @@ module Gitlab
             private
 
             def find_config
-              sources.each do |source|
+              SOURCES.each do |source|
                 config = source.new(@pipeline, @command)
                 return config if config.exists?
               end
 
               nil
             end
-
-            def sources
-              ci_root_config_content_enabled? ? SOURCES : LEGACY_SOURCES
-            end
-
-            def ci_root_config_content_enabled?
-              Feature.enabled?(:ci_root_config_content, @command.project, default_enabled: true)
-            end
           end
         end
       end

lib/gitlab/ci/pipeline/chain/config/content/legacy_auto_devops.rb

-# frozen_string_literal: true
-
-module Gitlab
-  module Ci
-    module Pipeline
-      module Chain
-        module Config
-          class Content
-            class LegacyAutoDevops < Source
-              def content
-                strong_memoize(:content) do
-                  next unless project&.auto_devops_enabled?
-
-                  template = Gitlab::Template::GitlabCiYmlTemplate.find(template_name)
-                  template.content
-                end
-              end
-
-              def source
-                :auto_devops_source
-              end
-
-              private
-
-              def template_name
-                'Auto-DevOps'
-              end
-            end
-          end
-        end
-      end
-    end
-  end
-end

lib/gitlab/ci/pipeline/chain/config/content/legacy_repository.rb

-# frozen_string_literal: true
-
-module Gitlab
-  module Ci
-    module Pipeline
-      module Chain
-        module Config
-          class Content
-            class LegacyRepository < Source
-              def content
-                strong_memoize(:content) do
-                  next unless project
-                  next unless @pipeline.sha
-                  next unless ci_config_path
-
-                  project.repository.gitlab_ci_yml_for(@pipeline.sha, ci_config_path)
-                rescue GRPC::NotFound, GRPC::Internal
-                  nil
-                end
-              end
-
-              def source
-                :repository_source
-              end
-            end
-          end
-        end
-      end
-    end
-  end
-end

spec/lib/gitlab/ci/pipeline/chain/config/content_spec.rb

@@ -10,146 +10,6 @@ describe Gitlab::Ci::Pipeline::Chain::Config::Content do
   subject { described_class.new(pipeline, command) }
 
   describe '#perform!' do
-    context 'when feature flag is disabled' do
-      before do
-        stub_feature_flags(ci_root_config_content: false)
-      end
-
-      context 'when bridge job is passed in as parameter' do
-        let(:ci_config_path) { nil }
-        let(:bridge) { create(:ci_bridge) }
-
-        before do
-          command.bridge = bridge
-        end
-
-        context 'when bridge job has downstream yaml' do
-          before do
-            allow(bridge).to receive(:yaml_for_downstream).and_return('the-yaml')
-          end
-
-          it 'returns the content already available in command' do
-            subject.perform!
-
-            expect(pipeline.config_source).to eq 'bridge_source'
-            expect(command.config_content).to eq 'the-yaml'
-          end
-        end
-
-        context 'when bridge job does not have downstream yaml' do
-          before do
-            allow(bridge).to receive(:yaml_for_downstream).and_return(nil)
-          end
-
-          it 'returns the next available source' do
-            subject.perform!
-
-            expect(pipeline.config_source).to eq 'auto_devops_source'
-            template = Gitlab::Template::GitlabCiYmlTemplate.find('Auto-DevOps')
-            expect(command.config_content).to eq(template.content)
-          end
-        end
-      end
-
-      context 'when config is defined in a custom path in the repository' do
-        let(:ci_config_path) { 'path/to/config.yml' }
-
-        before do
-          expect(project.repository)
-            .to receive(:gitlab_ci_yml_for)
-            .with(pipeline.sha, ci_config_path)
-            .and_return('the-content')
-        end
-
-        it 'returns the content of the YAML file' do
-          subject.perform!
-
-          expect(pipeline.config_source).to eq 'repository_source'
-          expect(pipeline.pipeline_config).to be_nil
-          expect(command.config_content).to eq('the-content')
-        end
-      end
-
-      context 'when config is defined remotely' do
-        let(:ci_config_path) { 'http://example.com/path/to/ci/config.yml' }
-
-        it 'does not support URLs and default to AutoDevops' do
-          subject.perform!
-
-          expect(pipeline.config_source).to eq 'auto_devops_source'
-          expect(pipeline.pipeline_config).to be_nil
-          template = Gitlab::Template::GitlabCiYmlTemplate.find('Auto-DevOps')
-          expect(command.config_content).to eq(template.content)
-        end
-      end
-
-      context 'when config is defined in a separate repository' do
-        let(:ci_config_path) { 'path/to/.gitlab-ci.yml@another-group/another-repo' }
-
-        it 'does not support YAML from external repository and default to AutoDevops' do
-          subject.perform!
-
-          expect(pipeline.config_source).to eq 'auto_devops_source'
-          expect(pipeline.pipeline_config).to be_nil
-          template = Gitlab::Template::GitlabCiYmlTemplate.find('Auto-DevOps')
-          expect(command.config_content).to eq(template.content)
-        end
-      end
-
-      context 'when config is defined in the default .gitlab-ci.yml' do
-        let(:ci_config_path) { nil }
-
-        before do
-          expect(project.repository)
-            .to receive(:gitlab_ci_yml_for)
-            .with(pipeline.sha, '.gitlab-ci.yml')
-            .and_return('the-content')
-        end
-
-        it 'returns the content of the canonical config file' do
-          subject.perform!
-
-          expect(pipeline.config_source).to eq 'repository_source'
-          expect(pipeline.pipeline_config).to be_nil
-          expect(command.config_content).to eq('the-content')
-        end
-      end
-
-      context 'when config is the Auto-Devops template' do
-        let(:ci_config_path) { nil }
-
-        before do
-          expect(project).to receive(:auto_devops_enabled?).and_return(true)
-        end
-
-        it 'returns the content of AutoDevops template' do
-          subject.perform!
-
-          expect(pipeline.config_source).to eq 'auto_devops_source'
-          expect(pipeline.pipeline_config).to be_nil
-          template = Gitlab::Template::GitlabCiYmlTemplate.find('Auto-DevOps')
-          expect(command.config_content).to eq(template.content)
-        end
-      end
-
-      context 'when config is not defined anywhere' do
-        let(:ci_config_path) { nil }
-
-        before do
-          expect(project).to receive(:auto_devops_enabled?).and_return(false)
-        end
-
-        it 'builds root config including the auto-devops template' do
-          subject.perform!
-
-          expect(pipeline.config_source).to eq('unknown_source')
-          expect(pipeline.pipeline_config).to be_nil
-          expect(command.config_content).to be_nil
-          expect(pipeline.errors.full_messages).to include('Missing CI config file')
-        end
-      end
-    end
-
     context 'when bridge job is passed in as parameter' do
       let(:ci_config_path) { nil }
       let(:bridge) { create(:ci_bridge) }

spec/support/helpers/stub_gitlab_calls.rb

@@ -30,11 +30,9 @@ module StubGitlabCalls
 
     # Stub the first call to `include:[local: .gitlab-ci.yml]` when
     # evaluating the CI root config content.
-    if Feature.enabled?(:ci_root_config_content, default_enabled: true)
-      allow_any_instance_of(Gitlab::Ci::Config::External::File::Local)
-        .to receive(:content)
-        .and_return(ci_yaml_content)
-    end
+    allow_any_instance_of(Gitlab::Ci::Config::External::File::Local)
+      .to receive(:content)
+      .and_return(ci_yaml_content)
   end
 
   def stub_pipeline_modified_paths(pipeline, modified_paths)