Rename method to instrumentation

lib/gitlab/usage/metrics/instrumentations/base_metric.rb

@@ -16,7 +16,7 @@ module Gitlab
             @options = options
           end
 
-          def for_data_warehouse
+          def instrumentation
             value
           end
         end

lib/gitlab/usage/metrics/instrumentations/database_metric.rb

@@ -59,7 +59,7 @@ module Gitlab
             Gitlab::Usage::Metrics::Query.for(self.class.metric_operation, relation, self.class.column)
           end
 
-          def for_data_warehouse
+          def instrumentation
             to_sql
           end
 

lib/gitlab/usage_data_non_sql_metrics.rb

@@ -6,7 +6,7 @@ module Gitlab
 
     class << self
       def add_metric(metric)
-        metric.for_data_warehouse
+        metric.instrumentation
       end
 
       def count(relation, column = nil, batch: true, batch_size: nil, start: nil, finish: nil)

lib/gitlab/usage_data_queries.rb

@@ -6,7 +6,7 @@ module Gitlab
   class UsageDataQueries < UsageData
     class << self
       def add_metric(metric)
-        metric.for_data_warehouse
+        metric.instrumentation
       end
 
       def count(relation, column = nil, *args, **kwargs)

spec/lib/gitlab/usage_data_non_sql_metrics_spec.rb

@@ -6,7 +6,7 @@ RSpec.describe Gitlab::UsageDataNonSqlMetrics do
   let(:default_count) { Gitlab::UsageDataNonSqlMetrics::SQL_METRIC_DEFAULT }
 
   describe '#add_metric' do
-    let(:metric) { double(:metric, for_data_warehouse: 1) }
+    let(:metric) { double(:metric, instrumentation: 1) }
 
     it 'computes the metric value for given metric' do
       expect(described_class.add_metric(metric)).to eq(1)

spec/lib/gitlab/usage_data_queries_spec.rb

@@ -8,7 +8,7 @@ RSpec.describe Gitlab::UsageDataQueries do
   end
 
   describe '#add_metric' do
-    let(:metric) { double(:metric, for_data_warehouse: 'SELECT COUNT("users"."id") FROM "users"') }
+    let(:metric) { double(:metric, instrumentation: 'SELECT COUNT("users"."id") FROM "users"') }
 
     it 'computes the metric value for given metric' do
       expect(described_class.add_metric(metric)).to eq('SELECT COUNT("users"."id") FROM "users"')