Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
a57e0c60
Commit
a57e0c60
authored
Jan 31, 2022
by
Phil Hughes
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Renamed diff searching feature flag
Closes
https://gitlab.com/gitlab-org/gitlab/-/issues/351273
parent
f9e06ba8
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
5 additions
and
5 deletions
+5
-5
app/assets/javascripts/diffs/components/app.vue
app/assets/javascripts/diffs/components/app.vue
+2
-2
app/controllers/projects/merge_requests_controller.rb
app/controllers/projects/merge_requests_controller.rb
+1
-1
config/feature_flags/development/usage_data_diff_searches.yml
...ig/feature_flags/development/usage_data_diff_searches.yml
+1
-1
lib/gitlab/usage_data_counters/known_events/code_review_events.yml
...b/usage_data_counters/known_events/code_review_events.yml
+1
-1
No files found.
app/assets/javascripts/diffs/components/app.vue
View file @
a57e0c60
...
...
@@ -524,7 +524,7 @@ export default {
if
(
window
.
gon
?.
features
?.
diffsVirtualScrolling
||
window
.
gon
?.
features
?.
diffSearchingUsageData
window
.
gon
?.
features
?.
usageDataDiffSearches
)
{
let
keydownTime
;
Mousetrap
.
bind
([
'
mod+f
'
,
'
mod+g
'
],
()
=>
{
...
...
@@ -540,7 +540,7 @@ export default {
if
(
delta
>=
0
&&
delta
<
1000
)
{
this
.
disableVirtualScroller
();
if
(
window
.
gon
?.
features
?.
diffSearchingUsageData
)
{
if
(
window
.
gon
?.
features
?.
usageDataDiffSearches
)
{
api
.
trackRedisHllUserEvent
(
'
i_code_review_user_searches_diff
'
);
api
.
trackRedisCounterEvent
(
'
diff_searches
'
);
}
...
...
app/controllers/projects/merge_requests_controller.rb
View file @
a57e0c60
...
...
@@ -47,7 +47,7 @@ class Projects::MergeRequestsController < Projects::MergeRequests::ApplicationCo
# Usage data feature flags
push_frontend_feature_flag
(
:users_expanding_widgets_usage_data
,
@project
,
default_enabled: :yaml
)
push_frontend_feature_flag
(
:diff_settings_usage_data
,
default_enabled: :yaml
)
push_frontend_feature_flag
(
:
diff_searching_usage_data
,
@project
,
default_enabled: :yaml
)
push_frontend_feature_flag
(
:
usage_data_diff_searches
,
@project
,
default_enabled: :yaml
)
end
around_action
:allow_gitaly_ref_name_caching
,
only:
[
:index
,
:show
,
:discussions
]
...
...
config/feature_flags/development/
diff_searching_usage_data
.yml
→
config/feature_flags/development/
usage_data_diff_searches
.yml
View file @
a57e0c60
---
name
:
diff_searching_usage_data
name
:
usage_data_diff_searches
introduced_by_url
:
rollout_issue_url
:
milestone
:
'
14.2'
...
...
lib/gitlab/usage_data_counters/known_events/code_review_events.yml
View file @
a57e0c60
...
...
@@ -236,7 +236,7 @@
redis_slot
:
code_review
category
:
code_review
aggregation
:
weekly
feature_flag
:
diff_searching_usage_data
feature_flag
:
usage_data_diff_searches
-
name
:
i_code_review_total_suggestions_applied
redis_slot
:
code_review
category
:
code_review
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment