Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
a68eabd2
Commit
a68eabd2
authored
Jun 09, 2015
by
Nicolas
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Make submit hotkey available to all notes forms.
Addresses #2221.
parent
b637f849
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
5 deletions
+3
-5
app/assets/javascripts/notes.js.coffee
app/assets/javascripts/notes.js.coffee
+3
-5
No files found.
app/assets/javascripts/notes.js.coffee
View file @
a68eabd2
...
@@ -63,13 +63,11 @@ class @Notes
...
@@ -63,13 +63,11 @@ class @Notes
# fetch notes when tab becomes visible
# fetch notes when tab becomes visible
$
(
document
).
on
"visibilitychange"
,
@
visibilityChange
$
(
document
).
on
"visibilitychange"
,
@
visibilityChange
@
notes_forms
=
'.js-main-target-form textarea, .js-discussion-note-form textarea'
# Chrome doesn't fire keypress or keyup for Command+Enter, so we need keydown.
# Chrome doesn't fire keypress or keyup for Command+Enter, so we need keydown.
$
(
document
).
on
(
'keydown'
,
@
notes_forms
,
(
e
)
->
$
(
document
).
on
'keydown'
,
'.js-note-text'
,
(
e
)
->
return
if
e
.
originalEvent
.
repeat
return
if
e
.
originalEvent
.
repeat
if
e
.
keyCode
==
10
||
((
e
.
metaKey
||
e
.
ctrlKey
)
&&
e
.
keyCode
==
13
)
if
e
.
keyCode
==
10
||
((
e
.
metaKey
||
e
.
ctrlKey
)
&&
e
.
keyCode
==
13
)
$
(
@
).
parents
(
'form'
).
submit
()
$
(
@
).
closest
(
'form'
).
submit
()
)
cleanBinding
:
->
cleanBinding
:
->
$
(
document
).
off
"ajax:success"
,
".js-main-target-form"
$
(
document
).
off
"ajax:success"
,
".js-main-target-form"
...
@@ -84,7 +82,7 @@ class @Notes
...
@@ -84,7 +82,7 @@ class @Notes
$
(
document
).
off
"click"
,
".js-discussion-reply-button"
$
(
document
).
off
"click"
,
".js-discussion-reply-button"
$
(
document
).
off
"click"
,
".js-add-diff-note-button"
$
(
document
).
off
"click"
,
".js-add-diff-note-button"
$
(
document
).
off
"visibilitychange"
$
(
document
).
off
"visibilitychange"
$
(
document
).
off
"keydown"
,
@
notes_forms
$
(
document
).
off
"keydown"
,
".js-note-text"
$
(
document
).
off
"keyup"
,
".js-note-text"
$
(
document
).
off
"keyup"
,
".js-note-text"
$
(
document
).
off
"click"
,
".js-note-target-reopen"
$
(
document
).
off
"click"
,
".js-note-target-reopen"
$
(
document
).
off
"click"
,
".js-note-target-close"
$
(
document
).
off
"click"
,
".js-note-target-close"
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment