Stub proxy for specs

spec/ee/spec/lib/ee/gitlab/ldap/user_spec.rb

@@ -15,11 +15,10 @@ describe Gitlab::LDAP::User do
   let(:auth_hash) do
     OmniAuth::AuthHash.new(uid: 'uid=john,ou=people,dc=example,dc=com', provider: 'ldapmain', info: info)
   end
-  let(:adapter) { ldap_adapter }
   let(:group_cn) { 'foo' }
   let(:group_member_dns) { [auth_hash.uid] }
   let(:external_groups) { [] }
-  let(:fake_proxy) { double(:proxy, adapter: adapter) }
+  let!(:fake_proxy) { fake_ldap_sync_proxy(auth_hash.provider) }
 
   before do
     allow(fake_proxy).to receive(:dns_for_group_cn).with(group_cn).and_return(group_member_dns)
@@ -31,10 +30,6 @@ describe Gitlab::LDAP::User do
   end
 
   describe '#initialize' do
-    before do
-      expect(::EE::Gitlab::LDAP::Sync::Proxy).to receive(:open).with(auth_hash.provider).and_yield(fake_proxy)
-    end
-
     context 'when the user is in an external group' do
       let(:external_groups) { [group_cn] }
 

spec/lib/gitlab/ldap/user_spec.rb

@@ -26,6 +26,7 @@ describe Gitlab::LDAP::User do
   let(:auth_hash_upper_case) do
     OmniAuth::AuthHash.new(uid: 'my-uid', provider: 'ldapmain', info: info_upper_case)
   end
+  let!(:fake_proxy) { fake_ldap_sync_proxy('ldapmain') }
 
   describe '#changed?' do
     it "marks existing ldap user as changed" do

spec/support/ldap_helpers.rb

@@ -5,6 +5,12 @@ module LdapHelpers
     ::Gitlab::LDAP::Adapter.new(provider, ldap)
   end
 
+  def fake_ldap_sync_proxy(provider)
+    fake_proxy = double(:proxy, adapter: ldap_adapter)
+    allow(::EE::Gitlab::LDAP::Sync::Proxy).to receive(:open).with(provider).and_yield(fake_proxy)
+    fake_proxy
+  end
+
   def user_dn(uid)
     "uid=#{uid},ou=users,dc=example,dc=com"
   end