Commit a82f4206 authored by Kushal Pandya's avatar Kushal Pandya

Merge branch 'Remove-createIssues-function-logic-from-list-model' into 'master'

Remove createissues logic from list model

See merge request gitlab-org/gitlab!32236
parents db268005 289dfc0e
/* eslint-disable no-underscore-dangle, class-methods-use-this */ /* eslint-disable no-underscore-dangle, class-methods-use-this */
import ListIssue from 'ee_else_ce/boards/models/issue';
import { __ } from '~/locale'; import { __ } from '~/locale';
import ListLabel from './label'; import ListLabel from './label';
import ListAssignee from './assignee'; import ListAssignee from './assignee';
import flash from '~/flash'; import flash from '~/flash';
import boardsStore from '../stores/boards_store'; import boardsStore from '../stores/boards_store';
import ListMilestone from './milestone'; import ListMilestone from './milestone';
import 'ee_else_ce/boards/models/issue';
const TYPES = { const TYPES = {
backlog: { backlog: {
...@@ -100,12 +99,6 @@ class List { ...@@ -100,12 +99,6 @@ class List {
return boardsStore.newListIssue(this, issue); return boardsStore.newListIssue(this, issue);
} }
createIssues(data) {
data.forEach(issueObj => {
this.addIssue(new ListIssue(issueObj));
});
}
addMultipleIssues(issues, listFrom, newIndex) { addMultipleIssues(issues, listFrom, newIndex) {
boardsStore.addMultipleListIssues(this, issues, listFrom, newIndex); boardsStore.addMultipleListIssues(this, issues, listFrom, newIndex);
} }
......
/* eslint-disable no-shadow, no-param-reassign,consistent-return */ /* eslint-disable no-shadow, no-param-reassign,consistent-return */
/* global List */ /* global List */
/* global ListIssue */
import $ from 'jquery'; import $ from 'jquery';
import { sortBy } from 'lodash'; import { sortBy } from 'lodash';
import Vue from 'vue'; import Vue from 'vue';
...@@ -641,7 +641,9 @@ const boardsStore = { ...@@ -641,7 +641,9 @@ const boardsStore = {
list.issues = []; list.issues = [];
} }
list.createIssues(data.issues); data.issues.forEach(issueObj => {
list.addIssue(new ListIssue(issueObj));
});
return data; return data;
}); });
......
---
title: Remove createIssues logic from list model
merge_request: 32236
author: nuwe1
type: other
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment