Commit a8ca1d50 authored by Rémy Coutable's avatar Rémy Coutable

Merge branch 'fix/12652-omniauth-import-from-gitlab-com-fails' into 'master'

Fix import from gitlab.com fails

_Originally opened at !2896 by @kazsw._

- - -

Fixes #12652

CGI.escape encodes '/' by default.
Second argument can be removed.

See merge request !2988
parent 1c3d8aae
...@@ -6,6 +6,7 @@ v 8.5.2 ...@@ -6,6 +6,7 @@ v 8.5.2
- Bring the "branded appearance" feature from EE to CE - Bring the "branded appearance" feature from EE to CE
- Fix error 500 when commenting on a commit - Fix error 500 when commenting on a commit
- Fix broken icons on installations with relative URL (Artem Sidorenko) - Fix broken icons on installations with relative URL (Artem Sidorenko)
- Fix import from gitlab.com (KazSawada)
- Improve implementation to check read access to forks and add pagination - Improve implementation to check read access to forks and add pagination
- Don't show any "2FA required" message if it's not actually required - Don't show any "2FA required" message if it's not actually required
- Fix help keyboard shortcut on relative URL setups (Artem Sidorenko) - Fix help keyboard shortcut on relative URL setups (Artem Sidorenko)
...@@ -24,7 +25,7 @@ v 8.5.1 ...@@ -24,7 +25,7 @@ v 8.5.1
- Fix error 500 when trying to mark an already done todo as "done" - Fix error 500 when trying to mark an already done todo as "done"
- Fix an issue where MRs weren't sortable - Fix an issue where MRs weren't sortable
- Issues can now be dragged & dropped into empty milestone lists. This is also - Issues can now be dragged & dropped into empty milestone lists. This is also
possible with MRs possible with MRs
- Changed padding & background color for highlighted notes - Changed padding & background color for highlighted notes
- Re-add the newrelic_rpm gem which was removed without any deprecation or warning (Stan Hu) - Re-add the newrelic_rpm gem which was removed without any deprecation or warning (Stan Hu)
- Update sentry-raven gem to 0.15.6 - Update sentry-raven gem to 0.15.6
......
...@@ -12,7 +12,7 @@ module Gitlab ...@@ -12,7 +12,7 @@ module Gitlab
end end
def execute def execute
project_identifier = CGI.escape(project.import_source, '/') project_identifier = CGI.escape(project.import_source)
#Issues && Comments #Issues && Comments
issues = client.issues(project_identifier) issues = client.issues(project_identifier)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment