Merge branch 'georgekoltsov/fix-project-export-web-rate-limit' into 'master'

Fix Web Project Export Download rate limiting scope

See merge request gitlab-org/gitlab!55975

app/controllers/projects_controller.rb

@@ -521,7 +521,7 @@ class ProjectsController < Projects::ApplicationController
   def export_rate_limit
     prefixed_action = "project_#{params[:action]}".to_sym
 
-    project_scope = params[:action] == :download_export ? @project : nil
+    project_scope = params[:action] == 'download_export' ? @project : nil
 
     if rate_limiter.throttled?(prefixed_action, scope: [current_user, project_scope].compact)
       rate_limiter.log_request(request, "#{prefixed_action}_request_limit".to_sym, current_user)

changelogs/unreleased/georgekoltsov-fix-project-export-web-rate-limit.yml

+---
+title: Fix Web Project Export rate limiting scope
+merge_request: 55975
+author:
+type: fixed

spec/controllers/projects_controller_spec.rb

@@ -1362,6 +1362,14 @@ RSpec.describe ProjectsController do
             expect(response.body).to eq('This endpoint has been requested too many times. Try again later.')
             expect(response).to have_gitlab_http_status(:too_many_requests)
           end
+
+          it 'applies correct scope when throttling' do
+            expect(Gitlab::ApplicationRateLimiter)
+              .to receive(:throttled?)
+              .with(:project_download_export, scope: [user, project])
+
+            post action, params: { namespace_id: project.namespace, id: project }
+          end
         end
       end
     end