Merge branch 'lm-change-headers-ops-settings' into 'master'

Updates headers in ops settings page

See merge request gitlab-org/gitlab!25641

app/assets/javascripts/grafana_integration/components/grafana_integration.vue

@@ -55,9 +55,9 @@ export default {
 <template>
   <section id="grafana" class="settings no-animate js-grafana-integration">
     <div class="settings-header">
-      <h4 class="js-section-header">
+      <h3 class="js-section-header h4">
         {{ s__('GrafanaIntegration|Grafana Authentication') }}
-      </h4>
+      </h3>
       <gl-button class="js-settings-toggle">{{ __('Expand') }}</gl-button>
       <p class="js-section-sub-header">
         {{ s__('GrafanaIntegration|Embed Grafana charts in GitLab issues.') }}

app/assets/javascripts/operation_settings/components/external_dashboard.vue

@@ -33,9 +33,9 @@ export default {
 <template>
   <section class="settings no-animate">
     <div class="settings-header">
-      <h4 class="js-section-header">
+      <h3 class="js-section-header h4">
         {{ s__('ExternalMetrics|External Dashboard') }}
-      </h4>
+      </h3>
       <gl-button class="js-settings-toggle">{{ __('Expand') }}</gl-button>
       <p class="js-section-sub-header">
         {{

app/views/projects/settings/operations/_error_tracking.html.haml

@@ -4,7 +4,7 @@
 
 %section.settings.no-animate.js-error-tracking-settings
   .settings-header
-    %h4
+    %h3{ :class => "h4" }
       = _('Error Tracking')
     %button.btn.js-settings-toggle{ type: 'button' }
       = _('Expand')

app/views/projects/settings/operations/_incidents.html.haml

@@ -4,7 +4,7 @@
 
 %section.settings.no-animate.qa-incident-management-settings
   .settings-header
-    %h4= _('Incidents')
+    %h3{ :class => "h4" }= _('Incidents')
     %button.btn.js-settings-toggle{ type: 'button' }
       = _('Expand')
     %p

ee/app/views/projects/settings/operations/_tracing.html.haml

@@ -5,7 +5,7 @@
 
 %section.settings.border-0.no-animate
   .settings-header{ :class => "border-top" }
-    %h4
+    %h3{ :class => "h4" }
       = _("Jaeger tracing")
     %button.btn.js-settings-toggle{ type: 'button' }
       = _('Expand')

spec/features/projects/settings/operations_settings_spec.rb

@@ -35,7 +35,7 @@ describe 'Projects > Settings > For a forked project', :js do
       end
 
       it 'renders form for incident management' do
-        expect(page).to have_selector('h4', text: 'Incidents')
+        expect(page).to have_selector('h3', text: 'Incidents')
       end
 
       it 'sets correct default values' do

spec/frontend/grafana_integration/components/__snapshots__/grafana_integration_spec.js.snap

@@ -8,13 +8,13 @@ exports[`grafana integration component default state to match the default snapsh
   <div
     class="settings-header"
   >
-    <h4
-      class="js-section-header"
+    <h3
+      class="js-section-header h4"
     >
       
       Grafana Authentication
     
-    </h4>
+    </h3>
      
     <gl-button-stub
       class="js-settings-toggle"