Merge branch 'pl-enable-cop-code-reuse-worker' into 'master'

Enable cop CodeReuse/Worker

See merge request gitlab-org/gitlab!25136

app/controllers/admin/application_settings_controller.rb

@@ -56,7 +56,7 @@ class Admin::ApplicationSettingsController < Admin::ApplicationController
   end
 
   def clear_repository_check_states
-    RepositoryCheck::ClearWorker.perform_async
+    RepositoryCheck::ClearWorker.perform_async # rubocop:disable CodeReuse/Worker
 
     redirect_to(
       general_admin_application_settings_path,
@@ -73,7 +73,7 @@ class Admin::ApplicationSettingsController < Admin::ApplicationController
 
   # Specs are in spec/requests/self_monitoring_project_spec.rb
   def create_self_monitoring_project
-    job_id = SelfMonitoringProjectCreateWorker.perform_async
+    job_id = SelfMonitoringProjectCreateWorker.perform_async # rubocop:disable CodeReuse/Worker
 
     render status: :accepted, json: {
       job_id: job_id,
@@ -92,7 +92,7 @@ class Admin::ApplicationSettingsController < Admin::ApplicationController
       }
     end
 
-    if SelfMonitoringProjectCreateWorker.in_progress?(job_id)
+    if SelfMonitoringProjectCreateWorker.in_progress?(job_id) # rubocop:disable CodeReuse/Worker
       ::Gitlab::PollingInterval.set_header(response, interval: 3_000)
 
       return render status: :accepted, json: {
@@ -112,7 +112,7 @@ class Admin::ApplicationSettingsController < Admin::ApplicationController
 
   # Specs are in spec/requests/self_monitoring_project_spec.rb
   def delete_self_monitoring_project
-    job_id = SelfMonitoringProjectDeleteWorker.perform_async
+    job_id = SelfMonitoringProjectDeleteWorker.perform_async # rubocop:disable CodeReuse/Worker
 
     render status: :accepted, json: {
       job_id: job_id,
@@ -131,7 +131,7 @@ class Admin::ApplicationSettingsController < Admin::ApplicationController
       }
     end
 
-    if SelfMonitoringProjectDeleteWorker.in_progress?(job_id)
+    if SelfMonitoringProjectDeleteWorker.in_progress?(job_id) # rubocop:disable CodeReuse/Worker
       ::Gitlab::PollingInterval.set_header(response, interval: 3_000)
 
       return render status: :accepted, json: {

app/controllers/admin/projects_controller.rb

@@ -55,7 +55,7 @@ class Admin::ProjectsController < Admin::ApplicationController
   # rubocop: enable CodeReuse/ActiveRecord
 
   def repository_check
-    RepositoryCheck::SingleRepositoryWorker.perform_async(@project.id)
+    RepositoryCheck::SingleRepositoryWorker.perform_async(@project.id) # rubocop:disable CodeReuse/Worker
 
     redirect_to(
       admin_project_path(@project),

app/controllers/admin/services_controller.rb

@@ -19,7 +19,7 @@ class Admin::ServicesController < Admin::ApplicationController
 
   def update
     if service.update(service_params[:service])
-      PropagateServiceTemplateWorker.perform_async(service.id) if service.active?
+      PropagateServiceTemplateWorker.perform_async(service.id) if service.active? # rubocop:disable CodeReuse/Worker
 
       redirect_to admin_application_settings_services_path,
         notice: 'Application settings saved successfully'

app/controllers/projects/issues_controller.rb

@@ -188,7 +188,7 @@ class Projects::IssuesController < Projects::ApplicationController
 
   def import_csv
     if uploader = UploadService.new(project, params[:file]).execute
-      ImportIssuesCsvWorker.perform_async(current_user.id, project.id, uploader.upload.id)
+      ImportIssuesCsvWorker.perform_async(current_user.id, project.id, uploader.upload.id) # rubocop:disable CodeReuse/Worker
 
       flash[:notice] = _("Your issues are being imported. Once finished, you'll get a confirmation email.")
     else

app/controllers/projects/pipeline_schedules_controller.rb

@@ -47,7 +47,7 @@ class Projects::PipelineSchedulesController < Projects::ApplicationController
   end
 
   def play
-    job_id = RunPipelineScheduleWorker.perform_async(schedule.id, current_user.id)
+    job_id = RunPipelineScheduleWorker.perform_async(schedule.id, current_user.id) # rubocop:disable CodeReuse/Worker
 
     if job_id
       pipelines_link_start = "<a href=\"#{project_pipelines_path(@project)}\">"

app/controllers/projects/registry/repositories_controller.rb

@@ -32,7 +32,7 @@ module Projects
       end
 
       def destroy
-        DeleteContainerRepositoryWorker.perform_async(current_user.id, image.id)
+        DeleteContainerRepositoryWorker.perform_async(current_user.id, image.id) # rubocop:disable CodeReuse/Worker
         track_event(:delete_repository)
 
         respond_to do |format|

app/controllers/projects/settings/ci_cd_controller.rb

@@ -69,7 +69,9 @@ module Projects
           return
         end
 
+        # rubocop:disable CodeReuse/Worker
         CreatePipelineWorker.perform_async(project.id, current_user.id, project.default_branch, :web, ignore_skip_ci: true, save_on_errors: false)
+        # rubocop:enable CodeReuse/Worker
 
         pipelines_link_start = '<a href="%{url}">'.html_safe % { url: project_pipelines_path(@project) }
         flash[:toast] = _("A new Auto DevOps pipeline has been created, go to %{pipelines_link_start}Pipelines page%{pipelines_link_end} for details") % { pipelines_link_start: pipelines_link_start, pipelines_link_end: "</a>".html_safe }

app/controllers/projects/settings/repository_controller.rb

@@ -25,7 +25,7 @@ module Projects
         result = Projects::UpdateService.new(project, current_user, cleanup_params).execute
 
         if result[:status] == :success
-          RepositoryCleanupWorker.perform_async(project.id, current_user.id)
+          RepositoryCleanupWorker.perform_async(project.id, current_user.id) # rubocop:disable CodeReuse/Worker
           flash[:notice] = _('Repository cleanup has started. You will receive an email once the cleanup operation is complete.')
         else
           flash[:alert] = _('Failed to upload object map file')

app/controllers/repositories/git_http_controller.rb

@@ -80,7 +80,7 @@ module Repositories
       return unless repo_type.project?
       return unless project&.daily_statistics_enabled?
 
-      ProjectDailyStatisticsWorker.perform_async(project.id)
+      ProjectDailyStatisticsWorker.perform_async(project.id) # rubocop:disable CodeReuse/Worker
     end
 
     def access

ee/app/controllers/admin/emails_controller.rb

@@ -5,7 +5,7 @@ class Admin::EmailsController < Admin::ApplicationController
   end
 
   def create
-    AdminEmailsWorker.perform_async(params[:recipients], params[:subject], params[:body])
+    AdminEmailsWorker.perform_async(params[:recipients], params[:subject], params[:body]) # rubocop:disable CodeReuse/Worker
     redirect_to admin_email_path, notice: 'Email sent'
   end
 end

ee/app/controllers/admin/geo/projects_controller.rb

@@ -58,14 +58,14 @@ class Admin::Geo::ProjectsController < Admin::Geo::ApplicationController
   end
 
   def reverify_all
-    Geo::Batch::ProjectRegistrySchedulerWorker.perform_async(:reverify_repositories)
+    Geo::Batch::ProjectRegistrySchedulerWorker.perform_async(:reverify_repositories) # rubocop:disable CodeReuse/Worker
 
     flash[:toast] = s_('Geo|All projects are being scheduled for re-verify')
     redirect_back_or_default(default: admin_geo_projects_path)
   end
 
   def resync_all
-    Geo::Batch::ProjectRegistrySchedulerWorker.perform_async(:resync_repositories)
+    Geo::Batch::ProjectRegistrySchedulerWorker.perform_async(:resync_repositories) # rubocop:disable CodeReuse/Worker
 
     flash[:toast] = s_('Geo|All projects are being scheduled for re-sync')
     redirect_back_or_default(default: admin_geo_projects_path)

ee/app/controllers/groups/ldaps_controller.rb

@@ -12,7 +12,7 @@ class Groups::LdapsController < Groups::ApplicationController
     # likely the group will never transition out of its current state,
     # so we should tell the group owner.
     if @group.pending_ldap_sync
-      LdapGroupSyncWorker.perform_async(@group.id)
+      LdapGroupSyncWorker.perform_async(@group.id) # rubocop:disable CodeReuse/Worker
       message = 'The group sync has been scheduled'
     elsif @group.valid?
       message = 'The group sync is already scheduled'

ee/app/models/elasticsearch_indexed_namespace.rb

@@ -41,7 +41,7 @@ class ElasticsearchIndexedNamespace < ApplicationRecord
 
       jobs = batch_ids.map { |id| [id, :index] }
 
-      ElasticNamespaceIndexerWorker.bulk_perform_async(jobs) # rubocop:disable Scalability/BulkPerformWithContext
+      ElasticNamespaceIndexerWorker.bulk_perform_async(jobs) # rubocop:disable Scalability/BulkPerformWithContext, CodeReuse/Worker
     end
   end
 
@@ -58,7 +58,7 @@ class ElasticsearchIndexedNamespace < ApplicationRecord
 
       jobs = batch_ids.map { |id| [id, :delete] }
 
-      ElasticNamespaceIndexerWorker.bulk_perform_async(jobs) # rubocop:disable Scalability/BulkPerformWithContext
+      ElasticNamespaceIndexerWorker.bulk_perform_async(jobs) # rubocop:disable Scalability/BulkPerformWithContext, CodeReuse/Worker
     end
   end
 

ee/app/models/geo_node_status.rb

@@ -127,7 +127,7 @@ class GeoNodeStatus < ApplicationRecord
   end
 
   def self.spawn_worker
-    ::Geo::MetricsUpdateWorker.perform_async
+    ::Geo::MetricsUpdateWorker.perform_async # rubocop:disable CodeReuse/Worker
   end
 
   def self.cache_key

ee/lib/api/elasticsearch_indexed_namespaces.rb

@@ -21,7 +21,7 @@ module API
         requires :plan, type: String, values: Plan::ALL_HOSTED_PLANS
       end
       put 'rollout' do
-        ElasticNamespaceRolloutWorker.perform_async(params[:plan], params[:percentage], ElasticNamespaceRolloutWorker::ROLLOUT)
+        ElasticNamespaceRolloutWorker.perform_async(params[:plan], params[:percentage], ElasticNamespaceRolloutWorker::ROLLOUT) # rubocop:disable CodeReuse/Worker
       end
 
       desc 'Rollback namespaces to be indexed down to n%' do
@@ -38,7 +38,7 @@ module API
         requires :plan, type: String, values: Plan::ALL_HOSTED_PLANS
       end
       put 'rollback' do
-        ElasticNamespaceRolloutWorker.perform_async(params[:plan], params[:percentage], ElasticNamespaceRolloutWorker::ROLLBACK)
+        ElasticNamespaceRolloutWorker.perform_async(params[:plan], params[:percentage], ElasticNamespaceRolloutWorker::ROLLBACK) # rubocop:disable CodeReuse/Worker
       end
     end
   end

ee/lib/api/nuget_packages.rb

@@ -129,7 +129,7 @@ module API
 
           track_event('push_package')
 
-          ::Packages::Nuget::ExtractionWorker.perform_async(package_file.id)
+          ::Packages::Nuget::ExtractionWorker.perform_async(package_file.id) # rubocop:disable CodeReuse/Worker
 
           created!
         rescue ObjectStorage::RemoteStoreError => e

lib/api/group_export.rb

@@ -27,7 +27,7 @@ module API
         detail 'This feature was introduced in GitLab 12.5.'
       end
       post ':id/export' do
-        GroupExportWorker.perform_async(current_user.id, user_group.id, params)
+        GroupExportWorker.perform_async(current_user.id, user_group.id, params) # rubocop:disable CodeReuse/Worker
 
         accepted!
       end

lib/api/group_import.rb

@@ -76,7 +76,7 @@ module API
         group = ::Groups::CreateService.new(current_user, group_params).execute
 
         if group.persisted?
-          GroupImportWorker.perform_async(current_user.id, group.id)
+          GroupImportWorker.perform_async(current_user.id, group.id) # rubocop:disable CodeReuse/Worker
 
           accepted!
         else

lib/api/pipeline_schedules.rb

@@ -120,7 +120,7 @@ module API
       post ':id/pipeline_schedules/:pipeline_schedule_id/play' do
         authorize! :play_pipeline_schedule, pipeline_schedule
 
-        job_id = RunPipelineScheduleWorker
+        job_id = RunPipelineScheduleWorker # rubocop:disable CodeReuse/Worker
           .perform_async(pipeline_schedule.id, current_user.id)
 
         if job_id

lib/api/project_container_repositories.rb

@@ -41,7 +41,7 @@ module API
       delete ':id/registry/repositories/:repository_id', requirements: REPOSITORY_ENDPOINT_REQUIREMENTS do
         authorize_admin_container_image!
 
-        DeleteContainerRepositoryWorker.perform_async(current_user.id, repository.id)
+        DeleteContainerRepositoryWorker.perform_async(current_user.id, repository.id) # rubocop:disable CodeReuse/Worker
         track_event('delete_repository')
 
         status :accepted
@@ -79,8 +79,10 @@ module API
         message = 'This request has already been made. You can run this at most once an hour for a given container repository'
         render_api_error!(message, 400) unless obtain_new_cleanup_container_lease
 
+        # rubocop:disable CodeReuse/Worker
         CleanupContainerRepositoryWorker.perform_async(current_user.id, repository.id,
           declared_params.except(:repository_id).merge(container_expiration_policy: false))
+        # rubocop:enable CodeReuse/Worker
 
         track_event('delete_tag_bulk')
 

lib/api/releases.rb

@@ -170,9 +170,9 @@ module API
         return if release.historical_release?
 
         if release.upcoming_release?
-          CreateEvidenceWorker.perform_at(release.released_at, release.id)
+          CreateEvidenceWorker.perform_at(release.released_at, release.id) # rubocop:disable CodeReuse/Worker
         else
-          CreateEvidenceWorker.perform_async(release.id)
+          CreateEvidenceWorker.perform_async(release.id) # rubocop:disable CodeReuse/Worker
         end
       end
     end

rubocop/rubocop.rb

@@ -55,6 +55,7 @@ require_relative 'cop/code_reuse/service_class'
 require_relative 'cop/code_reuse/presenter'
 require_relative 'cop/code_reuse/serializer'
 require_relative 'cop/code_reuse/active_record'
+require_relative 'cop/code_reuse/worker'
 require_relative 'cop/group_public_or_visible_to_user'
 require_relative 'cop/inject_enterprise_edition_module'
 require_relative 'cop/graphql/authorize_types'