Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
a9e8a903
Commit
a9e8a903
authored
Sep 07, 2020
by
Phil Calder
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove feature flag buy_ci_minutes_version_a
parent
e06ee9c3
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
1 addition
and
14 deletions
+1
-14
ee/app/helpers/ee/ci/runners_helper.rb
ee/app/helpers/ee/ci/runners_helper.rb
+1
-1
ee/spec/helpers/ee/ci/runners_helper_spec.rb
ee/spec/helpers/ee/ci/runners_helper_spec.rb
+0
-10
lib/gitlab/experimentation.rb
lib/gitlab/experimentation.rb
+0
-3
No files found.
ee/app/helpers/ee/ci/runners_helper.rb
View file @
a9e8a903
...
...
@@ -7,7 +7,7 @@ module EE
BUY_PIPELINE_MINUTES_NOTIFICATION_DOT
=
'buy_pipeline_minutes_notification_dot'
def
show_buy_pipeline_minutes?
(
project
,
namespace
)
return
false
unless
experiment_enabled?
(
:ci_notification_dot
)
||
experiment_enabled?
(
:buy_ci_minutes_version_a
)
return
false
unless
experiment_enabled?
(
:ci_notification_dot
)
show_out_of_pipeline_minutes_notification?
(
project
,
namespace
)
end
...
...
ee/spec/helpers/ee/ci/runners_helper_spec.rb
View file @
a9e8a903
...
...
@@ -91,16 +91,6 @@ RSpec.describe EE::Ci::RunnersHelper do
it_behaves_like
'minutes notification'
do
before
do
allow
(
helper
).
to
receive
(
:experiment_enabled?
).
with
(
:ci_notification_dot
).
and_return
(
experiment_status
)
allow
(
helper
).
to
receive
(
:experiment_enabled?
).
with
(
:buy_ci_minutes_version_a
).
and_return
(
false
)
end
end
end
context
'when experiment is "ci_minutes_version_a"'
do
it_behaves_like
'minutes notification'
do
before
do
allow
(
helper
).
to
receive
(
:experiment_enabled?
).
with
(
:ci_notification_dot
).
and_return
(
false
)
allow
(
helper
).
to
receive
(
:experiment_enabled?
).
with
(
:buy_ci_minutes_version_a
).
and_return
(
experiment_status
)
end
end
end
...
...
lib/gitlab/experimentation.rb
View file @
a9e8a903
...
...
@@ -42,9 +42,6 @@ module Gitlab
ci_notification_dot:
{
tracking_category:
'Growth::Expansion::Experiment::CiNotificationDot'
},
buy_ci_minutes_version_a:
{
tracking_category:
'Growth::Expansion::Experiment::BuyCiMinutesVersionA'
},
upgrade_link_in_user_menu_a:
{
tracking_category:
'Growth::Expansion::Experiment::UpgradeLinkInUserMenuA'
},
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment