Add more validations and update specs for maven package feature

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

ee/app/finders/packages/maven_package_finder.rb

+# frozen_string_literal: true
 class Packages::MavenPackageFinder
   attr_reader :project, :path
 

ee/app/models/packages/maven_metadatum.rb

@@ -3,4 +3,7 @@ class Packages::MavenMetadatum < ActiveRecord::Base
   belongs_to :package
 
   validates :package, presence: true
+  validates :path, presence: true
+  validates :app_group, presence: true
+  validates :app_name, presence: true
 end

ee/app/models/packages/package.rb

@@ -5,4 +5,5 @@ class Packages::Package < ActiveRecord::Base
   has_one :maven_metadatum
 
   validates :project, presence: true
+  validates :name, presence: true
 end

ee/app/services/packages/create_package_file_service.rb

+# frozen_string_literal: true
 class Packages::CreatePackageFileService
   attr_reader :package, :params
 

ee/spec/factories/packages.rb

@@ -43,8 +43,9 @@ FactoryBot.define do
 
   factory :maven_metadatum, class: Packages::MavenMetadatum do
     package
-    app_group 'my/company/app'
+    path 'my/company/app/my-app/1.0-SNAPSHOT'
+    app_group 'my.company.app'
     app_name 'my-app'
-    app_version '1-0-SNAPSHOT'
+    app_version '1.0-SNAPSHOT'
   end
 end

ee/spec/requests/api/maven_packages_spec.rb

@@ -13,7 +13,7 @@ describe API::MavenPackages do
     project.add_developer(user)
   end
 
-  describe 'GET /api/v4/projects/:id/packages/maven/*app_group/:app_name/:app_version/:file_name' do
+  describe 'GET /api/v4/projects/:id/packages/maven/*path/:file_name' do
     let(:package) { create(:maven_package, project: project) }
     let(:maven_metadatum) { package.maven_metadatum }
     let(:package_file_xml) { package.package_files.find_by(file_type: 'xml') }
@@ -64,8 +64,7 @@ describe API::MavenPackages do
 
     def download_file(file_name, params = {}, request_headers = headers)
       get api("/projects/#{project.id}/packages/maven/" \
-              "#{maven_metadatum.app_group}/#{maven_metadatum.app_name}/" \
-              "#{maven_metadatum.app_version}/#{file_name}"), params, request_headers
+              "#{maven_metadatum.path}/#{file_name}"), params, request_headers
     end
 
     def download_file_with_token(file_name, params = {}, request_headers = headers_with_token)
@@ -73,7 +72,7 @@ describe API::MavenPackages do
     end
   end
 
-  describe 'PUT /api/v4/projects/:id/packages/maven/*app_group/:app_name/:app_version/:file_name/authorize' do
+  describe 'PUT /api/v4/projects/:id/packages/maven/*path/:file_name/authorize' do
     it 'authorizes posting package with a valid token' do
       authorize_upload_with_token
 
@@ -115,7 +114,7 @@ describe API::MavenPackages do
     end
   end
 
-  describe 'PUT /api/v4/projects/:id/packages/maven/*app_group/:app_name/:app_version/:file_name' do
+  describe 'PUT /api/v4/projects/:id/packages/maven/*path/:file_name' do
     let(:file_upload) { fixture_file_upload('ee/spec/fixtures/maven/maven-metadata.xml') }
 
     before do