Merge branch 'nfriend-enable-graphql_release_data-feature-flag' into 'master'

Enable the `graphql_release_data` feature flag by default

See merge request gitlab-org/gitlab!34937

app/graphql/resolvers/release_resolver.rb

@@ -15,6 +15,8 @@ module Resolvers
     end
 
     def resolve(tag_name:)
+      return unless Feature.enabled?(:graphql_release_data, project, default_enabled: true)
+
       ReleasesFinder.new(
         project,
         current_user,

app/graphql/resolvers/releases_resolver.rb

@@ -12,6 +12,8 @@ module Resolvers
     end
 
     def resolve(**args)
+      return unless Feature.enabled?(:graphql_release_data, project, default_enabled: true)
+
       ReleasesFinder.new(
         project,
         current_user

app/graphql/types/project_type.rb

@@ -243,15 +243,13 @@ module Types
           Types::ReleaseType.connection_type,
           null: true,
           description: 'Releases of the project',
-          resolver: Resolvers::ReleasesResolver,
-          feature_flag: :graphql_release_data
+          resolver: Resolvers::ReleasesResolver
 
     field :release,
           Types::ReleaseType,
           null: true,
           description: 'A single release of the project',
           resolver: Resolvers::ReleasesResolver.single,
-          feature_flag: :graphql_release_data,
           authorize: :download_code
 
     field :container_expiration_policy,

changelogs/unreleased/nfriend-enable-graphql_release_data-feature-flag.yml

+---
+title: Add release data to GraphQL endpoint
+merge_request: 34937
+author:
+type: added

doc/api/graphql/reference/gitlab_schema.graphql

@@ -9289,7 +9289,7 @@ type Project {
   publicJobs: Boolean
 
   """
-  A single release of the project. Available only when feature flag `graphql_release_data` is enabled
+  A single release of the project
   """
   release(
     """
@@ -9299,7 +9299,7 @@ type Project {
   ): Release
 
   """
-  Releases of the project. Available only when feature flag `graphql_release_data` is enabled
+  Releases of the project
   """
   releases(
     """

doc/api/graphql/reference/gitlab_schema.json

@@ -27364,7 +27364,7 @@
             },
             {
               "name": "release",
-              "description": "A single release of the project. Available only when feature flag `graphql_release_data` is enabled",
+              "description": "A single release of the project",
               "args": [
                 {
                   "name": "tagName",
@@ -27391,7 +27391,7 @@
             },
             {
               "name": "releases",
-              "description": "Releases of the project. Available only when feature flag `graphql_release_data` is enabled",
+              "description": "Releases of the project",
               "args": [
                 {
                   "name": "after",

doc/api/graphql/reference/index.md

@@ -1353,7 +1353,7 @@ Information about pagination in a connection.
 | `pipeline` | Pipeline | Build pipeline of the project |
 | `printingMergeRequestLinkEnabled` | Boolean | Indicates if a link to create or view a merge request should display after a push to Git repositories of the project from the command line |
 | `publicJobs` | Boolean | Indicates if there is public access to pipelines and job details of the project, including output logs and artifacts |
-| `release` | Release | A single release of the project. Available only when feature flag `graphql_release_data` is enabled |
+| `release` | Release | A single release of the project |
 | `removeSourceBranchAfterMerge` | Boolean | Indicates if `Delete source branch` option should be enabled by default for all new merge requests of the project |
 | `repository` | Repository | Git repository of the project |
 | `requestAccessEnabled` | Boolean | Indicates if users can request member access to the project |

spec/requests/api/graphql/project/release_spec.rb

@@ -354,4 +354,21 @@ RSpec.describe 'Query.project(fullPath).release(tagName)' do
       end
     end
   end
+
+  describe 'ensures that the release data can be contolled by a feature flag' do
+    context 'when the graphql_release_data feature flag is disabled' do
+      let_it_be(:project) { create(:project, :repository, :public) }
+      let_it_be(:release) { create(:release, project: project) }
+
+      let(:current_user) { developer }
+
+      before do
+        stub_feature_flags(graphql_release_data: false)
+
+        project.add_developer(developer)
+      end
+
+      it_behaves_like 'no access to the release field'
+    end
+  end
 end

spec/requests/api/graphql/project/releases_spec.rb

@@ -264,4 +264,21 @@ describe 'Query.project(fullPath).releases()' do
       end
     end
   end
+
+  describe 'ensures that the release data can be contolled by a feature flag' do
+    context 'when the graphql_release_data feature flag is disabled' do
+      let_it_be(:project) { create(:project, :repository, :public) }
+      let_it_be(:release) { create(:release, project: project) }
+
+      let(:current_user) { developer }
+
+      before do
+        stub_feature_flags(graphql_release_data: false)
+
+        project.add_developer(developer)
+      end
+
+      it_behaves_like 'no access to any release data'
+    end
+  end
 end