Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
afb1ef14
Commit
afb1ef14
authored
Sep 08, 2017
by
Sean McGivern
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Resolve boards backend conflicts
parent
a859ce0c
Changes
10
Hide whitespace changes
Inline
Side-by-side
Showing
10 changed files
with
1 addition
and
39 deletions
+1
-39
app/controllers/boards/lists_controller.rb
app/controllers/boards/lists_controller.rb
+0
-3
app/controllers/projects/boards_controller.rb
app/controllers/projects/boards_controller.rb
+0
-3
app/models/board.rb
app/models/board.rb
+0
-8
app/services/boards/create_service.rb
app/services/boards/create_service.rb
+0
-3
app/services/boards/issues/list_service.rb
app/services/boards/issues/list_service.rb
+0
-3
app/services/boards/issues/move_service.rb
app/services/boards/issues/move_service.rb
+0
-3
app/services/boards/list_service.rb
app/services/boards/list_service.rb
+0
-3
app/services/boards/lists/create_service.rb
app/services/boards/lists/create_service.rb
+0
-3
app/services/issues/update_service.rb
app/services/issues/update_service.rb
+0
-10
ee/app/models/ee/board.rb
ee/app/models/ee/board.rb
+1
-0
No files found.
app/controllers/boards/lists_controller.rb
View file @
afb1ef14
module
Boards
module
Boards
class
ListsController
<
Boards
::
ApplicationController
class
ListsController
<
Boards
::
ApplicationController
<<<<<<<
HEAD
prepend
EE
::
BoardsResponses
prepend
EE
::
BoardsResponses
=======
>>>>>>>
upstream
/
master
include
BoardsResponses
include
BoardsResponses
before_action
:authorize_admin_list
,
only:
[
:create
,
:update
,
:destroy
,
:generate
]
before_action
:authorize_admin_list
,
only:
[
:create
,
:update
,
:destroy
,
:generate
]
...
...
app/controllers/projects/boards_controller.rb
View file @
afb1ef14
class
Projects::BoardsController
<
Projects
::
ApplicationController
class
Projects::BoardsController
<
Projects
::
ApplicationController
<<<<<<<
HEAD
prepend
EE
::
Boards
::
BoardsController
prepend
EE
::
Boards
::
BoardsController
prepend
EE
::
BoardsResponses
prepend
EE
::
BoardsResponses
=======
>>>>>>>
upstream
/
master
include
BoardsResponses
include
BoardsResponses
include
IssuableCollections
include
IssuableCollections
...
...
app/models/board.rb
View file @
afb1ef14
...
@@ -5,18 +5,11 @@ class Board < ActiveRecord::Base
...
@@ -5,18 +5,11 @@ class Board < ActiveRecord::Base
has_many
:lists
,
->
{
order
(
:list_type
,
:position
)
},
dependent: :delete_all
# rubocop:disable Cop/ActiveRecordDependent
has_many
:lists
,
->
{
order
(
:list_type
,
:position
)
},
dependent: :delete_all
# rubocop:disable Cop/ActiveRecordDependent
<<<<<<<
HEAD
validates
:name
,
presence:
true
=======
>>>>>>>
upstream
/
master
validates
:project
,
presence:
true
,
if: :project_needed?
validates
:project
,
presence:
true
,
if: :project_needed?
def
project_needed?
def
project_needed?
true
true
end
end
<<<<<<<
HEAD
=======
def
parent
def
parent
project
project
...
@@ -25,7 +18,6 @@ class Board < ActiveRecord::Base
...
@@ -25,7 +18,6 @@ class Board < ActiveRecord::Base
def
group_board?
def
group_board?
false
false
end
end
>>>>>>>
upstream
/
master
def
backlog_list
def
backlog_list
lists
.
merge
(
List
.
backlog
).
take
lists
.
merge
(
List
.
backlog
).
take
...
...
app/services/boards/create_service.rb
View file @
afb1ef14
module
Boards
module
Boards
class
CreateService
<
Boards
::
BaseService
class
CreateService
<
Boards
::
BaseService
<<<<<<<
HEAD
prepend
EE
::
Boards
::
CreateService
prepend
EE
::
Boards
::
CreateService
=======
>>>>>>>
upstream
/
master
def
execute
def
execute
create_board!
if
can_create_board?
create_board!
if
can_create_board?
end
end
...
...
app/services/boards/issues/list_service.rb
View file @
afb1ef14
module
Boards
module
Boards
module
Issues
module
Issues
class
ListService
<
Boards
::
BaseService
class
ListService
<
Boards
::
BaseService
<<<<<<<
HEAD
prepend
EE
::
Boards
::
Issues
::
ListService
prepend
EE
::
Boards
::
Issues
::
ListService
=======
>>>>>>>
upstream
/
master
def
execute
def
execute
issues
=
IssuesFinder
.
new
(
current_user
,
filter_params
).
execute
issues
=
IssuesFinder
.
new
(
current_user
,
filter_params
).
execute
issues
=
without_board_labels
(
issues
)
unless
movable_list?
||
closed_list?
issues
=
without_board_labels
(
issues
)
unless
movable_list?
||
closed_list?
...
...
app/services/boards/issues/move_service.rb
View file @
afb1ef14
module
Boards
module
Boards
module
Issues
module
Issues
class
MoveService
<
Boards
::
BaseService
class
MoveService
<
Boards
::
BaseService
<<<<<<<
HEAD
prepend
EE
::
Boards
::
Issues
::
MoveService
prepend
EE
::
Boards
::
Issues
::
MoveService
=======
>>>>>>>
upstream
/
master
def
execute
(
issue
)
def
execute
(
issue
)
return
false
unless
can?
(
current_user
,
:update_issue
,
issue
)
return
false
unless
can?
(
current_user
,
:update_issue
,
issue
)
return
false
if
issue_params
.
empty?
return
false
if
issue_params
.
empty?
...
...
app/services/boards/list_service.rb
View file @
afb1ef14
module
Boards
module
Boards
class
ListService
<
Boards
::
BaseService
class
ListService
<
Boards
::
BaseService
<<<<<<<
HEAD
prepend
EE
::
Boards
::
ListService
prepend
EE
::
Boards
::
ListService
=======
>>>>>>>
upstream
/
master
def
execute
def
execute
create_board!
if
parent
.
boards
.
empty?
create_board!
if
parent
.
boards
.
empty?
parent
.
boards
parent
.
boards
...
...
app/services/boards/lists/create_service.rb
View file @
afb1ef14
module
Boards
module
Boards
module
Lists
module
Lists
class
CreateService
<
Boards
::
BaseService
class
CreateService
<
Boards
::
BaseService
<<<<<<<
HEAD
prepend
EE
::
Boards
::
Lists
::
CreateService
prepend
EE
::
Boards
::
Lists
::
CreateService
=======
>>>>>>>
upstream
/
master
def
execute
(
board
)
def
execute
(
board
)
List
.
transaction
do
List
.
transaction
do
label
=
available_labels_for
(
board
).
find
(
params
[
:label_id
])
label
=
available_labels_for
(
board
).
find
(
params
[
:label_id
])
...
...
app/services/issues/update_service.rb
View file @
afb1ef14
...
@@ -59,13 +59,8 @@ module Issues
...
@@ -59,13 +59,8 @@ module Issues
after_id
,
before_id
=
params
.
delete
(
:move_between_ids
)
after_id
,
before_id
=
params
.
delete
(
:move_between_ids
)
<<<<<<<
HEAD
issue_before
=
get_issue_if_allowed
(
before_id
)
if
before_id
issue_before
=
get_issue_if_allowed
(
before_id
)
if
before_id
issue_after
=
get_issue_if_allowed
(
after_id
)
if
after_id
issue_after
=
get_issue_if_allowed
(
after_id
)
if
after_id
=======
issue_before
=
get_issue_if_allowed
(
issue
.
project
,
before_id
)
if
before_id
issue_after
=
get_issue_if_allowed
(
issue
.
project
,
after_id
)
if
after_id
>>>>>>>
upstream
/
master
issue
.
move_between
(
issue_before
,
issue_after
)
issue
.
move_between
(
issue_before
,
issue_after
)
end
end
...
@@ -92,13 +87,8 @@ module Issues
...
@@ -92,13 +87,8 @@ module Issues
private
private
<<<<<<<
HEAD
def
get_issue_if_allowed
(
id
)
def
get_issue_if_allowed
(
id
)
issue
=
Issue
.
find
(
id
)
issue
=
Issue
.
find
(
id
)
=======
def
get_issue_if_allowed
(
project
,
id
)
issue
=
project
.
issues
.
find
(
id
)
>>>>>>>
upstream
/
master
issue
if
can?
(
current_user
,
:update_issue
,
issue
)
issue
if
can?
(
current_user
,
:update_issue
,
issue
)
end
end
...
...
ee/app/models/ee/board.rb
View file @
afb1ef14
...
@@ -6,6 +6,7 @@ module EE
...
@@ -6,6 +6,7 @@ module EE
belongs_to
:milestone
belongs_to
:milestone
belongs_to
:group
belongs_to
:group
validates
:name
,
presence:
true
validates
:group
,
presence:
true
,
unless: :project
validates
:group
,
presence:
true
,
unless: :project
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment