Merge branch '212867-clean-up-dependency_list_ui-for-app' into 'master'

Remove feature flag from Dependency List app

See merge request gitlab-org/gitlab!31094

ee/app/assets/javascripts/dependencies/components/app.vue

 <script>
 import { mapActions, mapGetters, mapState } from 'vuex';
 import {
-  GlBadge,
   GlEmptyState,
   GlIcon,
   GlLoadingIcon,
   GlSprintf,
-  GlTab,
-  GlTabs,
   GlLink,
   GlDeprecatedButton,
 } from '@gitlab/ui';
 import { __ } from '~/locale';
-import glFeatureFlagsMixin from '~/vue_shared/mixins/gl_feature_flags_mixin';
 import DependenciesActions from './dependencies_actions.vue';
 import DependencyListIncompleteAlert from './dependency_list_incomplete_alert.vue';
 import DependencyListJobFailedAlert from './dependency_list_job_failed_alert.vue';
@@ -24,20 +20,16 @@ export default {
   name: 'DependenciesApp',
   components: {
     DependenciesActions,
-    GlBadge,
     GlIcon,
     GlEmptyState,
     GlLoadingIcon,
     GlSprintf,
-    GlTab,
-    GlTabs,
     GlLink,
     GlDeprecatedButton,
     DependencyListIncompleteAlert,
     DependencyListJobFailedAlert,
     PaginatedDependenciesTable,
   },
-  mixins: [glFeatureFlagsMixin()],
   props: {
     endpoint: {
       type: String,
@@ -188,36 +180,11 @@ export default {
           </span>
         </p>
       </div>
-      <dependencies-actions
-        v-if="glFeatures.dependencyListUi"
-        class="mt-2"
-        :namespace="currentList"
-      />
+      <dependencies-actions class="mt-2" :namespace="currentList" />
     </header>
 
-    <article v-if="glFeatures.dependencyListUi">
+    <article>
       <paginated-dependencies-table :namespace="currentList" />
     </article>
-
-    <gl-tabs v-else v-model="currentListIndex" content-class="pt-0">
-      <gl-tab
-        v-for="listType in listTypes"
-        :key="listType.namespace"
-        :disabled="isTabDisabled(listType.namespace)"
-      >
-        <template #title>
-          {{ listType.label }}
-          <gl-badge pill :data-qa-selector="qaCountSelector(listType.label)">
-            {{ totals[listType.namespace] }}
-          </gl-badge>
-        </template>
-        <paginated-dependencies-table :namespace="listType.namespace" />
-      </gl-tab>
-      <template #tabs-end>
-        <li class="d-flex align-items-center ml-sm-auto">
-          <dependencies-actions :namespace="currentList" class="my-2 my-sm-0" />
-        </li>
-      </template>
-    </gl-tabs>
   </section>
 </template>

ee/spec/frontend/dependencies/components/__snapshots__/app_spec.js.snap

 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`DependenciesApp component given the dependencyListUi feature flag is enabled on creation given the dependency list job has not yet run shows only the empty state 1`] = `
-Object {
-  "compact": false,
-  "description": "The dependency list details information about the components used within your project.",
-  "primaryButtonLink": null,
-  "primaryButtonText": null,
-  "secondaryButtonLink": null,
-  "secondaryButtonText": null,
-  "svgPath": "/bar.svg",
-  "title": "View dependency details for your project",
-}
-`;
-
-exports[`DependenciesApp component given the dependencyListUi feature flag is enabled on creation given there are no dependencies detected shows only the empty state 1`] = `
-Object {
-  "compact": false,
-  "description": "It seems like the Dependency Scanning job ran successfully, but no dependencies have been detected in your project.",
-  "primaryButtonLink": null,
-  "primaryButtonText": null,
-  "secondaryButtonLink": null,
-  "secondaryButtonText": null,
-  "svgPath": "/bar.svg",
-  "title": "Dependency List has no entries",
-}
-`;
-
 exports[`DependenciesApp component on creation given the dependency list job has not yet run shows only the empty state 1`] = `
 Object {
   "compact": false,