Merge branch '41934-replace-fa-bullhorn-with-gitlab-svg-bullhorn-icon' into 'master'

Resolve "Replace fa-bullhorn with GitLab SVG bullhorn icon (all instances)"

Closes #41934

See merge request gitlab-org/gitlab!21587

app/assets/stylesheets/framework/common.scss

@@ -433,6 +433,7 @@ img.emoji {
 .block { display: block; }
 .flex { display: flex; }
 .vertical-align-top { vertical-align: top; }
+.vertical-align-text-top { vertical-align: text-top; }
 .vertical-align-middle { vertical-align: middle; }
 .vertical-align-sub { vertical-align: sub; }
 .flex-align-self-center { align-self: center; }

app/helpers/broadcast_messages_helper.rb

@@ -9,7 +9,7 @@ module BroadcastMessagesHelper
     return unless message.present?
 
     content_tag :div, dir: 'auto', class: 'broadcast-message', style: broadcast_message_style(message) do
-      icon('bullhorn') << ' ' << render_broadcast_message(message)
+      sprite_icon('bullhorn', size: 16, css_class: 'vertical-align-text-top mr-2') << ' ' << render_broadcast_message(message)
     end
   end
 

app/views/admin/broadcast_messages/_form.html.haml

 .broadcast-message-preview{ style: broadcast_message_style(@broadcast_message) }
-  = icon('bullhorn')
+  = sprite_icon('bullhorn', size: 16, css_class:'vertical-align-text-top mr-2')
   .js-broadcast-message-preview
     - if @broadcast_message.message.present?
       = render_broadcast_message(@broadcast_message)

changelogs/unreleased/41934-replace-fa-bullhorn-with-gitlab-svg-bullhorn-icon.yml

+---
+title: Replace Font Awesome bullhorn icon with GitLab bullhorn icon
+merge_request:
+author:
+type: other