Merge branch 'leaky-constant-fix-20' into 'master'

Fix leaky constant

See merge request gitlab-org/gitlab!32058

.rubocop.yml

@@ -384,7 +384,6 @@ RSpec/LeakyConstantDeclaration:
     - 'spec/mailers/notify_spec.rb'
     - 'spec/migrations/20191125114345_add_admin_mode_protected_path_spec.rb'
     - 'spec/migrations/encrypt_plaintext_attributes_on_application_settings_spec.rb'
-    - 'spec/migrations/cleanup_optimistic_locking_nulls_pt2_fixed_spec.rb'
     - 'spec/models/clusters/cluster_spec.rb'
     - 'spec/models/concerns/batch_destroy_dependent_associations_spec.rb'
     - 'spec/models/concerns/blocks_json_serialization_spec.rb'

changelogs/unreleased/leaky-constant-fix-20.yml

+---
+title: Fix leaky constant issue in nulls pt2 spec
+merge_request: 32058
+author: Rajendra Kadam
+type: fixed

spec/migrations/cleanup_optimistic_locking_nulls_pt2_fixed_spec.rb

@@ -4,11 +4,11 @@ require 'spec_helper'
 require Rails.root.join('db', 'post_migrate', '20200427064130_cleanup_optimistic_locking_nulls_pt2_fixed.rb')
 
 describe CleanupOptimisticLockingNullsPt2Fixed, :migration do
-  TABLES = %w(ci_stages ci_builds ci_pipelines).freeze
-  TABLES.each do |table|
+  test_tables = %w(ci_stages ci_builds ci_pipelines).freeze
+  test_tables.each do |table|
     let(table.to_sym) { table(table.to_sym) }
   end
-  let(:tables) { TABLES.map { |t| method(t.to_sym).call } }
+  let(:tables) { test_tables.map { |t| method(t.to_sym).call } }
 
   before do
     # Create necessary rows