Commit b1c34688 authored by Ezekiel Kigbo's avatar Ezekiel Kigbo

Fixes extra border around form fields

Adds the missing label-for attribute to
the form group elements to render them
as a div with label, instead of fieldset
parent 2f177c1b
...@@ -280,10 +280,10 @@ export default { ...@@ -280,10 +280,10 @@ export default {
<p v-else class="mx-3 my-2">{{ __('All default stages are currently visible') }}</p> <p v-else class="mx-3 my-2">{{ __('All default stages are currently visible') }}</p>
</gl-dropdown> </gl-dropdown>
</div> </div>
<gl-form-group <gl-form-group
ref="name" ref="name"
:label="s__('CustomCycleAnalytics|Name')" :label="s__('CustomCycleAnalytics|Name')"
label-for="custom-stage-name"
:state="!hasFieldErrors('name')" :state="!hasFieldErrors('name')"
:invalid-feedback="fieldErrorMessage('name')" :invalid-feedback="fieldErrorMessage('name')"
> >
...@@ -302,6 +302,7 @@ export default { ...@@ -302,6 +302,7 @@ export default {
<gl-form-group <gl-form-group
ref="startEventIdentifier" ref="startEventIdentifier"
:label="s__('CustomCycleAnalytics|Start event')" :label="s__('CustomCycleAnalytics|Start event')"
label-for="custom-stage-start-event"
:state="!hasFieldErrors('startEventIdentifier')" :state="!hasFieldErrors('startEventIdentifier')"
:invalid-feedback="fieldErrorMessage('startEventIdentifier')" :invalid-feedback="fieldErrorMessage('startEventIdentifier')"
> >
...@@ -318,6 +319,7 @@ export default { ...@@ -318,6 +319,7 @@ export default {
<gl-form-group <gl-form-group
ref="startEventLabelId" ref="startEventLabelId"
:label="s__('CustomCycleAnalytics|Start event label')" :label="s__('CustomCycleAnalytics|Start event label')"
label-for="custom-stage-start-event-label"
:state="!hasFieldErrors('startEventLabelId')" :state="!hasFieldErrors('startEventLabelId')"
:invalid-feedback="fieldErrorMessage('startEventLabelId')" :invalid-feedback="fieldErrorMessage('startEventLabelId')"
> >
...@@ -336,6 +338,7 @@ export default { ...@@ -336,6 +338,7 @@ export default {
<gl-form-group <gl-form-group
ref="endEventIdentifier" ref="endEventIdentifier"
:label="s__('CustomCycleAnalytics|Stop event')" :label="s__('CustomCycleAnalytics|Stop event')"
label-for="custom-stage-stop-event"
:state="!hasFieldErrors('endEventIdentifier')" :state="!hasFieldErrors('endEventIdentifier')"
:invalid-feedback="fieldErrorMessage('endEventIdentifier')" :invalid-feedback="fieldErrorMessage('endEventIdentifier')"
> >
...@@ -353,6 +356,7 @@ export default { ...@@ -353,6 +356,7 @@ export default {
<gl-form-group <gl-form-group
ref="endEventLabelId" ref="endEventLabelId"
:label="s__('CustomCycleAnalytics|Stop event label')" :label="s__('CustomCycleAnalytics|Stop event label')"
label-for="custom-stage-stop-event-label"
:state="!hasFieldErrors('endEventLabelId')" :state="!hasFieldErrors('endEventLabelId')"
:invalid-feedback="fieldErrorMessage('endEventLabelId')" :invalid-feedback="fieldErrorMessage('endEventLabelId')"
> >
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment